mirror/plugin-hub
1
0
Fork 0
mirror of https://github.com/runelite/plugin-hub.git synced 2025-12-23 22:48:49 -05:00
Code Issues Packages Projects Releases Wiki Activity

package/apirecorder: do not record non runtime visible annotation refs

Browse Source
This commit is contained in:
Max Weber
2023-05-15 15:16:54 -06:00
parent 65f67f2a53
commit f60d87567d
2 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
package/apirecorder/build.gradle
View File

@@ -58,7 +58,10 @@ dependencies {
runelite lombok
}
compileJava.options.compilerArgs += ["--add-exports", "jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED"]
compileJava.options.compilerArgs += [
"--add-exports", "jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED",
"--add-exports", "jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
]
def apiFilePath = new File(project.buildDir, "api")

28
package/apirecorder/src/main/java/net/runelite/pluginhub/apirecorder/RecordingTreeScanner.java
View File

@@ -24,6 +24,7 @@
*/
package net.runelite.pluginhub.apirecorder;
import com.sun.source.tree.AnnotationTree;
import com.sun.source.tree.IdentifierTree;
import com.sun.source.tree.ImportTree;
import com.sun.source.tree.MemberSelectTree;
@@ -34,6 +35,8 @@ import com.sun.source.util.JavacTask;
import com.sun.source.util.TreePath;
import com.sun.source.util.TreePathScanner;
import com.sun.source.util.Trees;
import com.sun.tools.javac.api.BasicJavacTask;
import com.sun.tools.javac.code.Attribute;
import com.sun.tools.javac.code.Flags;
import com.sun.tools.javac.code.Symbol;
import java.util.HashMap;
@@ -70,6 +73,7 @@ class RecordingTreeScanner extends TreePathScanner<Void, Void>
private final Trees trees;
private final Elements elements;
private final Types types;
private final com.sun.tools.javac.code.Types internalTypes;
@Getter
@Setter
@@ -80,6 +84,8 @@ class RecordingTreeScanner extends TreePathScanner<Void, Void>
this.trees = Trees.instance(task);
this.elements = task.getElements();
this.types = task.getTypes();
BasicJavacTask internalTask = (BasicJavacTask) task;
this.internalTypes = com.sun.tools.javac.code.Types.instance(internalTask.getContext());
}
@Override
@@ -123,6 +129,28 @@ class RecordingTreeScanner extends TreePathScanner<Void, Void>
return super.visitNewClass(node, unused);
}
@Override
public Void visitAnnotation(AnnotationTree node, Void unused)
{
Element typ = trees.getElement(new TreePath(getCurrentPath(), node.getAnnotationType()));
if (typ instanceof Symbol.TypeSymbol)
{
Symbol.TypeSymbol cs = (Symbol.TypeSymbol) typ;
// non runtime annotations may not exist in the output jar, so they can be
// always considered as missing if we were to record them
if (internalTypes.getRetention(cs) == Attribute.RetentionPolicy.RUNTIME)
{
scan(node.getAnnotationType(), null);
}
}
else
{
unexpected(typ);
}
scan(node.getArguments(), null);
return null;
}
@SneakyThrows
private boolean shouldRecord(Element element)
{