feat(logging): log the end of importing packages from store

ref pnpm/pnpm#1017
This commit is contained in:
Zoltan Kochan
2018-01-30 22:29:11 +02:00
parent c8580a2d55
commit 85eb2a65d5
3 changed files with 13 additions and 3 deletions

View File

@@ -17,7 +17,11 @@ import * as dp from 'dependency-path'
import {Shrinkwrap, DependencyShrinkwrap} from 'pnpm-shrinkwrap'
import removeOrphanPkgs from '../api/removeOrphanPkgs'
import mkdirp = require('mkdirp-promise')
import {rootLogger, statsLogger} from '../loggers'
import {
rootLogger,
statsLogger,
stageLogger,
} from '../loggers'
export default async function linkPackages (
rootNodeIdsByAlias: {[alias: string]: string},
@@ -93,6 +97,7 @@ export default async function linkPackages (
pkgsToLink,
opts
)
stageLogger.debug('importing_done')
const rootPkgsToLinkByAbsolutePath = flatResolvedDeps
.filter(pkg => pkg.depth === 0)

View File

@@ -5,7 +5,7 @@ import baseLogger, {
import {PackageJson} from '@pnpm/types'
export const packageJsonLogger = baseLogger('package-json') as Logger<PackageJsonMessage>
export const stageLogger = baseLogger('stage') as Logger<'resolution_done'>
export const stageLogger = baseLogger('stage') as Logger<'resolution_done' | 'importing_done'>
export const summaryLogger = baseLogger('summary') as Logger<void>
export const installCheckLogger = baseLogger('install-check') as Logger<InstallCheckMessage>
export const deprecationLogger = baseLogger('deprecation') as Logger<DeprecationMessage>
@@ -102,7 +102,7 @@ export type StatsMessage = {
export type ProgressLog = {name: 'pnpm:progress'} & LogBase & ProgressMessage
export type StageLog = {name: 'pnpm:stage'} & LogBase & {message: 'resolution_done'}
export type StageLog = {name: 'pnpm:stage'} & LogBase & {message: 'resolution_done' | 'importing_done'}
export type StatsLog = {name: 'pnpm:stats'} & LogBase & StatsMessage

View File

@@ -75,6 +75,11 @@ test('no dependencies (lodash)', async (t: tape.Test) => {
level: 'debug',
message: 'resolution_done',
}), 'resolution stage done logged')
t.ok(reporter.calledWithMatch(<StageLog>{
name: 'pnpm:stage',
level: 'debug',
message: 'importing_done',
}), 'importing stage done logged')
// Not logged for now
// t.ok(reporter.calledWithMatch({
// level: 'info',