Files
Victor Sumner d5fcecac82 test(fetch): verify pnpm fetch populates global virtual store links/ (#10835)
* test(fetch): verify pnpm fetch populates global virtual store links/

pnpm fetch flows through headlessInstall → lockfileToDepGraph →
iteratePkgsForVirtualStore, which respects enableGlobalVirtualStore.
When enabled, packages are written to the store's links/ directory
instead of only the CAS. This behavior is relied upon by tools that
pre-build stores (Docker multistage builds, Nix, CI caching) but was
not covered by any test.

Also adds enableGlobalVirtualStore to FetchCommandOptions type to
match the runtime behavior where the option flows through via the
opts spread.

* test(fetch): use lockfileOnly instead of full install in GVS test

The test only needs a lockfile for the fetch step, so a full install
followed by rimraf of node_modules is unnecessary.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Zoltan Kochan <z@kochan.io>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-03 21:40:24 +01:00

224 lines
5.8 KiB
TypeScript

import fs from 'fs'
import path from 'path'
import { STORE_VERSION } from '@pnpm/constants'
import { install, fetch } from '@pnpm/plugin-commands-installation'
import { prepare } from '@pnpm/prepare'
import { REGISTRY_MOCK_PORT } from '@pnpm/registry-mock'
import { sync as rimraf } from '@zkochan/rimraf'
const REGISTRY_URL = `http://localhost:${REGISTRY_MOCK_PORT}`
const DEFAULT_OPTIONS = {
argv: {
original: [],
},
bail: false,
bin: 'node_modules/.bin',
cliOptions: {},
deployAllFiles: false,
excludeLinksFromLockfile: false,
extraEnv: {},
include: {
dependencies: true,
devDependencies: true,
optionalDependencies: true,
},
lock: true,
preferWorkspacePackages: true,
pnpmfile: ['.pnpmfile.cjs'],
pnpmHomeDir: '',
rawConfig: { registry: REGISTRY_URL },
rawLocalConfig: { registry: REGISTRY_URL },
registries: {
default: REGISTRY_URL,
},
rootProjectManifestDir: '',
sort: true,
userConfig: {},
workspaceConcurrency: 1,
virtualStoreDirMaxLength: process.platform === 'win32' ? 60 : 120,
}
test('fetch dependencies', async () => {
const project = prepare({
dependencies: { 'is-positive': '1.0.0' },
devDependencies: { 'is-negative': '1.0.0' },
})
const storeDir = path.resolve('store')
await install.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dir: process.cwd(),
linkWorkspacePackages: true,
storeDir,
})
rimraf(path.resolve(project.dir(), 'node_modules'))
rimraf(path.resolve(project.dir(), './package.json'))
project.storeHasNot('is-negative')
project.storeHasNot('is-positive')
await fetch.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dir: process.cwd(),
storeDir,
})
project.storeHas('is-positive')
project.storeHas('is-negative')
})
test('fetch production dependencies', async () => {
const project = prepare({
dependencies: { 'is-positive': '1.0.0' },
devDependencies: { 'is-negative': '1.0.0' },
})
const storeDir = path.resolve('store')
await install.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dir: process.cwd(),
linkWorkspacePackages: true,
storeDir,
})
rimraf(path.resolve(project.dir(), 'node_modules'))
rimraf(path.resolve(project.dir(), './package.json'))
project.storeHasNot('is-negative')
project.storeHasNot('is-positive')
await fetch.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dev: true,
dir: process.cwd(),
storeDir,
})
project.storeHasNot('is-negative')
project.storeHas('is-positive')
})
test('fetch only dev dependencies', async () => {
const project = prepare({
dependencies: { 'is-positive': '1.0.0' },
devDependencies: { 'is-negative': '1.0.0' },
})
const storeDir = path.resolve('store')
await install.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dir: process.cwd(),
linkWorkspacePackages: true,
storeDir,
})
rimraf(path.resolve(project.dir(), 'node_modules'))
rimraf(path.resolve(project.dir(), './package.json'))
project.storeHasNot('is-negative')
project.storeHasNot('is-positive')
await fetch.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dev: true,
dir: process.cwd(),
storeDir,
})
project.storeHas('is-negative')
project.storeHasNot('is-positive')
})
// Regression test for https://github.com/pnpm/pnpm/issues/10460
// pnpm fetch should skip local file: protocol dependencies
// because they won't be available in Docker builds
test('fetch skips file: protocol dependencies that do not exist', async () => {
const project = prepare({
dependencies: {
'is-positive': '1.0.0',
'@local/pkg': 'file:./local-pkg',
},
})
const storeDir = path.resolve('store')
const localPkgDir = path.resolve(project.dir(), 'local-pkg')
// Create the local package for initial install to generate lockfile
fs.mkdirSync(localPkgDir, { recursive: true })
fs.writeFileSync(
path.join(localPkgDir, 'package.json'),
JSON.stringify({ name: '@local/pkg', version: '1.0.0' })
)
// Create a lockfile with the file: dependency
await install.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dir: process.cwd(),
linkWorkspacePackages: true,
storeDir,
})
rimraf(path.resolve(project.dir(), 'node_modules'))
rimraf(path.resolve(project.dir(), './package.json'))
// Remove the local package directory to simulate Docker build scenario
rimraf(localPkgDir)
project.storeHasNot('is-positive')
// This should not throw an error even though the file: dependency doesn't exist
await fetch.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dir: process.cwd(),
storeDir,
})
project.storeHas('is-positive')
})
test('fetch populates global virtual store links/', async () => {
prepare({
dependencies: {
'is-positive': '1.0.0',
},
devDependencies: {
'is-negative': '1.0.0',
},
})
const storeDir = path.resolve('store')
const globalVirtualStoreDir = path.join(storeDir, STORE_VERSION, 'links')
// Generate the lockfile only — no need for a full install
await install.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dir: process.cwd(),
linkWorkspacePackages: true,
lockfileOnly: true,
storeDir,
})
// Remove the store — simulate a cold start with only the lockfile
rimraf(storeDir)
// Fetch with enableGlobalVirtualStore — should populate links/
await fetch.handler({
...DEFAULT_OPTIONS,
cacheDir: path.resolve('cache'),
dir: process.cwd(),
storeDir,
enableGlobalVirtualStore: true,
})
// The global virtual store links/ directory should exist and contain packages
expect(fs.existsSync(globalVirtualStoreDir)).toBeTruthy()
const entries = fs.readdirSync(globalVirtualStoreDir)
expect(entries.length).toBeGreaterThan(0)
})