mirror of
https://github.com/pnpm/pnpm.git
synced 2026-06-28 01:45:30 -04:00
ec7cf70853
The dlx cache path is <cacheDir>/dlx/<key>/<prepare>/node_modules/.pnpm/ <pkgId>/node_modules/<pkg>. The <key> (64-char sha256 hex) and <prepare> (<time>-<pid> in hex) segments are dlx overhead on top of pnpm's already- deep virtual-store layout. For a transitive dep with a long name this tips the package directory over Windows' MAX_PATH (260) — measured at 259 chars for @pnpm.e2e/pre-and-postinstall-scripts-example in the dlx e2e test. A lifecycle script then runs with that directory as its cwd, and CreateProcess fails to resolve an over-length cwd, which Node surfaces as the confusing "spawn C:\Windows\system32\cmd.exe ENOENT". Flaky rather than constant because the <prepare> and temp-dir segments vary in length, straddling 260. Shorten both dlx-specific segments: - cache key: createShortHash (32 hex, 128 bits) instead of createHexHash (64). pacquet already truncated to 32, so this also restores parity. - prepare dir: encode time and pid in base36 instead of hex.
63 lines
2.1 KiB
TypeScript
63 lines
2.1 KiB
TypeScript
import { expect, test } from '@jest/globals'
|
|
import { createShortHash } from '@pnpm/crypto.hash'
|
|
|
|
import { createCacheKey } from '../src/dlx.js'
|
|
|
|
test('creates a hash', () => {
|
|
const received = createCacheKey({
|
|
packages: ['shx', '@foo/bar'],
|
|
registries: {
|
|
default: 'https://registry.npmjs.com/',
|
|
'@foo': 'https://example.com/npm-registry/foo/',
|
|
},
|
|
})
|
|
const expected = createShortHash(JSON.stringify([['@foo/bar', 'shx'], [
|
|
['@foo', 'https://example.com/npm-registry/foo/'],
|
|
['default', 'https://registry.npmjs.com/'],
|
|
]]))
|
|
expect(received).toBe(expected)
|
|
})
|
|
|
|
test('is agnostic to package order', () => {
|
|
const registries = { default: 'https://registry.npmjs.com/' }
|
|
const makeOpts = (packages: string[]) => ({ packages, registries })
|
|
expect(createCacheKey(makeOpts(['a', 'c', 'b']))).toBe(createCacheKey(makeOpts(['a', 'b', 'c'])))
|
|
expect(createCacheKey(makeOpts(['b', 'a', 'c']))).toBe(createCacheKey(makeOpts(['a', 'b', 'c'])))
|
|
expect(createCacheKey(makeOpts(['b', 'c', 'a']))).toBe(createCacheKey(makeOpts(['a', 'b', 'c'])))
|
|
expect(createCacheKey(makeOpts(['c', 'a', 'b']))).toBe(createCacheKey(makeOpts(['a', 'b', 'c'])))
|
|
expect(createCacheKey(makeOpts(['c', 'b', 'a']))).toBe(createCacheKey(makeOpts(['a', 'b', 'c'])))
|
|
})
|
|
|
|
test('is agnostic to registry key order', () => {
|
|
const packages = ['a', 'b', 'c']
|
|
const foo = 'https://example.com/foo/'
|
|
const bar = 'https://example.com/bar/'
|
|
expect(createCacheKey({
|
|
packages,
|
|
registries: { '@foo': foo, '@bar': bar },
|
|
})).toBe(createCacheKey({
|
|
packages,
|
|
registries: { '@bar': bar, '@foo': foo },
|
|
}))
|
|
})
|
|
|
|
test('is agnostic to supportedArchitectures values order', () => {
|
|
const packages = ['a', 'b', 'c']
|
|
const registries = { default: 'https://registry.npmjs.com/' }
|
|
expect(createCacheKey({
|
|
packages,
|
|
registries,
|
|
supportedArchitectures: {
|
|
os: ['win32', 'linux', 'darwin'],
|
|
cpu: ['x86_64', 'armv7', 'i686'],
|
|
},
|
|
})).toBe(createCacheKey({
|
|
packages,
|
|
registries,
|
|
supportedArchitectures: {
|
|
cpu: ['armv7', 'i686', 'x86_64'],
|
|
os: ['darwin', 'linux', 'win32'],
|
|
},
|
|
}))
|
|
})
|