Files
pnpm/workspace/state/test/createWorkspaceState.test.ts
palkim e51c8e281e fix: refresh ignored builds when allowBuilds changes (#11366)
* fix: refresh ignored builds when allowBuilds changes

* refactor: extract isBuildExplicitlyDisallowed into @pnpm/building.policy

Removes the duplicated ignored-build filter from deps-installer and
deps-restorer and exposes it as `isBuildExplicitlyDisallowed` on
`@pnpm/building.policy`, alongside `createAllowBuildFunction`.

* fix: respect ignoredWorkspaceStateSettings in allowBuilds stale-state check

The fallback that flagged installs when allowBuilds went from unset to
non-empty bypassed the ignoredSettings filter, so callers that explicitly
opted out of allowBuilds tracking (via ignoredWorkspaceStateSettings)
could still be forced into a redundant install.

---------

Co-authored-by: Zoltan Kochan <z@kochan.io>
2026-05-05 01:17:11 +00:00

126 lines
3.5 KiB
TypeScript

import path from 'node:path'
import { expect, test } from '@jest/globals'
import { prepareEmpty, preparePackages } from '@pnpm/prepare'
import type { ProjectRootDir } from '@pnpm/types'
import { createWorkspaceState } from '../src/createWorkspaceState.js'
test('createWorkspaceState() on empty list', () => {
prepareEmpty()
expect(
createWorkspaceState({
allProjects: [],
pnpmfiles: [],
filteredInstall: false,
settings: {
autoInstallPeers: true,
dedupeDirectDeps: true,
excludeLinksFromLockfile: false,
preferWorkspacePackages: false,
linkWorkspacePackages: false,
injectWorkspacePackages: false,
},
})
).toStrictEqual(expect.objectContaining({
projects: {},
pnpmfiles: [],
lastValidatedTimestamp: expect.any(Number),
}))
})
test('createWorkspaceState() saves lockfile-affecting settings', () => {
prepareEmpty()
const state = createWorkspaceState({
allProjects: [],
pnpmfiles: [],
filteredInstall: false,
settings: {
allowBuilds: {
'@pnpm.e2e/pre-and-postinstall-scripts-example': false,
},
autoInstallPeers: true,
dedupeDirectDeps: true,
excludeLinksFromLockfile: false,
preferWorkspacePackages: false,
linkWorkspacePackages: false,
injectWorkspacePackages: false,
overrides: {
foo: '1.0.0',
},
packageExtensions: {
bar: { dependencies: { baz: '2.0.0' } },
},
ignoredOptionalDependencies: ['qux'],
patchedDependencies: {
'some-pkg': 'patches/some-pkg.patch',
},
peersSuffixMaxLength: 100,
},
})
expect(state.settings.allowBuilds).toStrictEqual({
'@pnpm.e2e/pre-and-postinstall-scripts-example': false,
})
expect(state.settings.overrides).toStrictEqual({ foo: '1.0.0' })
expect(state.settings.packageExtensions).toStrictEqual({
bar: { dependencies: { baz: '2.0.0' } },
})
expect(state.settings.ignoredOptionalDependencies).toStrictEqual(['qux'])
expect(state.settings.patchedDependencies).toStrictEqual({
'some-pkg': 'patches/some-pkg.patch',
})
expect(state.settings.peersSuffixMaxLength).toBe(100)
})
test('createWorkspaceState() on non-empty list', () => {
preparePackages(['a', 'b', 'c', 'd'].map(name => ({
location: `./packages/${name}`,
package: { name },
})))
expect(
createWorkspaceState({
allProjects: [
{ rootDir: path.resolve('packages/c') as ProjectRootDir, manifest: {} },
{ rootDir: path.resolve('packages/b') as ProjectRootDir, manifest: {} },
{ rootDir: path.resolve('packages/a') as ProjectRootDir, manifest: {} },
{ rootDir: path.resolve('packages/d') as ProjectRootDir, manifest: {} },
],
settings: {
autoInstallPeers: true,
dedupeDirectDeps: true,
excludeLinksFromLockfile: false,
preferWorkspacePackages: false,
linkWorkspacePackages: false,
injectWorkspacePackages: false,
catalogs: {
default: {
foo: '0.1.2',
},
},
},
pnpmfiles: [],
filteredInstall: false,
})
).toStrictEqual(expect.objectContaining({
settings: expect.objectContaining({
catalogs: {
default: {
foo: '0.1.2',
},
},
}),
lastValidatedTimestamp: expect.any(Number),
projects: {
[path.resolve('packages/a')]: {},
[path.resolve('packages/b')]: {},
[path.resolve('packages/c')]: {},
[path.resolve('packages/d')]: {},
},
pnpmfiles: [],
}))
})