Files
Brandon Cheng a2f5f5c990 test: fix file system race conditions in tests by switching to an IPC server (#7472)
* test: create new @pnpm/test-ipc-server private util package

* test: use @pnpm/test-ipc-server for previously refactored tests

* test: use @pnpm/test-ipc-server for tests using json-append

* test: change how --no-bail is passed to avoid passing it to scripts

This test began failing after the conversion to use
`@pnpm/test-echo-server` since the `--no-bail` script was being passed
to scripts.

Changing how --no-bail is configured to fix this test.

* test: use @pnpm/test-ipc-server in exec/lifecycle fixture tests

* test: use @pnpm/test-ipc-server in pkg-manager/headless fixture tests

* test: use @pnpm/test-ipc-server in exec/prepare-package fixture tests

* test: switch pnpm test from json-append to @pnpm.e2e/hello-world-js-bin

* test: fix and re-enable 'rebuild multiple packages in correct order'

The pnpm-workspace.yaml file didn't contain all packages, causing:

```
2023-12-22T02:24:46.2277155Z FAIL test/recursive.ts
2023-12-22T02:24:46.2277881Z   ● rebuild multiple packages in correct order
2023-12-22T02:24:46.2278348Z
2023-12-22T02:24:46.2278734Z     expect(received).toStrictEqual(expected) // deep equality
2023-12-22T02:24:46.2279302Z
2023-12-22T02:24:46.2279517Z     - Expected  - 1
2023-12-22T02:24:46.2279932Z     + Received  + 0
2023-12-22T02:24:46.2280186Z
2023-12-22T02:24:46.2280791Z       Array [
2023-12-22T02:24:46.2281256Z         "project-1",
2023-12-22T02:24:46.2281733Z     -   "project-2",
2023-12-22T02:24:46.2282135Z       ]
2023-12-22T02:24:46.2282334Z
2023-12-22T02:24:46.2282475Z       216 |   }, [])
2023-12-22T02:24:46.2282870Z       217 |
2023-12-22T02:24:46.2283788Z     > 218 |   expect(server1.getMessages()).toStrictEqual(['project-1', 'project-2'])
2023-12-22T02:24:46.2284725Z           |                                 ^
2023-12-22T02:24:46.2285802Z       219 |   expect(server2.getMessages()).toStrictEqual(['project-1', 'project-3'])
2023-12-22T02:24:46.2286683Z       220 | })
2023-12-22T02:24:46.2287049Z       221 |
2023-12-22T02:24:46.2287269Z
2023-12-22T02:24:46.2287588Z       at Object.<anonymous> (test/recursive.ts:218:33)
```
2024-01-01 16:40:03 +01:00

880 lines
21 KiB
TypeScript

import { promises as fs } from 'fs'
import path from 'path'
import { type PnpmError } from '@pnpm/error'
import { readProjects } from '@pnpm/filter-workspace-packages'
import { exec, run } from '@pnpm/plugin-commands-script-runners'
import { prepare, prepareEmpty, preparePackages } from '@pnpm/prepare'
import { createTestIpcServer } from '@pnpm/test-ipc-server'
import execa from 'execa'
import { DEFAULT_OPTS, REGISTRY_URL } from './utils'
const pnpmBin = path.join(__dirname, '../../../pnpm/bin/pnpm.cjs')
const testOnPosixOnly = process.platform === 'win32' ? test.skip : test
test('pnpm recursive exec', async () => {
await using server1 = await createTestIpcServer()
await using server2 = await createTestIpcServer()
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
build: `${server1.sendLineScript('project-1')} && ${server2.sendLineScript('project-1')}`,
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server1.sendLineScript('project-2'),
postbuild: server1.sendLineScript('project-2-postbuild'),
prebuild: server1.sendLineScript('project-2-prebuild'),
},
},
{
name: 'project-3',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server2.sendLineScript('project-3'),
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
}, ['npm', 'run', 'build'])
expect(server1.getLines()).toStrictEqual(['project-1', 'project-2-prebuild', 'project-2', 'project-2-postbuild'])
expect(server2.getLines()).toStrictEqual(['project-1', 'project-3'])
})
test('pnpm recursive exec finds bin files of workspace projects', async () => {
preparePackages([
{
name: 'project-1',
version: '1.0.0',
dependencies: {
cowsay: '1.5.0',
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
cowsay: '1.5.0',
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
}, ['cowsay', 'hi'])
// If there was no exception, the test passed
})
test('exec inside a workspace package', async () => {
await using server1 = await createTestIpcServer()
await using server2 = await createTestIpcServer()
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
build: `${server1.sendLineScript('project-1')} && ${server2.sendLineScript('project-1')}`,
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server1.sendLineScript('project-2'),
postbuild: server1.sendLineScript('project-2-postbuild'),
prebuild: server1.sendLineScript('project-2-prebuild'),
},
},
{
name: 'project-3',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server2.sendLineScript('project-3'),
},
},
])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
await exec.handler({
...DEFAULT_OPTS,
dir: path.resolve('project-1'),
recursive: false,
selectedProjectsGraph: {},
}, ['npm', 'run', 'build'])
expect(server1.getLines()).toStrictEqual(['project-1'])
expect(server2.getLines()).toStrictEqual(['project-1'])
})
test('pnpm recursive exec sets PNPM_PACKAGE_NAME env var', async () => {
preparePackages([
{
name: 'foo',
version: '1.0.0',
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
}, ['node', '-e', 'require(\'fs\').writeFileSync(\'pkgname\', process.env.PNPM_PACKAGE_NAME, \'utf8\')'])
expect(await fs.readFile('foo/pkgname', 'utf8')).toBe('foo')
})
test('testing the bail config with "pnpm recursive exec"', async () => {
await using server = await createTestIpcServer()
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
build: server.sendLineScript('project-1'),
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: `exit 1 && ${server.sendLineScript('project-2')}`,
},
},
{
name: 'project-3',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server.sendLineScript('project-3'),
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
let failed = false
let err1!: PnpmError
try {
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
}, ['npm', 'run', 'build', '--no-bail'])
} catch (_err: any) { // eslint-disable-line
err1 = _err
failed = true
}
expect(err1.code).toBe('ERR_PNPM_RECURSIVE_FAIL')
expect(failed).toBeTruthy()
expect(server.getLines()).toStrictEqual(['project-1', 'project-3'])
failed = false
let err2!: PnpmError
try {
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
}, ['npm', 'run', 'build'])
} catch (_err: any) { // eslint-disable-line
err2 = _err
failed = true
}
expect(err2.code).toBe('ERR_PNPM_RECURSIVE_FAIL')
expect(failed).toBeTruthy()
})
test('pnpm recursive exec --no-sort', async () => {
await using server = await createTestIpcServer()
preparePackages([
{
name: 'a-dependent',
version: '1.0.0',
dependencies: {
'b-dependency': '1.0.0',
},
scripts: {
build: server.sendLineScript('a-dependent'),
},
},
{
name: 'b-dependency',
version: '1.0.0',
scripts: {
build: server.sendLineScript('b-dependency'),
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
sort: false,
workspaceConcurrency: 1,
}, ['npm', 'run', 'build'])
expect(server.getLines()).toStrictEqual(['a-dependent', 'b-dependency'])
})
test('pnpm recursive exec --reverse', async () => {
await using server = await createTestIpcServer()
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
build: server.sendLineScript('project-1'),
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server.sendLineScript('project-2'),
},
},
{
name: 'project-3',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server.sendLineScript('project-3'),
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
selectedProjectsGraph,
recursive: true,
sort: true,
reverse: true,
}, ['npm', 'run', 'build'])
const outputs1 = server.getLines()
expect(outputs1[outputs1.length - 1]).toBe('project-1')
})
test('pnpm exec on single project', async () => {
prepare({})
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: false,
selectedProjectsGraph: {},
}, ['node', '-e', 'require("fs").writeFileSync("output.json", "[]", "utf8")'])
const { default: outputs } = await import(path.resolve('output.json'))
expect(outputs).toStrictEqual([])
})
test('pnpm exec on single project should return non-zero exit code when the process fails', async () => {
prepare({})
{
const { exitCode } = await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: false,
selectedProjectsGraph: {},
}, ['node', '-e', 'process.exitCode=1'])
expect(exitCode).toBe(1)
}
{
const runResult = await run.handler({
...DEFAULT_OPTS,
argv: {
original: ['pnpm', 'node', '-e', 'process.exitCode=1'],
},
dir: process.cwd(),
fallbackCommandUsed: true,
recursive: false,
selectedProjectsGraph: {},
}, ['node'])
expect(runResult).toHaveProperty(['exitCode'], 1)
}
})
test('pnpm exec outside of projects', async () => {
prepareEmpty()
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: false,
selectedProjectsGraph: {},
}, ['node', '-e', 'require("fs").writeFileSync("output.json", "[]", "utf8")'])
const { default: outputs } = await import(path.resolve('output.json'))
expect(outputs).toStrictEqual([])
})
test('pnpm exec shell mode', async () => {
prepareEmpty()
const echoArgs = process.platform === 'win32' ? '%PNPM_PACKAGE_NAME% > name.txt' : '$PNPM_PACKAGE_NAME > name.txt'
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: false,
selectedProjectsGraph: {
[process.cwd()]: {
dependencies: [],
package: {
dir: process.cwd(),
writeProjectManifest: async () => {},
manifest: {
name: 'test_shell_mode',
},
},
},
},
shellMode: true,
}, ['echo', echoArgs])
const result = (await fs.readFile(path.resolve('name.txt'), 'utf8')).trim()
expect(result).toBe('test_shell_mode')
})
// This test is not stable on Windows
testOnPosixOnly('pnpm recursive exec works with PnP', async () => {
await using server1 = await createTestIpcServer()
await using server2 = await createTestIpcServer()
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
build: `${server1.sendLineScript('project-1')} && ${server2.sendLineScript('project-1')}`,
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server1.sendLineScript('project-2'),
postbuild: server1.sendLineScript('project-2-postbuild'),
prebuild: server1.sendLineScript('project-2-prebuild'),
},
},
{
name: 'project-3',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server2.sendLineScript('project-3'),
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
], {
env: {
NPM_CONFIG_NODE_LINKER: 'pnp',
NPM_CONFIG_SYMLINK: 'false',
},
})
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
}, ['npm', 'run', 'build'])
expect(server1.getLines()).toStrictEqual(['project-1', 'project-2-prebuild', 'project-2', 'project-2-postbuild'])
expect(server2.getLines()).toStrictEqual(['project-1', 'project-3'])
})
test('pnpm recursive exec --resume-from should work', async () => {
await using server = await createTestIpcServer()
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
build: server.sendLineScript('project-1'),
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server.sendLineScript('project-2'),
},
},
{
name: 'project-3',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
build: server.sendLineScript('project-3'),
},
},
{
name: 'project-4',
version: '1.0.0',
scripts: {
build: server.sendLineScript('project-4'),
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
selectedProjectsGraph,
recursive: true,
sort: true,
resumeFrom: 'project-3',
}, ['npm', 'run', 'build'])
expect(server.getLines().sort()).toEqual(['project-2', 'project-3'])
})
test('should throw error when the package specified by resume-from does not exist', async () => {
preparePackages([
{
name: 'foo',
version: '1.0.0',
scripts: {
build: 'echo foo',
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
try {
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
selectedProjectsGraph,
recursive: true,
sort: true,
resumeFrom: 'project-2',
}, ['npm', 'run', 'build'])
} catch (err: any) { // eslint-disable-line
expect(err.code).toBe('ERR_PNPM_RESUME_FROM_NOT_FOUND')
}
})
test('pnpm exec in directory with path delimiter', async () => {
preparePackages([
{
name: `foo${path.delimiter}delimiter`,
version: '1.0.0',
dependencies: {
cowsay: '1.5.0',
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
let error
try {
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
selectedProjectsGraph,
recursive: true,
}, ['cowsay', 'hi'])
} catch (err: any) { // eslint-disable-line
error = err
}
expect(error).toBeUndefined()
})
test('pnpm recursive exec report summary', async () => {
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
build: 'node -e "setTimeout(() => console.log(\'project-1\'), 1000)"',
},
},
{
name: 'project-2',
version: '1.0.0',
scripts: {
build: 'exit 1',
},
},
{
name: 'project-3',
version: '1.0.0',
scripts: {
build: 'node -e "setTimeout(() => console.log(\'project-3\'), 1000)"',
},
},
{
name: 'project-4',
version: '1.0.0',
scripts: {
build: 'exit 1',
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
let error
try {
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
selectedProjectsGraph,
recursive: true,
reportSummary: true,
workspaceConcurrency: 3,
}, ['npm', 'run', 'build'])
} catch (err: any) { // eslint-disable-line
error = err
}
expect(error.code).toBe('ERR_PNPM_RECURSIVE_FAIL')
const { default: { executionStatus } } = (await import(path.resolve('pnpm-exec-summary.json')))
expect(executionStatus[path.resolve('project-1')].status).toBe('passed')
expect(executionStatus[path.resolve('project-1')].duration).not.toBeFalsy()
expect(executionStatus[path.resolve('project-2')].status).toBe('failure')
expect(executionStatus[path.resolve('project-2')].duration).not.toBeFalsy()
expect(executionStatus[path.resolve('project-3')].status).toBe('passed')
expect(executionStatus[path.resolve('project-3')].duration).not.toBeFalsy()
expect(executionStatus[path.resolve('project-4')].status).toBe('failure')
expect(executionStatus[path.resolve('project-4')].duration).not.toBeFalsy()
})
test('pnpm recursive exec report summary with --bail', async () => {
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
build: 'node -e "setTimeout(() => console.log(\'project-1\'), 1000)"',
},
},
{
name: 'project-2',
version: '1.0.0',
scripts: {
build: 'exit 1',
},
},
{
name: 'project-3',
version: '1.0.0',
scripts: {
build: 'node -e "setTimeout(() => console.log(\'project-3\'), 1000)"',
},
},
{
name: 'project-4',
version: '1.0.0',
scripts: {
build: 'exit 1',
},
},
])
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
let error
try {
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
selectedProjectsGraph,
recursive: true,
reportSummary: true,
bail: true,
workspaceConcurrency: 3,
}, ['npm', 'run', 'build'])
} catch (err: any) { // eslint-disable-line
error = err
}
expect(error.code).toBe('ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL')
const { default: { executionStatus } } = (await import(path.resolve('pnpm-exec-summary.json')))
expect(executionStatus[path.resolve('project-1')].status).toBe('running')
expect(executionStatus[path.resolve('project-2')].status).toBe('failure')
expect(executionStatus[path.resolve('project-2')].duration).not.toBeFalsy()
expect(executionStatus[path.resolve('project-3')].status).toBe('running')
expect(executionStatus[path.resolve('project-4')].status).toBe('queued')
})
test('pnpm exec command not found (implicit fallback)', async () => {
prepare({
scripts: {
build: 'echo hello',
},
})
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
let error!: Error & { hint?: string }
try {
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: false,
bail: true,
selectedProjectsGraph,
implicitlyFellbackFromRun: true,
}, ['buil']) // cspell:disable-line
} catch (err: any) { // eslint-disable-line
error = err
}
expect(error?.message).toBe('Command "buil" not found') // cspell:disable-line
expect(error?.hint).toBe('Did you mean "pnpm build"?')
})
test('pnpm exec command not found (explicit call, without near name packages)', async () => {
prepare({
scripts: {
cwsay: 'echo hello',
},
})
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
let error!: Error & { hint?: string }
try {
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: false,
bail: true,
selectedProjectsGraph,
implicitlyFellbackFromRun: false,
}, ['cwsay'])
} catch (err: any) { // eslint-disable-line
error = err
}
expect(error?.message).toBe('Command "cwsay" not found')
expect(error?.hint).toBeFalsy()
})
test('pnpm exec command not found (explicit call, with a near name package)', async () => {
prepare({
dependencies: {
cowsay: '1.5.0',
},
})
const { selectedProjectsGraph } = await readProjects(process.cwd(), [])
await execa(pnpmBin, [
'install',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
let error!: Error & { hint?: string }
try {
await exec.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
recursive: false,
bail: true,
selectedProjectsGraph,
implicitlyFellbackFromRun: false,
}, ['cwsay'])
} catch (err: any) { // eslint-disable-line
error = err
}
expect(error?.message).toBe('Command "cwsay" not found')
expect(error?.hint).toBe('Did you mean "pnpm exec cowsay"?')
})
test('pnpm exec --workspace-root when command not found', async () => {
prepare({})
let error!: any // eslint-disable-line
try {
await run.handler({
...DEFAULT_OPTS,
argv: {
original: ['pnpm', '--workspace-root', 'command-that-does-not-exist'],
},
dir: process.cwd(),
fallbackCommandUsed: true,
recursive: false,
selectedProjectsGraph: {},
}, ['command-that-does-not-exist'])
} catch (err: any) { // eslint-disable-line
error = err
}
expect(error?.failures[0].message).toBe('Command "command-that-does-not-exist" not found')
})