mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-12 10:11:42 -04:00
4d7cd56ccc
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
111 lines
3.0 KiB
TypeScript
111 lines
3.0 KiB
TypeScript
import { beforeEach, expect, jest, test } from '@jest/globals'
|
|
import { PnpmError } from '@pnpm/error'
|
|
|
|
const mockRunPnpmCli = jest.fn()
|
|
jest.unstable_mockModule('@pnpm/exec.pnpm-cli-runner', () => ({
|
|
runPnpmCli: mockRunPnpmCli,
|
|
}))
|
|
|
|
const { runtime } = await import('@pnpm/engine.runtime.commands')
|
|
|
|
beforeEach(() => {
|
|
mockRunPnpmCli.mockClear()
|
|
})
|
|
|
|
test('runtime set calls pnpm add with the correct arguments globally', async () => {
|
|
await runtime.handler({
|
|
bin: '/usr/local/bin',
|
|
cacheDir: '/tmp/cache',
|
|
dir: '/tmp/project',
|
|
global: true,
|
|
pnpmHomeDir: '/tmp/pnpm-home',
|
|
storeDir: '/tmp/store',
|
|
}, ['set', 'node', '22'])
|
|
|
|
expect(mockRunPnpmCli).toHaveBeenCalledWith(
|
|
['add', 'node@runtime:22', '--global', '--global-bin-dir', '/usr/local/bin', '--store-dir', '/tmp/store', '--cache-dir', '/tmp/cache'],
|
|
{ cwd: '/tmp/pnpm-home' }
|
|
)
|
|
})
|
|
|
|
test('runtime set uses project dir when not global', async () => {
|
|
await runtime.handler({
|
|
bin: '/usr/local/bin',
|
|
dir: '/tmp/project',
|
|
global: false,
|
|
pnpmHomeDir: '/tmp/pnpm-home',
|
|
}, ['set', 'node', '22'])
|
|
|
|
expect(mockRunPnpmCli).toHaveBeenCalledWith(
|
|
['add', 'node@runtime:22'],
|
|
{ cwd: '/tmp/project' }
|
|
)
|
|
})
|
|
|
|
test('runtime set without version spec', async () => {
|
|
await runtime.handler({
|
|
bin: '/usr/local/bin',
|
|
dir: '/tmp/project',
|
|
global: true,
|
|
pnpmHomeDir: '/tmp/pnpm-home',
|
|
}, ['set', 'node'])
|
|
|
|
expect(mockRunPnpmCli).toHaveBeenCalledWith(
|
|
['add', 'node@runtime:', '--global', '--global-bin-dir', '/usr/local/bin'],
|
|
{ cwd: '/tmp/pnpm-home' }
|
|
)
|
|
})
|
|
|
|
test('runtime set works with deno', async () => {
|
|
await runtime.handler({
|
|
bin: '/usr/local/bin',
|
|
dir: '/tmp/project',
|
|
global: true,
|
|
pnpmHomeDir: '/tmp/pnpm-home',
|
|
}, ['set', 'deno', '2'])
|
|
|
|
expect(mockRunPnpmCli).toHaveBeenCalledWith(
|
|
['add', 'deno@runtime:2', '--global', '--global-bin-dir', '/usr/local/bin'],
|
|
{ cwd: '/tmp/pnpm-home' }
|
|
)
|
|
})
|
|
|
|
test('fail if no subcommand is given', async () => {
|
|
await expect(
|
|
runtime.handler({
|
|
bin: '/usr/local/bin',
|
|
dir: '/tmp/project',
|
|
global: true,
|
|
pnpmHomeDir: '/tmp/pnpm-home',
|
|
}, [])
|
|
).rejects.toEqual(new PnpmError('RUNTIME_NO_SUBCOMMAND', 'Please specify the subcommand'))
|
|
|
|
expect(mockRunPnpmCli).not.toHaveBeenCalled()
|
|
})
|
|
|
|
test('fail if unknown subcommand is given', async () => {
|
|
await expect(
|
|
runtime.handler({
|
|
bin: '/usr/local/bin',
|
|
dir: '/tmp/project',
|
|
global: true,
|
|
pnpmHomeDir: '/tmp/pnpm-home',
|
|
}, ['foo'])
|
|
).rejects.toEqual(new PnpmError('RUNTIME_UNKNOWN_SUBCOMMAND', 'Unknown subcommand: foo'))
|
|
|
|
expect(mockRunPnpmCli).not.toHaveBeenCalled()
|
|
})
|
|
|
|
test('fail if runtime name is missing', async () => {
|
|
await expect(
|
|
runtime.handler({
|
|
bin: '/usr/local/bin',
|
|
dir: '/tmp/project',
|
|
global: true,
|
|
pnpmHomeDir: '/tmp/pnpm-home',
|
|
}, ['set'])
|
|
).rejects.toEqual(new PnpmError('MISSING_RUNTIME_NAME', '"pnpm runtime set <name> <version>" requires a runtime name (e.g. node, deno, bun)'))
|
|
|
|
expect(mockRunPnpmCli).not.toHaveBeenCalled()
|
|
})
|