mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-12 10:11:42 -04:00
4d7cd56ccc
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
145 lines
4.2 KiB
TypeScript
145 lines
4.2 KiB
TypeScript
import { beforeEach, expect, it, jest } from '@jest/globals'
|
|
import { PnpmError } from '@pnpm/error'
|
|
|
|
import { DLX_DEFAULT_OPTS as DEFAULT_OPTS } from './utils/index.js'
|
|
|
|
jest.unstable_mockModule('../src/dlx.js', () => ({ handler: jest.fn() }))
|
|
|
|
const { create, dlx } = await import('../src/index.js')
|
|
|
|
beforeEach(() => {
|
|
jest.mocked(dlx.handler).mockClear()
|
|
})
|
|
|
|
it('throws an error if called without arguments', async () => {
|
|
await expect(create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, [])).rejects.toThrow(PnpmError)
|
|
expect(dlx.handler).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it(
|
|
'appends `create-` to an unscoped package that doesn\'t start with `create-`',
|
|
async () => {
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['some-app'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['create-some-app'])
|
|
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['create_no_dash'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['create-create_no_dash'])
|
|
}
|
|
)
|
|
|
|
it(
|
|
'does not append `create-` to an unscoped package that starts with `create-`',
|
|
async () => {
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['create-some-app'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['create-some-app'])
|
|
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['create-'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['create-'])
|
|
}
|
|
)
|
|
|
|
it(
|
|
'appends `create-` to a scoped package that doesn\'t start with `create-`',
|
|
async () => {
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['@scope/some-app'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['@scope/create-some-app'])
|
|
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['@scope/create_no_dash'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['@scope/create-create_no_dash'])
|
|
}
|
|
)
|
|
|
|
it(
|
|
'does not append `create-` to a scoped package that starts with `create-`',
|
|
async () => {
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['@scope/create-some-app'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['@scope/create-some-app'])
|
|
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['@scope/create-'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['@scope/create-'])
|
|
}
|
|
)
|
|
|
|
it('infers a package name from a plain scope', async () => {
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['@scope'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['@scope/create'])
|
|
})
|
|
|
|
it('passes the remaining arguments to `dlx`', async () => {
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['some-app', 'directory/', '--silent'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['create-some-app', 'directory/', '--silent'])
|
|
})
|
|
|
|
it(
|
|
'appends `create` to package with preferred version`',
|
|
async () => {
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['foo@2.0.0'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['create-foo@2.0.0'])
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['foo@latest'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['create-foo@latest'])
|
|
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['@scope@2.0.0'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['@scope/create@2.0.0'])
|
|
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['@scope@next'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['@scope/create@next'])
|
|
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['@scope/foo@2.0.0'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['@scope/create-foo@2.0.0'])
|
|
|
|
await create.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['@scope/create-a@2.0.0'])
|
|
expect(dlx.handler).toHaveBeenCalledWith(expect.anything(), ['@scope/create-a@2.0.0'])
|
|
}
|
|
)
|