mirror of
https://github.com/pnpm/pnpm.git
synced 2026-03-27 03:21:55 -04:00
23eb4a6141
* refactor(env): unify node version specifier parsing into parseNodeSpecifier in node.resolver Move parseNodeSpecifier from @pnpm/plugin-commands-env to @pnpm/node.resolver and replace the simpler parseEnvSpecifier with an enhanced version that supports all Node.js version specifier formats: standalone release channels (nightly, rc, test, v8-canary, release), well-known aliases (lts, latest), LTS codenames (argon, iron), semver ranges (18, ^18), and channel/version combos (rc/18, nightly/latest). * fix(env): address parseNodeSpecifier review feedback - Remove overly strict release/X.Y.Z-only validation; release/latest, release/lts, and release/<range> are now accepted - Validate unknown release channels (e.g. foo/18) with a clear error instead of letting them fall through to a confusing network failure - Add test cases for release/latest, release/lts, and release/18
47 lines
1.8 KiB
TypeScript
47 lines
1.8 KiB
TypeScript
import { parseNodeSpecifier } from '../lib/parseNodeSpecifier.js'
|
|
|
|
test.each([
|
|
// Semver ranges → release channel
|
|
['6', '6', 'release'],
|
|
['16.0', '16.0', 'release'],
|
|
// Exact prerelease with rc channel
|
|
['16.0.0-rc.0', '16.0.0-rc.0', 'rc'],
|
|
// Channel/range combo (major only)
|
|
['rc/10', '10', 'rc'],
|
|
// Standalone channel name → latest from that channel
|
|
['nightly', 'latest', 'nightly'],
|
|
['rc', 'latest', 'rc'],
|
|
['test', 'latest', 'test'],
|
|
['v8-canary', 'latest', 'v8-canary'],
|
|
['release', 'latest', 'release'],
|
|
// Well-known aliases
|
|
['lts', 'lts', 'release'],
|
|
['latest', 'latest', 'release'],
|
|
// LTS codenames
|
|
['argon', 'argon', 'release'],
|
|
['iron', 'iron', 'release'],
|
|
// Exact stable version
|
|
['22.0.0', '22.0.0', 'release'],
|
|
// Stable release with explicit channel prefix, aliases, and semver ranges
|
|
['release/22.0.0', '22.0.0', 'release'],
|
|
['release/latest', 'latest', 'release'],
|
|
['release/lts', 'lts', 'release'],
|
|
['release/18', '18', 'release'],
|
|
// Channel/version combos
|
|
['rc/18', '18', 'rc'],
|
|
['rc/18.0.0-rc.4', '18.0.0-rc.4', 'rc'],
|
|
['nightly/latest', 'latest', 'nightly'],
|
|
// Exact nightly version
|
|
['24.0.0-nightly20250315d765e70802', '24.0.0-nightly20250315d765e70802', 'nightly'],
|
|
// Exact v8-canary version
|
|
['22.0.0-v8-canary20250101abc', '22.0.0-v8-canary20250101abc', 'v8-canary'],
|
|
])('Node.js version specifier is parsed: %s', (specifier, expectedVersionSpecifier, expectedReleaseChannel) => {
|
|
const result = parseNodeSpecifier(specifier)
|
|
expect(result.versionSpecifier).toBe(expectedVersionSpecifier)
|
|
expect(result.releaseChannel).toBe(expectedReleaseChannel)
|
|
})
|
|
|
|
test('throws for unknown release channel', () => {
|
|
expect(() => parseNodeSpecifier('foo/18')).toThrow('"foo" is not a valid Node.js release channel')
|
|
})
|