Commit Graph

5722 Commits

Author SHA1 Message Date
Jakub Filak
2497b6c77b podman: add support for specifying MAC
I basically copied and adapted the statements for setting IP.

Closes #1136

Signed-off-by: Jakub Filak <jakub.filak@sap.com>
2019-11-06 16:22:19 +01:00
Jakub Filak
455f5b7616 vendor: updated ocicni for MAC address
`go get github.com/cri-o/ocicni@deac903fd99b6c52d781c9f42b8db3af7dcfd00a`

I had to fix compilation errors in libpod/networking_linux.go

---

ocicni.Networks has changed from string to the structure NetAttachment
with the member Name (the former string value) and the member Ifname
(optional).

I don't think we can make use of Ifname here, so I just map the array of
structures to array of strings - e.g. dropping Ifname.

---

The function GetPodNetworkStatus no longer returns Result but it returns
the wrapper structure NetResult which contains the former Result plus
NetAttachment (Network name and Interface name).

Again, I don't think we can make use of that information here, so I
just added `.Result` to fix the build.

---

Issue: #1136

Signed-off-by: Jakub Filak <jakub.filak@sap.com>
2019-11-06 16:22:18 +01:00
Giuseppe Scrivano
16cb2b38a8 Makefile: add vendor-in-container
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-11-06 16:22:17 +01:00
OpenShift Merge Robot
6f7c290f70 Merge pull request #4439 from junaruga/feature/install-ubuntu
Update installation - Ubuntu. [skip ci]
2019-11-06 13:10:30 +01:00
OpenShift Merge Robot
cee2c1b048 Merge pull request #4457 from vrothberg/fix-4456
help message: don't parse the config for cgroup-manager default
2019-11-06 12:50:47 +01:00
Valentin Rothberg
eb9235fc63 help message: don't parse the config for cgroup-manager default
Do not generate an entire `config.Config` for displaying the default
value for the --cgroup-manager flag and just default to systemd. Not
using the `config.Config` is okay as 1) the value may change at runtime
in any case (rootless, DBUS access, etc.), 2) it avoids to redundantly
parse the system config files and to generate the hard-coded default
config, and 3) the log-level and other attributes are not yet set during
init() causing undesirable side effects.

Fixes: #4456
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2019-11-06 09:00:12 +01:00
OpenShift Merge Robot
b4b727256c Merge pull request #4370 from rhatdan/seccomp
Set SELinux labels based on the security context in the kube.yaml
2019-11-05 21:52:22 +01:00
OpenShift Merge Robot
7eda1b0840 Merge pull request #4374 from giuseppe/create-cgroupns-by-default-on-cgroupsv2
namespaces: by default create cgroupns on cgroups v2
2019-11-05 20:24:13 +01:00
Giuseppe Scrivano
b8514ca6f3 namespaces: by default create cgroupns on cgroups v2
change the default on cgroups v2 and create a new cgroup namespace.

When a cgroup namespace is used, processes inside the namespace are
only able to see cgroup paths relative to the cgroup namespace root
and not have full visibility on all the cgroups present on the
system.

The previous behaviour is maintained on a cgroups v1 host, where a
cgroup namespace is not created by default.

Closes: https://github.com/containers/libpod/issues/4363

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-11-05 17:29:01 +01:00
Jun Aruga
1f74f6cadd Update installation - Ubuntu. [skip ci]
Current podman deb package does not install /etc/containers/registries.conf .
The added line is for compatibility of use cases with docker.

Signed-off-by: Jun Aruga <jaruga@redhat.com>
2019-11-05 16:11:55 +01:00
OpenShift Merge Robot
a904e21cf0 Merge pull request #4449 from vrothberg/fix-4434
pulling unqualified reference: make sure it's a docker reference
2019-11-05 15:25:48 +01:00
OpenShift Merge Robot
08c5c546dc Merge pull request #4448 from containers/dependabot/go_modules/gopkg.in/yaml.v2-2.2.5
Bump gopkg.in/yaml.v2 from 2.2.4 to 2.2.5
2019-11-05 15:04:57 +01:00
Valentin Rothberg
274fe57d3e pulling unqualified reference: make sure it's a docker reference
When pulling an unqualified reference (e.g., `fedora`) make sure that
the reference is not using a non-docker transport to avoid iterating
over the search registries and trying to pull from them.

Fixes: #4434
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2019-11-05 12:16:43 +01:00
dependabot-preview[bot]
9ab16311b0 Bump gopkg.in/yaml.v2 from 2.2.4 to 2.2.5
Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.4 to 2.2.5.
- [Release notes](https://github.com/go-yaml/yaml/releases)
- [Commits](https://github.com/go-yaml/yaml/compare/v2.2.4...v2.2.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2019-11-05 11:36:42 +01:00
Daniel J Walsh
65ed819932 Set SELinux labels based on the security context in the kube.yaml
If the kube.yaml specifieds the SELinux type or Level, we need the container
to be launched with the correct label.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-11-05 04:09:01 -05:00
OpenShift Merge Robot
cc19b09b44 Merge pull request #4442 from mheon/release_notes_add
Add release notes for v1.6.3
2019-11-05 09:38:56 +01:00
OpenShift Merge Robot
1db4556d42 Merge pull request #4438 from giuseppe/fix-slirp4netns-timeout
slirp4netns: fix timeout
2019-11-05 08:55:01 +01:00
Matthew Heon
830808cba7 Bump development version to 1.6.4-dev
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-11-04 17:50:14 -05:00
Matthew Heon
23058842f2 Bump version in README to v1.6.3
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-11-04 16:07:00 -05:00
Matthew Heon
6dedc919d4 Add release notes for v1.6.3
Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-11-04 16:06:06 -05:00
OpenShift Merge Robot
17eadda68b Merge pull request #4415 from rhatdan/rootless
Update rootless shortcomings with cgroup V2 information
2019-11-04 17:26:35 +01:00
Giuseppe Scrivano
31a5827856 slirp4netns: fix timeout
the pidWaitTimeout is already a Duration so do not multiply it again
by time.Millisecond.

Closes: https://github.com/containers/libpod/issues/4344

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-11-04 17:06:52 +01:00
OpenShift Merge Robot
700d701498 Merge pull request #4430 from rst0git/logo-light-source
logo: correct light source reflection
2019-11-04 16:49:11 +01:00
Matthew Heon
8e5aad97dd Merge pull request #4389 from TomSweeneyRedHat/dev/tsweeney/contextdir
Validate contextdir on build
2019-11-04 10:08:17 -05:00
OpenShift Merge Robot
efc7f1557b Merge pull request #4423 from giuseppe/fix-cpu-stats
stats: report correctly CPU usage
2019-11-04 08:40:10 +01:00
OpenShift Merge Robot
ca4c24cce1 Merge pull request #4428 from Foxboron/morten/fix-docker-docs
[Makefile] Fix docker documentation install and generation
2019-11-03 11:24:50 +01:00
Radostin Stoyanov
a655633f2d logo: correct light source reflection
Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
2019-11-03 09:24:12 +00:00
Giuseppe Scrivano
a84ab35dc8 stats: fix calculation for the CPU time
Closes: https://github.com/containers/libpod/issues/4409

Signed-off-by: Giuseppe Scrivano <giuseppe@scrivano.org>
2019-11-02 20:11:19 +01:00
OpenShift Merge Robot
2bf4df4dbf Merge pull request #4424 from rhatdan/srp33
Update link to Commands documentation
2019-11-02 16:18:35 +01:00
OpenShift Merge Robot
10d67fcd3c Merge pull request #4425 from rst0git/fix-typo
runtime: Fix typo
2019-11-02 14:52:51 +01:00
Morten Linderud
079164c391 [docs] Ensure we include section 5 documentation
Section 5 documentation is missing from the documentation restructure.

Signed-off-by: Morten Linderud <morten@linderud.pw>
2019-11-02 13:48:47 +01:00
Morten Linderud
9558797fb7 [Makefile] Fix docker documentation install and generation
The final versions of the documentation has been shifted from `docs/` to
`docs/build/man`. Most of the Makefile has been changed accordingly, but
the docker documentation generation was not.

Introduced by #4354

Signed-off-by: Morten Linderud <morten@linderud.pw>
2019-11-02 13:05:34 +01:00
Radostin Stoyanov
95bc917b49 runtime: Fix typo
Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
2019-11-02 01:44:22 +00:00
OpenShift Merge Robot
82381072e1 Merge pull request #4402 from baude/onlydocs
[CI:DOCS] make docsonly prs
2019-11-01 21:44:48 +01:00
Stephen Piccolo
d7a8310380 Update link to Commands documentation
The previous link pointed to the Markdown file, but the links are broken on that page. This pull request points to the actual documentation.

Grabbed from @srp33 PR https://github.com/containers/libpod/pull/4407 to help the merge process.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-11-01 16:38:18 -04:00
Giuseppe Scrivano
2c9e907912 cgroups: read correctly the CPU stats
the two values were incorrectly switched.

Signed-off-by: Giuseppe Scrivano <giuseppe@scrivano.org>
2019-11-01 20:51:24 +01:00
baude
f4e272b2fa [CI:DOCS] make docs only prs
skips certain aspects of prs for testing.

Signed-off-by: baude <bbaude@redhat.com>
2019-11-01 12:42:11 -05:00
OpenShift Merge Robot
04e8bf3dba Merge pull request #4405 from umohnani8/fips
Vendor in latest containers/buildah
2019-11-01 16:22:58 +01:00
Daniel J Walsh
1d707f5fa1 Update rootless shortcomings with cgroup V2 information
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-11-01 10:28:56 -04:00
TomSweeneyRedHat
677a0e5d60 Validate contextdir on build
We never verified that the context directory passed into the build
command was a valid directory.  When we then slapped a default Containerfile
name onto it, things went south fast if the user had passed us a file and
not a directory.

Fixes: #4383

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2019-11-01 09:57:56 -04:00
Urvashi Mohnani
2a149ad90a Vendor in latest containers/buildah
Pull in changes to pkg/secrets/secrets.go that adds the
logic to disable fips mode if a pod/container has a
label set.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2019-11-01 09:41:09 -04:00
OpenShift Merge Robot
69165fa04d Merge pull request #4400 from haircommander/exec-hang
Switch to bufio Reader for exec streams
2019-11-01 14:34:40 +01:00
OpenShift Merge Robot
9a28a12c9b Merge pull request #4412 from containers/dependabot/go_modules/github.com/onsi/ginkgo-1.10.3
Bump github.com/onsi/ginkgo from 1.10.1 to 1.10.3
2019-11-01 14:23:50 +01:00
OpenShift Merge Robot
7c7f0000ce Merge pull request #4404 from jwhonce/wip/panic
Refactor test to prevent panic
2019-11-01 12:42:48 +01:00
dependabot-preview[bot]
e22777c3fc Bump github.com/onsi/ginkgo from 1.10.1 to 1.10.3
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.10.1 to 1.10.3.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v1.10.1...v1.10.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2019-11-01 11:48:26 +01:00
Jhon Honce
3bf594e262 Refactor test to prevent panic
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2019-10-31 14:15:55 -07:00
OpenShift Merge Robot
2dae2577cc Merge pull request #4399 from giuseppe/tail-0
logs: support --tail 0
2019-10-31 22:05:17 +01:00
OpenShift Merge Robot
0bfdeae6dd Merge pull request #4384 from cevich/turn_off_f29
Cirrus: Disable F29 testing
2019-10-31 20:01:06 +01:00
Giuseppe Scrivano
11750df510 logs: support --tail 0
change the default to -1, so that we can change the semantic of
"--tail 0" to not print any existing log line.

Closes: https://github.com/containers/libpod/issues/4396

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-10-31 19:55:36 +01:00
OpenShift Merge Robot
ffe36ea996 Merge pull request #4354 from baude/newdocsstruct
Restructure documentation dir
2019-10-31 19:39:44 +01:00