Handle empty image output before skipping the header row in tagOutputToMap. This prevents a slice bounds panic when imagesOutput is empty and adds coverage for the empty-output case.
Signed-off-by: Atishay Jain <sethatishayjain@gmail.com>
With the new community repo we use that as place to define our
Governance and the org wide rules. As such we should just link there to
avoid duplication and drift.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The Pod key of a .container unit accepts systemd specifiers, but handlePod
looked the referenced pod up in the units map using the raw value, so
"Pod=%N.pod" failed with "quadlet pod unit %N.pod does not exist" instead
of resolving to the pod named after the container's service.
Expand %N to the container's service name before the lookup, matching the
existing handling in GetContainerResourceName. Since %N is the service
name, setting ServiceName= lets the container and pod unit files use
different names.
Add e2e cases for both combinations: a pod named after the container
file, and a pod named after a ServiceName that differs from the file
name.
Fixes: #29108
Signed-off-by: Salih Muhammed <root@lr0.org>
Building without go modules fails as we use different import paths now.
But also there is no reason to to use GO111MODULE=off anymore so just
remove it to make the build work.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Replace path package functions (path.Base, path.Join, path.Dir) with
filepath equivalents in cmd/quadlet/main.go.
Using filepath ensures consistency across operating systems when manipulating
host filesystem paths.
Related to: #25165
Signed-off-by: SHIVAANSH0610_LUFFY <shivaansh0610@gmail.com>
ignore warn and strict modes for unknown yaml fields and kinds
ignore is the default and skips them warn reports them strict fails
warnings are returned in the play report so they show up in the cli and over the api for tools like podman desktop
Closes#18332
Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>
The Packit failure-notification message tagged @containers/packit-build,
a team under the old containers org that no longer resolves after the
repo moved to podman-container-tools. @Luap99 created
@podman-container-tools/packit-jobs; point the mention there so
maintainers are pinged on Packit job failures again.
The message is defined once on the &packit_generic_failure_notification
YAML anchor (.packit.yaml line 56) and reused by reference on lines 71,
85, and 106, so the single edit covers every job that uses it.
Fixes#28882
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
The InstalledProviders and SupportedProviders functions were only
used in their own tests and were otherwise dead code. Removing them
entirely cleans up the API surface.
Signed-off-by: Aryanbhargava18 <aryanbhargava644@gmail.com>
Docker now reserves alias specfically for user-defined aliases, and uses another field, dnsnames, to hold all aliases, including container ID and name.
Part of docker v1.45 compat work, but this touches the cli too, since they updated it there too.
Signed-off-by: Ashley Cui <acui@redhat.com>
Paul Holzinger