Commit Graph

13677 Commits

Author SHA1 Message Date
Lokesh Mandvekar
99e9fcdb6a autocopr: distro conditionals for containers-common
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2021-12-07 11:37:52 -05:00
OpenShift Merge Robot
23ce826a84 Merge pull request #12498 from rhatdan/cgroups
Update vendor or containers/common moving pkg/cgroups there
2021-12-07 12:49:57 +00:00
OpenShift Merge Robot
43077291ac Merge pull request #12528 from flouthoc/dont_modify_mount_permissions
volume: apply exact permission of target directory without adding extra `0111`
2021-12-07 11:39:58 +00:00
Daniel J Walsh
2130d18539 Update vendor or containers/common moving pkg/cgroups there
[NO NEW TESTS NEEDED] This is just moving pkg/cgroups out so
existing tests should be fine.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-12-07 06:17:11 -05:00
OpenShift Merge Robot
2f11e2ac53 Merge pull request #12526 from cevich/remove_static
[CI:DOCS] Cirrus: Remove remnants of nix-based static build
2021-12-07 11:03:58 +00:00
Aditya Rajan
7d0fd175f1 volume: apply exact permission of target directory without adding extra 0111
While trying to match permissions of target directory podman adds
extra `0111` which should not be needed if target path does not have
execute permission.

Signed-off-by: Aditya Rajan <arajan@redhat.com>
2021-12-07 15:42:12 +05:30
OpenShift Merge Robot
7d290b3f62 Merge pull request #12490 from jwhonce/issues/10974-3
Refactor podman pods to report.Formatter
2021-12-06 21:19:24 +00:00
Chris Evich
851349345b Cirrus: Remove remnants of nix-based static build
Simply a readme update and dead-code cleanup.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-12-06 16:00:17 -05:00
OpenShift Merge Robot
9af07fd3ed Merge pull request #12522 from edsantiago/minor_test_cleanup
tests: clean up FIXMEs and noise
2021-12-06 17:55:24 +00:00
Jhon Honce
d35aa3f293 Refactor podman pods to report.Formatter
[NO NEW TESTS NEEDED]

Support better compatibility output for podman pods commands

See #10974
Depends on containers/common#831

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2021-12-06 10:51:29 -07:00
OpenShift Merge Robot
22b9763733 Merge pull request #12516 from containers/dependabot/go_modules/github.com/opencontainers/runc-1.0.3
Bump github.com/opencontainers/runc from 1.0.2 to 1.0.3
2021-12-06 17:19:23 +00:00
OpenShift Merge Robot
6663d7289e Merge pull request #12519 from vrothberg/fix-9597
fix remote run/start flake
2021-12-06 17:15:23 +00:00
OpenShift Merge Robot
6d1b2dced4 Merge pull request #12518 from vrothberg/fix-12167
e2e: fix pprof flakes
2021-12-06 15:43:24 +00:00
Ed Santiago
eee3a42b7e tests: clean up FIXMEs and noise
e2e tests:
 * remove two FIXMEs:
   * one of them is expected behavior, not a FIXME
   * the other is easily fixed

 * File issue #12521 for a real podman-remote bug, and
   update the Skip() message

system tests:
 * in command-completion test, clean up stray podman-pause image
   (followup to #12322, in which I missed this instance). This
   removes distracting warnings from test logs.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-12-06 08:30:59 -07:00
Valentin Rothberg
207065ce9f fix remote run/start flake
Fix the flake reported in #9597 with a workaround to at least stop
wasting energy until the root cause has been found and fixed.

It seems that a remote run returns before the container has transitioned
into the `exited` state which ultimately breaks a subsequent remote
start with attach.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-12-06 15:30:31 +01:00
Valentin Rothberg
6d7e6d7447 e2e: fix pprof flakes
Give the services some more time after SIGINT to shutdown.
`Eventually(session, 5)` will poll the session for the specific
condition at a frequency of 10ms for at most 5 seconds.

Fixes: #12167
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-12-06 14:28:34 +01:00
OpenShift Merge Robot
188f1989fa Merge pull request #12487 from jwhonce/issues/10974-2
Refactor podman system to report.Formatter
2021-12-06 13:09:23 +00:00
dependabot[bot]
c91fb244c4 Bump github.com/opencontainers/runc from 1.0.2 to 1.0.3
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/opencontainers/runc/releases)
- [Commits](https://github.com/opencontainers/runc/compare/v1.0.2...v1.0.3)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/runc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-12-06 12:28:06 +00:00
OpenShift Merge Robot
18e31935ab Merge pull request #12514 from vrothberg/vendor-common
vendor c/common@main
2021-12-06 10:41:22 +00:00
OpenShift Merge Robot
da3d63615e Merge pull request #12511 from n1hility/fix-win-path
Fixes #11416 - Trailing quote on PATH added by Windows MSI
2021-12-06 09:13:24 +00:00
Valentin Rothberg
76f5100be5 vendor c/common@main
Update the `--filter reference=...` tests to reflect recent changes in
c/common.  The reference values now match as specified without
implicitly adding wildcards arounds.

Fixes: #11905
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-12-06 09:33:39 +01:00
Jason T. Greene
527fd3c0fa Escape trailing slash in install directory location so the closing quote is not escaped
Fixes #11416 [NO NEW TESTS NEEDED]

Signed-off-by: Jason Greene <jason.greene@redhat.com>
2021-12-05 17:59:50 -06:00
OpenShift Merge Robot
e79c47bc0c Merge pull request #12500 from lsm5/auto-copr3
centos 9 stream cannot use %autochangelog
2021-12-04 02:20:43 +00:00
Lokesh Mandvekar
e89a626025 centos 9 stream cannot use %autochangelog
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2021-12-03 15:58:24 -05:00
Jhon Honce
7d22cc88ef Refactor podman system to report.Formatter
[NO NEW TESTS NEEDED]

Support better compatibility output for podman system commands

* Format and content of output from podman version changed to
  be more compatible

See #10974
Depends on containers/common#831

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2021-12-03 13:48:58 -07:00
OpenShift Merge Robot
a03b8b44f7 Merge pull request #12491 from lsm5/auto-copr
add spec file for automated copr builds
2021-12-03 19:26:46 +00:00
OpenShift Merge Robot
a93fa5e0c9 Merge pull request #12466 from dispensable/respect_pod_yaml_spec_hostname_when_play
Hostname in `spec.hostname` should be passed to infra ctr init opt
2021-12-03 19:20:45 +01:00
Lokesh Mandvekar
8e05326231 add spec file for automated copr builds
This commit along with an upstream  webhook
will automatically build an rpm at
`rhcontainerbot/podman-next` .

RPM NVR will be of the form:
podman-4-$DATESTAMP.$TIMESTAMP

The date and time stamps will reflect the date and
time at which they were built in the COPR env
which shouldn't lag the PR merge date by a lot.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2021-12-03 12:45:12 -05:00
OpenShift Merge Robot
a50502dd3d Merge pull request #12489 from mtrmac/save-me-from-repetition
Improve documentation of (podman image save)
2021-12-03 14:56:46 +01:00
OpenShift Merge Robot
dd109daa45 Merge pull request #12440 from umohnani8/cm
Add support for configmap volumes to play kube
2021-12-03 14:54:47 +01:00
OpenShift Merge Robot
999fe0d893 Merge pull request #12360 from rhatdan/VENDOR
Bump storage
2021-12-03 14:52:50 +01:00
OpenShift Merge Robot
f0f148c494 Merge pull request #12484 from machacekondra/restartSec
Add restart-sec option to systemd generate command
2021-12-03 14:50:47 +01:00
OpenShift Merge Robot
0c6f1c4fb1 Merge pull request #12486 from giuseppe/use-configured-compression-format
cmd, push: use the configured compression format
2021-12-03 14:16:52 +01:00
Ondra Machacek
c9ad1da51c Add restart-sec option to systemd generate
Signed-off-by: Ondra Machacek <omachace@redhat.com>
2021-12-03 12:11:28 +01:00
OpenShift Merge Robot
a6d1220ac0 Merge pull request #12488 from edsantiago/logformatter_fixes
[CI:DOCS] logformatter: fix corner case with links
2021-12-03 09:36:46 +01:00
Miloslav Trmač
2e132d1d43 Fix documentation of (podman image save --compress --uncompressed)
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2021-12-02 22:29:16 +01:00
Miloslav Trmač
952046ffdd Improve documentation of (podman image save --format)
- Don't pointlessly repeat the names
- Improve documentation of the formats
- Use a table, per MANPAGE_SYNTAX.md

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2021-12-02 22:28:30 +01:00
OpenShift Merge Robot
f3a02304c2 Merge pull request #12483 from vrothberg/fix-12468
compat API: push: report size of manifest
2021-12-02 22:08:50 +01:00
Urvashi Mohnani
7d331d35dd Add support for configmap volumes to play kube
If the k8s yaml has volumes from a configmap, play kube
will now create a volume based on the data from the
configmap and volume source and set it to the right path
in the container accordingly.
Add tests for this and update some test for ENV from configmap.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2021-12-02 14:48:04 -05:00
Giuseppe Scrivano
bd9f8815e1 cmd, push: use the configured compression format
[NO NEW TESTS NEEDED] I am just changing the default value

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-12-02 20:29:12 +01:00
Ed Santiago
aafbaa4975 [CI:DOCS] logformatter: fix corner case with links
A test name beginning with non-alpha, e.g., "--build should ...",
was not being recognized and linkified:

   https://storage.googleapis.com/cirrus-ci-6707778565701632-fcae48/artifacts/containers/podman/6500723916537856/html/int-podman-fedora-34-rootless-host.log.html

Fix that. Also fix two other cases (single/double quotes) that were
resulting in weird unreliable links.

While I'm at it, add a few usability enhancements:

  * Colorize [SKIPPING] and [SLOW TEST]
  * Deemphasize '[It] testname' when it appears mid-test
  * Replace 'Running:' with a (deemphasized) '#' or '$' prompt

Add regression tests

Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-12-02 12:28:13 -07:00
OpenShift Merge Robot
87de344eeb Merge pull request #12482 from edsantiago/e2e_have
e2e tests: use HaveKey() and HaveLen() when possible
2021-12-02 20:06:47 +01:00
Daniel J Walsh
ecd48325f6 UPdate vendor of image-spec and containers/storage
This should get rid of the nasty warning on the github site.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-12-02 14:04:24 -05:00
OpenShift Merge Robot
8bce756df9 Merge pull request #12445 from wilbeibi/main
[CI:DOCS] Update doc to explictly mention using ed25519 in ssh keys
2021-12-02 20:02:48 +01:00
OpenShift Merge Robot
b203e6d0f0 Merge pull request #12365 from mtrmac/random
Don't use a global RNG, and avoid conflicts, when generating NodePorts
2021-12-02 20:00:48 +01:00
OpenShift Merge Robot
4ff0ba4c87 Merge pull request #12455 from jwhonce/issues/10974
Refactor podman image command output
2021-12-02 19:28:48 +01:00
Giuseppe Scrivano
fe1cdab59f vendor: update containers/common
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-12-02 18:32:13 +01:00
Hongyi Shen
babc693670 Update doc to explictly mention using ed25519 in ssh keys
Signed-off-by: Hongyi Shen <wilbeibi@gmail.com>
2021-12-02 09:20:13 -08:00
Jhon Honce
61792de36e Refactor podman image command output
Leverage new report.Formatter allowing better compatibility from
podman command output.

Follow on PR's will cover containers, etc.

See #10974

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2021-12-02 09:07:27 -07:00
OpenShift Merge Robot
ee39281c35 Merge pull request #12480 from vrothberg/fix-12453
compat: images/json
2021-12-02 16:12:47 +01:00