Commit Graph

18875 Commits

Author SHA1 Message Date
OpenShift Merge Robot
c4e648faf4 Merge pull request #18529 from containers/renovate/github.com-containernetworking-plugins-1.x
fix(deps): update module github.com/containernetworking/plugins to v1.3.0
2023-05-10 04:26:10 -04:00
OpenShift Merge Robot
f8da6f0599 Merge pull request #18527 from edsantiago/wait_for_systemd_activate
e2e: stop podman.service test: wait for server
2023-05-10 04:09:20 -04:00
OpenShift Merge Robot
f05d32b38f Merge pull request #18526 from edsantiago/logformatter_handle_machine
logformatter: handle podman-machine test logs
2023-05-10 04:01:31 -04:00
OpenShift Merge Robot
b62ebde436 Merge pull request #18524 from cevich/disable_dependabot
[CI:DOCS] Disable Dependabot in favor of Renovate
2023-05-10 03:14:47 -04:00
OpenShift Merge Robot
ca2a0dec82 Merge pull request #18525 from containers/renovate/golang.org-x-tools-0.x
fix(deps): update module golang.org/x/tools to v0.9.1
2023-05-10 03:12:09 -04:00
renovate[bot]
6b329d8c9e fix(deps): update module github.com/containernetworking/plugins to v1.3.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-05-10 01:09:01 +00:00
Ed Santiago
ff37615bfd e2e: stop podman.service test: wait for server
Another low-hanging fruit: test flake because podman-remote
trying to contact a server that hadn't come up.

Fixes: #17940

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-05-09 14:34:47 -06:00
Ed Santiago
cb8e19677f logformatter: handle podman-machine test logs
With -p, ginkgo emits timing information on the first line
after dashes. Without -p, it's at the end.

Most tests use -p. Podman-machine does not. Deal with that.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-05-09 11:08:59 -06:00
renovate[bot]
58fd879596 fix(deps): update module golang.org/x/tools to v0.9.1
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-05-09 16:56:11 +00:00
Chris Evich
2d8929d95d [CI:DOCS] Disable Dependabot in favor of Renovate
Fixes: #18139

Removing the Dependabot configuration file is a required prerequisite to
stopping it from opening update PRs.  Once this commit is merged, the
`Dependabot security updates` repo. setting may also be disabled.  Note:
The `Dependabot alerts` setting should remain enabled, this provides
security-data to renovate for opening important vulnerability fix PRs.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-05-09 12:45:52 -04:00
OpenShift Merge Robot
287a4193e7 Merge pull request #18520 from ygalblum/quadlet-test-notify
Quadlet system tests - fix socket notification
2023-05-09 12:09:14 -04:00
OpenShift Merge Robot
6613e50c10 Merge pull request #18519 from vrothberg/fix-18356
sqlite: disable WAL mode
2023-05-09 11:48:33 -04:00
OpenShift Merge Robot
dc01ce8768 Merge pull request #18515 from vrothberg/fix-18486
quadlet: support `HostName`
2023-05-09 11:21:28 -04:00
Ygal Blum
8aaa13accb Quadlet system tests - fix socket notification
In some tests use Notify=yes while in others remove the notification

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2023-05-09 17:27:47 +03:00
Valentin Rothberg
1fb3cdf8a8 sqlite: disable WAL mode
As shown in #17831, WAL mode plays a role in causing `database is locked`
errors.  Those are errors, in theory, should not happen as the DB should
busy wait.  mattn/go-sqlite3/issues/274 has some comments indicating
that the busy handler behaves differently in WAL mode which may be an
explanation to the error.

For now, let's disable WAL mode and only re-enable it when we have
clearer understanding of what's going on.  The upstream issue along with
the SQLite documentation do not give me the clear guidance that I would
need.

[NO NEW TESTS NEEDED] - flake is only reproducible in CI.

Fixes: #18356
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-05-09 15:54:26 +02:00
OpenShift Merge Robot
d49a537b8f Merge pull request #18513 from edsantiago/wait_wait
e2e: fix race in a play-kube test
2023-05-09 09:08:53 -04:00
OpenShift Merge Robot
1a78a4e16f Merge pull request #18489 from bachradsusi/quadlets-precedence
Fix preference of user quadlets directories
2023-05-09 08:29:42 -04:00
Valentin Rothberg
b97be3406b quadlet: support HostName
Add a new `HostName` field to Quadlet `.container` files.

Fixes: #18486
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-05-09 13:35:54 +02:00
Ed Santiago
9dc107e749 e2e: fix race in a play-kube test
Yet another case where tests expect play-kube to be synchronous.
There are probably dozens more of these.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-05-09 05:19:05 -06:00
Petr Lautrbach
bdb3ed7950 Fix preference of user quadlets directories
If there's a container defined in multiple directories use the following
precedence:

$XDG_CONFIG_HOME/containers/systemd/ or ~/.config/containers/systemd/
takes precedence over /etc/containers/systemd/users/$(UID) and this
takes precedence over /etc/containers/systemd/users/

Signed-off-by: Petr Lautrbach <lautrbach@redhat.com>
2023-05-09 12:06:38 +02:00
OpenShift Merge Robot
edcb29b19f Merge pull request #18511 from containers/renovate/golang.org-x-tools-0.x
fix(deps): update module golang.org/x/tools to v0.9.0
2023-05-09 05:03:56 -04:00
OpenShift Merge Robot
8aed206c3d Merge pull request #18508 from containers/renovate/golang.org-x-net-0.x
fix(deps): update module golang.org/x/net to v0.10.0
2023-05-09 05:01:01 -04:00
OpenShift Merge Robot
42ac84da9e Merge pull request #18498 from rhatdan/build
Check on client side for Containerfile, if none specified
2023-05-09 04:31:54 -04:00
renovate[bot]
40b21fa7d5 fix(deps): update module golang.org/x/tools to v0.9.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-05-09 06:13:19 +00:00
renovate[bot]
661a238a97 fix(deps): update module golang.org/x/net to v0.10.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-05-08 19:13:17 +00:00
Daniel J Walsh
332b47fefb Check on client side for Containerfile, if none specified
Fixes: https://github.com/containers/podman/issues/16354

Currently we check on the server side, which ends up generating a bad
error message.

$ podman --remote build foo/
ERRO[0000] While reading directory /home/dwalsh/go/src/github.com/containers/podman/foo: EOF
Error: stat /var/tmp/libpod_builder1249622306/build/Dockerfile: no such file or directory

With this change you will get

./bin/podman --remote build foo/
Error: Containerfile not specified and no Containerfile or Dockerfile found in context directory, /home/dwalsh/podman/foo

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-05-08 13:58:37 -04:00
OpenShift Merge Robot
a330974c73 Merge pull request #18500 from edsantiago/treadmill_rootless_tweaks
Buildah treadmill: several fixes
2023-05-08 12:48:48 -04:00
OpenShift Merge Robot
cbbfa35844 Merge pull request #18503 from containers/dependabot/go_modules/github.com/docker/docker-23.0.6incompatible
build(deps): bump github.com/docker/docker from 23.0.5+incompatible to 23.0.6+incompatible
2023-05-08 11:52:48 -04:00
dependabot[bot]
18cd174c92 build(deps): bump github.com/docker/docker
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 23.0.5+incompatible to 23.0.6+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](https://github.com/docker/docker/compare/v23.0.5...v23.0.6)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-05-08 12:59:13 +00:00
Ed Santiago
9ec630f305 Buildah treadmill: several fixes
- treadmill script: run root & rootless in parallel, not
  sequentially. It's only four jobs, and it seems dumb
  to fix root tests, repush, then discover a rootless failure.

- apply-podman-deltas: implement skip_if_rootless(), and
  use it to skip a nasty longstanding flake

- bud-tests-in-podman diffs: ugly code to fix a rootless hang.
   background: rootless remote tests hang
   cause: stray podman server process
   root cause: no idea. No clue at all. I just gave up
   workaround: seek out and kill stray server processes

  Rootless buildah-bud tests are not run in regular CI,
  only in the buildah treadmill.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-05-08 05:28:11 -06:00
OpenShift Merge Robot
fb03443274 Merge pull request #18496 from containers/renovate/common-image-and-storage-deps
fix(deps): update github.com/containers/common digest to 3e93a76
2023-05-08 06:44:43 -04:00
renovate[bot]
11d92ea376 fix(deps): update github.com/containers/common digest to 3e93a76
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-05-06 11:14:08 +00:00
OpenShift Merge Robot
ace3cba5c1 Merge pull request #18491 from containers/renovate/docker-6.x
chore(deps): update dependency docker to ~=6.1.0
2023-05-06 07:10:58 -04:00
renovate[bot]
1bf057e8cf chore(deps): update dependency docker to ~=6.1.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-05-05 19:24:45 +00:00
OpenShift Merge Robot
ca3d4503e3 Merge pull request #18446 from rhatdan/quadlet
Allow user quadlets to be stored under /etc
2023-05-05 11:28:46 -04:00
OpenShift Merge Robot
c74f9ad66d Merge pull request #18476 from containers/renovate/common-image-and-storage-deps
fix(deps): update github.com/containers/common digest to bc15b04
2023-05-05 06:26:26 -04:00
Daniel J Walsh
27891a6640 Update docs/source/markdown/podman-systemd.unit.5.md
Co-authored-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-05-05 05:48:33 -04:00
renovate[bot]
505e02e046 fix(deps): update github.com/containers/common digest to bc15b04
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-05-05 08:15:08 +00:00
OpenShift Merge Robot
f4d2d173f9 Merge pull request #18470 from containers/renovate/golang.org-x-sync-0.x
fix(deps): update module golang.org/x/sync to v0.2.0
2023-05-04 21:53:52 -04:00
renovate[bot]
c27cda7c99 fix(deps): update module golang.org/x/sync to v0.2.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-05-04 17:54:13 +00:00
OpenShift Merge Robot
d9164c95d7 Merge pull request #18467 from containers/renovate/requests-2.x
chore(deps): update dependency requests to ~=2.30.0
2023-05-04 13:52:19 -04:00
renovate[bot]
773b457048 chore(deps): update dependency requests to ~=2.30.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-05-04 16:51:16 +00:00
OpenShift Merge Robot
54952270ce Merge pull request #18453 from containers/renovate/common-image-and-storage-deps
fix(deps): update github.com/containers/common digest to ea87b34
2023-05-04 12:50:07 -04:00
OpenShift Merge Robot
071bc5c93e Merge pull request #18464 from edsantiago/ginkgo_logs_optional
ginkgo json output: only in CI, not on laptop runs
2023-05-04 12:44:56 -04:00
Ed Santiago
0c070ebfbd ginkgo json output: only in CI, not on laptop runs
Followup to #18422: disable --json-report except under CI, which
is where it's useful.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-05-04 08:18:30 -06:00
OpenShift Merge Robot
d1a696acb7 Merge pull request #18385 from dcermak/setup-env-in-init-containers
Run generate.CompleteSpec() for initContainers as well
2023-05-04 10:12:40 -04:00
Daniel J Walsh
73d3487cce Allow user quadlets to be stored under /etc
I would like to allow admin to control quadlet containers
in users homedirs.

If an admin sets a quadlet in
/etc/containers/systemd/users, then all users will run these
quadlet services when they login.

If an admin places a quadlet in /etc/containers/systemd/users/$(USERNAME)
then only the USERNAME will execute this quadlet service when
they login.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-05-04 10:06:41 -04:00
OpenShift Merge Robot
8bfb27a3ce Merge pull request #18462 from Luap99/no-cleanup-twice
libpod: do not Cleanup() more than once
2023-05-04 09:55:06 -04:00
OpenShift Merge Robot
4f8a84a310 Merge pull request #18219 from stellarpower/patch-1
[CI:DOCS] Add mention of redir to doc `rootless.md`
2023-05-04 09:36:35 -04:00
OpenShift Merge Robot
41f5fcfd29 Merge pull request #18458 from Luap99/docker-dup-volume
compat container create: match duplicate mounts correctly
2023-05-04 09:34:01 -04:00