mirror/python
1
0
Fork 0
mirror of https://github.com/meshtastic/python.git synced 2025-12-24 00:17:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

flush() is only called if the stream is open

Browse Source 
This ensures flush() is only called if the stream is open, and logs (but ignores) any exceptions during flush. This should prevent the "Bad file descriptor" error.

I see this error a lot on a rak unit, I dont know this is the way but .. you be the judge.
This commit is contained in:
SpudGunMan
2025-10-14 07:42:27 -07:00
parent 7554c03a26
commit 93da1da386
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
meshtastic/serial_interface.py
View File

@@ -85,10 +85,14 @@ class SerialInterface(StreamInterface):
def close(self) -> None:
"""Close a connection to the device"""
if self.stream: # Stream can be null if we were already closed
self.stream.flush() # FIXME: why are there these two flushes with 100ms sleeps? This shouldn't be necessary
time.sleep(0.1)
self.stream.flush()
time.sleep(0.1)
if hasattr(self, "stream") and self.stream and getattr(self.stream, "is_open", False):
try:
self.stream.flush()
time.sleep(0.1)
# FIXME: why are there these two flushes with 100ms sleeps? This shouldn't be necessary
self.stream.flush()
time.sleep(0.1)
except Exception as e:
logger.debug(f"Exception during flush: {e}")
logger.debug("Closing Serial stream")
StreamInterface.close(self)