data_models: disable doi validator

rendercv/data_models.py

@@ -19,12 +19,8 @@ import importlib
 import importlib.util
 import importlib.machinery
 import functools
-from urllib.request import urlopen, HTTPError
-from urllib.error import URLError
-from http.client import InvalidURL
 import json
 import re
-import ssl
 import pathlib
 import warnings
 import annotated_types as at
@@ -270,8 +266,8 @@ class PublicationEntryBase(RenderCVBaseModel):
     )
 
     @pydantic.model_validator(mode="after")
-    def check_doi_and_url(self) -> "PublicationEntryBase":
-        """Check if both DOI and URL are provided. If so, ignore the URL."""
+    def ignore_url_if_doi_is_given(self) -> "PublicationEntryBase":
+        """Check if DOI is provided and ignore the URL if it is provided."""
         doi_is_provided = self.doi is not None
         url_is_provided = self.url is not None
         if doi_is_provided and url_is_provided:
@@ -279,35 +275,6 @@ class PublicationEntryBase(RenderCVBaseModel):
 
         return self
 
-    @pydantic.field_validator("doi")
-    @classmethod
-    def check_doi(cls, doi: Optional[str]) -> Optional[str]:
-        """Check if the DOI is valid and exists in the DOI System."""
-        if doi is not None:
-            # See https://stackoverflow.com/a/60671292/18840665 for the explanation of
-            # the next line:
-            ssl._create_default_https_context = ssl._create_unverified_context  # type: ignore
-
-            doi_url = f"http://doi.org/{doi}"
-
-            # Validate the URL:
-            url_validator.validate_strings(doi_url)
-
-            try:
-                urlopen(doi_url)
-            except HTTPError as err:
-                if err.code == 404:
-                    raise ValueError("DOI cannot be found in the DOI System!")
-            except InvalidURL:
-                # Unfortunately, url_validator does not catch all the invalid URLs.
-                raise ValueError("This DOI is invalid!")
-            except URLError:
-                # In this case, there is no internet connection, so don't raise an
-                # error.
-                pass
-
-        return doi
-
     @functools.cached_property
     def doi_url(self) -> str:
         """Return the URL of the DOI."""
@@ -919,9 +886,11 @@ class SocialNetwork(RenderCVBaseModel):
     @pydantic.model_validator(mode="after")  # type: ignore
     def check_url(self) -> "SocialNetwork":
         """Validate the URLs of the social networks."""
-        url = self.url
-
-        url_validator.validate_strings(url)
+        if self.network == "Mastodon":
+            # All the other social networks have valid URLs. Mastodon URLs contain both
+            # the username and the domain. So, we need to validate if the url is valid.
+            url = self.url
+            url_validator.validate_strings(url)
 
         return self
 

tests/test_data_models.py

@@ -400,16 +400,6 @@ def test_doi_url(publication_entry, doi, expected_doi_url):
     assert publication_entry.doi_url == expected_doi_url
 
 
-@pytest.mark.parametrize(
-    "doi",
-    ["aaa10.1109/TASC.2023.3340648", "aaa", "A string"],
-)
-def test_invalid_doi(publication_entry, doi):
-    with pytest.raises(pydantic.ValidationError):
-        publication_entry["doi"] = doi
-        dm.PublicationEntry(**publication_entry)
-
-
 @pytest.mark.parametrize(
     "network, username",
     [