the tests that tested it. As far as I can tell, it was always broken
since the day I put it in years ago. In my investigation into this I
was unable to figure out what in the world I was thinking back then,
to introduce a global variable with the wrong information in it rather
than using a parameter that was already available in readlink_stat
function. That still bothers me a bit but I decided to stop worrying
about it.
changed the test to the common form of prefixing an x to both sides of
an equivalence because it didn't even notice a problem on the cray when
it was instead using test -n.
Also noticed an error in the test for ANSI c, doing a "$xac..." = xno"
when it should have been "x$ac..." = xno, so I fixed that too.
available, as apparently is the case on Cray UNICOS. The AC_FUNC_ALLOCA
autoconf documentation talks about having an included alloca.c and
periodically calling alloca(0) to garbage collect when C_ALLOCA is defined,
but I don't know where to get the code or if there's anybody that cares
enough about the UNICOS port for it to be worth the trouble.
struct in_addr, which means passing &sin.sin_addr instead of
&sin.sin_addr.s_addr. Also changed the AF_INET6 version to pass
&sin6.sin6_addr. Hopefully this will fix UNICOS and not break
anyone else.
Based on patch submited by David R. Staples. Todd Vander Does contributed
the following test which showed the problem:
> mkdir /tmp/nowrite
> chmod -w /tmp/nowrite
> rsync /etc/group /tmp/nowrite || echo $status
mkstemp .group.cUaaeY failed
rsync error: partial transfer (code 23) at main.c(518)
23
> rsync -e ssh loki:/etc/group /tmp/nowrite || echo $status
mkstemp .group.1rayeY failed
> rsync -e ssh loki:/etc/group /tmp/nowrite && echo $status
mkstemp .group.fbaGiY failed
0
The remote copy should have returned non-zero exit code like the local copy.
canonical form ``$RSYNC'' (set in testsuite/rsync.fns). This prevents any
stray rsync binaries in the user's PATH from being picked up by the test
scripts and ensures that the newly built rsync binary is used always.
to see if it excluded before reporting an error. Previously it was only
checking for the exclusion if copy_links was enabled, but the error can
also occur if a file disappears during an rsync run. Suggested by Eugene
V. Chupriyanov and Bo Kersey.
new rsync being in $PATH; it may pick up an old version, invalidating the
result of the tests. This is what the other tests do already.
Submitted by: Joel Shprentz <ShprentzJ@nima.mil>
default the config file to just "rsyncd.conf" in the current directory
instead of /etc/rsyncd.conf. Also, fix problems with logging messages when
running daemon mode over a remote shell program: it was pretty much doing
the opposite of what it should have, sending early error messages to the
log and later messages to the client. Switched it around so the very early
error messages go to the client and the later ones go to the log.
David Dykstra