Wayne Davison
a4b4e0770b
Improved a comment.
2006-10-15 15:57:27 +00:00
Wayne Davison
2a6e35db31
Improved a couple existing items.
2006-10-15 15:49:31 +00:00
Wayne Davison
e3794138d8
Use the new case_N.h file to make sure that our cleanup_step case
...
statements never get out of sequence when the code changes.
2006-10-15 15:43:26 +00:00
Wayne Davison
fdd10da6f7
A helper file for cleanup.c.
2006-10-15 15:42:01 +00:00
Wayne Davison
5f12a07bff
Now that samba.org has a modern rsync, we can go back to using
...
hard-links on the moved files and use rsync to effect the hard-
links on the remote system (which will make a future transfer
more efficient in the absense of --detect-renamed).
2006-10-15 05:04:59 +00:00
Wayne Davison
6a4a1d0cb0
Preparing for release of 2.6.9pre2
2006-10-14 20:35:17 +00:00
Wayne Davison
434c40986d
Use the MAX_RENAMES_DIGITS define in the relevant snprintf().
2006-10-14 20:31:33 +00:00
Wayne Davison
8ee6857702
Improved the description of the code-checker work..
2006-10-14 20:30:43 +00:00
Wayne Davison
721ddc903f
Updated the news about the exit_cleanup() improvement.
2006-10-14 20:01:22 +00:00
Wayne Davison
154c345db0
Improved the _exit_cleanup() function to handle potential recursions
...
back to the function via the calls that it is making. The new code
treats each recursion back into the function as an opportunity to
take up where we left off (skipping whatever step just failed).
2006-10-14 19:58:52 +00:00
Wayne Davison
25f637a334
Got rid of EXIT_OR_RETURN() macro again -- switching to a better
...
recursion-prevention heuristic in _exit_cleanup().
2006-10-14 18:51:21 +00:00
Wayne Davison
2356d73bb4
The cleanup code that handles moving the temp file to the partial
...
file needed to check that cleanup_fname was not NULL to prevent
any possibility of a recursion starting into that code again.
2006-10-14 02:29:29 +00:00
Wayne Davison
4968423e71
Mention the latest fixes and internal changes.
2006-10-14 02:02:47 +00:00
Wayne Davison
99eba67585
Got rid of the recent paranoid length check because it didn't help
...
to silence a code-checker warning.
2006-10-14 01:17:36 +00:00
Wayne Davison
5abe03d6e8
Restore build order back to normal.
2006-10-14 01:15:16 +00:00
Wayne Davison
83078af5b0
Changed sprintf() calls to snprintf().
2006-10-13 23:46:32 +00:00
Wayne Davison
185aa5b0e5
Turned an sprintf() call into snprintf().
2006-10-13 23:42:52 +00:00
Wayne Davison
cabd60fdce
- Changed some sprintf() calls to snprintf() calls.
...
- Changed two last strcpy() calls to strlcpy() calls.
2006-10-13 23:38:14 +00:00
Wayne Davison
10944395bf
Changed sprintf() calls to snprintf() calls.
2006-10-13 23:35:53 +00:00
Wayne Davison
204f4f4d09
Changed strcpy() calls into memcpy() calls.
2006-10-13 23:17:37 +00:00
Wayne Davison
c9bce0b8f8
Changed strcpy() calls into strlcpy() calls, just to be extra safe.
2006-10-13 23:17:33 +00:00
Wayne Davison
deee574b11
Added a paranoid length check.
2006-10-13 23:17:30 +00:00
Wayne Davison
55410368e5
- Changed strcpy() calls into strlcpy() calls, just to be extra safe.
...
- Added a default: exit_cleanup() case to a switch.
- Made the check_name() function take a buffer size arg.
2006-10-13 23:17:27 +00:00
Wayne Davison
e4fdf1debe
- Use precompiler conditionals in to_wire_mode() and from_write_mode()
...
to get rid of code that is not needed on the current system.
- Silence a code-checker warning in send_file_entry().
- Silence a code-checker warning in make_file().
- Fixed a bug in f_name_cmp() that could compare an empty filename
incorrectly (which might only happen if we transformed a dot-dir
into an empty name). (Thanks, code checker!)
2006-10-13 17:07:13 +00:00
Wayne Davison
1580899c1d
More temporary name juggling to get all code analyzed.
2006-10-13 17:02:39 +00:00
Wayne Davison
f863b76300
Changed one more exit_cleanup() call into EXIT_OR_RETURN().
2006-10-13 14:28:56 +00:00
Wayne Davison
5e1ec06f09
Temporarily reorder the OBJS line so that the IBM code checker
...
can analyze some of the other programs (since it runs out of
time analyzing them all).
2006-10-13 14:17:22 +00:00
Wayne Davison
36e2ea6068
Use new FNONE value when setting/comparing enum logcode vars.
2006-10-13 07:48:35 +00:00
Wayne Davison
f4164b73b4
- Use the new FNONE enum instead of a literal 0 value.
2006-10-13 07:38:21 +00:00
Wayne Davison
9ef506a2b2
If in_exit_cleanup is set, some of our functions return instead of
...
calling exit_cleanup() (which is a safer way to avoid an infinite
loop when the exit code uses the log functions than allowing the
_exit_cleanup() function to return back into our code).
2006-10-13 07:38:18 +00:00
Wayne Davison
b1b54199ef
- When exiting, set the flag "in_exit_cleanup".
...
- Mark _exit_cleanup() with NORETURN.
- Don't ever return from _exit_cleanup().
2006-10-13 07:38:15 +00:00
Wayne Davison
33394b769d
Mark out_of_memory() and overflow_exit() with NORETURN.
2006-10-13 07:38:11 +00:00
Wayne Davison
011e85a5e3
- Added FNONE to the "enum logcode" values.
...
- Added a NORETURN define to mark a function that never returns.
2006-10-13 07:38:05 +00:00
Wayne Davison
d5dcb6f775
Silence some IBM checker warnings and made a slight optimization
...
to get_tmpname().
2006-10-13 07:18:29 +00:00
Wayne Davison
0c25dedf31
Simplified the function-finding regex, and made it more versatile
...
(so we don't need to keep adding variable-type strings).
2006-10-13 06:50:56 +00:00
Wayne Davison
6105464b79
Indented the function comments with "* ".
2006-10-13 06:49:44 +00:00
Wayne Davison
4d51f0db79
Don't use a bool directly in an int comparison.
2006-10-13 06:27:59 +00:00
Wayne Davison
ff530f04a0
Function fcntl() only takes 2 args when using F_GETFL.
2006-10-13 06:26:02 +00:00
Wayne Davison
e8b21fe406
Cast pat_len to an int when using it as a field width.
2006-10-13 06:24:24 +00:00
Wayne Davison
71cb9df386
Some OSes can't chmod -t for a file, so I changed the logic of our
...
to to substitute a chmod that will work everywhere.
2006-10-13 04:59:53 +00:00
Wayne Davison
f97c2d4a9b
- Clarified the "dont compress" option.
...
- Cleaned up some trailing whitespace.
2006-10-13 01:37:44 +00:00
Wayne Davison
b8a6dae038
Updated the man pages to work with version 2.x of yodl.
2006-10-13 01:24:57 +00:00
Wayne Davison
969f7ed5b7
Fixed an infinite loop in parse_rule() when a filter rule is too
...
longer for MAXPATHLEN. Also fixed a couple spots nearby that were
erroneously treating pointer "cp" as a '\0'-terminated string.
2006-10-13 01:22:48 +00:00
Wayne Davison
e825409a84
Preparing for release of 2.6.9pre1
2006-10-12 03:45:53 +00:00
Wayne Davison
b8d29fd8e6
Added a line for 2.6.9.
2006-10-12 03:44:44 +00:00
Wayne Davison
200f2d98db
Make sure we tweak the right RSYNC_VERSION line in configure.
2006-10-12 03:32:18 +00:00
Wayne Davison
1a7f3d99c5
Removed the changes in symlink handling in non-chroot daemon mode as
...
they were not yet safe (I'll consider similar changes for the next
release).
2006-10-12 03:01:18 +00:00
Wayne Davison
e80876700c
Got rid of changes that aren't going to make it into 2.6.9.
2006-10-12 03:01:12 +00:00
Wayne Davison
ec55b4f2fb
Changed the indent for one else ... if section.
2006-10-12 03:01:01 +00:00
Wayne Davison
798cde474f
Some minor improvements to parse_merge_name().
2006-10-12 02:14:47 +00:00
Wayne Davison