mirror/sdkman-cli
1
0
Fork 0
mirror of https://github.com/sdkman/sdkman-cli.git synced 2026-04-20 23:17:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refine bash major version check

Browse Source 
The previous bash version check, `bash --version | grep ... `, may not work when the output is not in English (for example, it didn't work when the output was in Italian). For the same reason, I've modified also the line 113, to output the first command output of `bash --version` without checking for the content.
This commit is contained in:
Giuseppe Ricupero
2018-05-21 16:52:02 +02:00
committed by Marco Vermeulen
parent 8e0ac4eaaf
commit addf0e9d67
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/bash/sdkman-utils.sh
View File

@@ -105,12 +105,12 @@ function __sdkman_echo_confirm {
}
function __sdkman_legacy_bash_message {
if [[ "$bash_shell" == 'true' && -z "$(bash --version | grep 'GNU bash, version 4..*')" ]]; then
if [[ "$bash_shell" == 'true' && "$BASH_VERSINFO" -lt 4 ]]; then
__sdkman_echo_red "An outdated version of bash was detected on your system!"
echo ""
__sdkman_echo_red "We recommend upgrading to bash 4.x, you have:"
echo ""
__sdkman_echo_yellow " $(bash --version | grep 'GNU bash, version')"
__sdkman_echo_yellow " $(bash --version | head -n1)"
echo ""
fi
}
}