mirror/seedit
1
0
Fork 0
mirror of https://github.com/plebbit/seedit.git synced 2026-02-14 16:01:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

perf(inbox): memoize filters to avoid recalculation at every render

Browse Source
This commit is contained in:
plebeius.eth
2024-03-02 21:07:39 +01:00
parent 121d10a656
commit f6caf90d8d
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/views/inbox/inbox.tsx
View File

@@ -1,4 +1,4 @@
import { useCallback, useEffect, useMemo, useRef } from 'react';
import { useEffect, useMemo, useRef } from 'react';
import { Link, useLocation } from 'react-router-dom';
import { StateSnapshot, Virtuoso, VirtuosoHandle } from 'react-virtuoso';
import { useAccount, useNotifications } from '@plebbit/plebbit-react-hooks';
@@ -50,19 +50,17 @@ const Inbox = () => {
const isInInboxPostRepliesView = isInboxPostRepliesView(location.pathname);
const isInInboxUnreadView = isInboxUnreadView(location.pathname);
const filterRepliesToUserReplies = useCallback(() => notifications?.filter((comment) => comment.parentCid !== comment.postCid) || [], [notifications]);
const filterRepliesToUserPosts = useCallback(() => notifications?.filter((comment) => comment.parentCid === comment.postCid) || [], [notifications]);
const filterUnreadNotifications = useCallback(() => notifications?.filter((comment) => !comment.markedAsRead) || [], [notifications]);
const filteredRepliesToUserReplies = useMemo(() => notifications?.filter((comment) => comment.parentCid !== comment.postCid) || [], [notifications]);
const filteredRepliesToUserPosts = useMemo(() => notifications?.filter((comment) => comment.parentCid === comment.postCid) || [], [notifications]);
const filteredUnreadNotifications = useMemo(() => notifications?.filter((comment) => !comment.markedAsRead) || [], [notifications]);
let comments;
if (isInInboxCommentRepliesView) {
comments = filterRepliesToUserReplies();
comments = filteredRepliesToUserReplies;
} else if (isInInboxPostRepliesView) {
comments = filterRepliesToUserPosts();
comments = filteredRepliesToUserPosts;
} else if (isInInboxUnreadView) {
comments = filterUnreadNotifications();
comments = filteredUnreadNotifications;
} else {
comments = notifications;
}