mirror/seerr
1
0
Fork 0
mirror of https://github.com/seerr-team/seerr.git synced 2026-07-30 09:37:05 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: close manage movie sidebar without back reopening (#2590)

Browse Source 
Co-authored-by: John Fletcher <johnfletcherdev@gmail.com>
Co-authored-by: gauthier-th <mail@gauthierth.fr>
This commit is contained in:
John Fletcher
2026-06-19 01:02:23 -06:00
committed by GitHub
parent 8d351bce65
commit 0a1f7035d0
3 changed files with 36 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
cypress/e2e/movie-details.cy.ts
View File

@@ -9,4 +9,20 @@ describe('Movie Details', () => {
'Minions: The Rise of Gru (2022)'
);
});
it('does not reopen the manager panel after closing and going back', () => {
cy.loginAsAdmin();
cy.visit('/movie/438148');
cy.visit('/movie/438148?manage=1');
cy.get('button[aria-label="Close panel"]').should('be.visible').click();
cy.location('search').should('eq', '');
cy.get('button[aria-label="Close panel"]').should('not.exist');
cy.go('back');
cy.location('search').should('eq', '');
cy.get('button[aria-label="Close panel"]').should('not.exist');
});
});

16
src/components/MovieDetails/index.tsx
View File

@@ -118,9 +118,7 @@ const MovieDetails = ({ movie }: MovieDetailsProps) => {
const router = useRouter();
const intl = useIntl();
const { locale } = useLocale();
const [showManager, setShowManager] = useState(
router.query.manage == '1' ? true : false
);
const [showManager, setShowManager] = useState(false);
const minStudios = 3;
const [showMoreStudios, setShowMoreStudios] = useState(false);
const [showIssueModal, setShowIssueModal] = useState(false);
@@ -158,8 +156,14 @@ const MovieDetails = ({ movie }: MovieDetailsProps) => {
);
useEffect(() => {
setShowManager(router.query.manage == '1' ? true : false);
}, [router.query.manage]);
if (router.query.manage === '1') {
setShowManager(true);
router.replace({
pathname: router.pathname,
query: { movieId: router.query.movieId },
});
}
}, [router, router.query.manage]);
const closeBlocklistModal = useCallback(
() => setShowBlocklistModal(false),
@@ -469,7 +473,7 @@ const MovieDetails = ({ movie }: MovieDetailsProps) => {
mediaType="movie"
onClose={() => {
setShowManager(false);
router.push({
router.replace({
pathname: router.pathname,
query: { movieId: router.query.movieId },
});

14
src/components/TvDetails/index.tsx
View File

@@ -118,7 +118,7 @@ const TvDetails = ({ tv }: TvDetailsProps) => {
const intl = useIntl();
const { locale } = useLocale();
const [showRequestModal, setShowRequestModal] = useState(false);
const [showManager, setShowManager] = useState(router.query.manage == '1');
const [showManager, setShowManager] = useState(false);
const [showIssueModal, setShowIssueModal] = useState(false);
const [isUpdating, setIsUpdating] = useState<boolean>(false);
const [toggleWatchlist, setToggleWatchlist] = useState<boolean>(
@@ -154,8 +154,14 @@ const TvDetails = ({ tv }: TvDetailsProps) => {
);
useEffect(() => {
setShowManager(router.query.manage == '1');
}, [router.query.manage]);
if (router.query.manage === '1') {
setShowManager(true);
router.replace({
pathname: router.pathname,
query: { tvId: router.query.tvId },
});
}
}, [router, router.query.manage]);
const closeBlocklistModal = useCallback(
() => setShowBlocklistModal(false),
@@ -519,7 +525,7 @@ const TvDetails = ({ tv }: TvDetailsProps) => {
mediaType="tv"
onClose={() => {
setShowManager(false);
router.push({
router.replace({
pathname: router.pathname,
query: { tvId: router.query.tvId },
});