nothing: Dummy commit

gui/default/assets/lang/lang-fr.json

@@ -152,7 +152,7 @@
     "Reused": "Réutilisé",
     "Save": "Sauver",
     "Scan Time Remaining": "Intervalle entre chaque analyse",
-    "Scanning": "Analyse en cours",
+    "Scanning": "En cours d'analyse",
     "Select the devices to share this folder with.": "Sélectionner les machines avec qui partager ce dossier.",
     "Select the folders to share with this device.": "Sélectionner les dossiers à partager avec cette machine.",
     "Settings": "Configuration",
@@ -179,7 +179,7 @@
     "Stopped": "Arrêté",
     "Support": "Aide",
     "Sync Protocol Listen Addresses": "Adresse d'écoute du protocole de synchronisation",
-    "Syncing": "Synchronisation en cours",
+    "Syncing": "En cours de synchronisation",
     "Syncthing has been shut down.": "Syncthing a été éteint.",
     "Syncthing includes the following software or portions thereof:": "Syncthing intègre les logiciels suivants (ou des éléments provenant de ces logiciels) :",
     "Syncthing is restarting.": "Syncthing est cours de redémarrage.",

gui/default/assets/lang/lang-fy.json

@@ -55,7 +55,7 @@
     "Edit Device": "Apparaat bewurkje",
     "Edit Folder": "Map bewurkje",
     "Editing": "Bewurkjen",
-    "Enable NAT traversal": "NAT-trochkruse ynskeakelje",
+    "Enable NAT traversal": "Enable NAT traversal",
     "Enable Relaying": "Trochjaan tastean",
     "Enable UPnP": "UPnP oansette",
     "Enter comma separated  (\"tcp://ip:port\", \"tcp://host:port\") addresses or \"dynamic\" to perform automatic discovery of the address.": "Fier troch komma's skieden (\"tcp://ip:port\", \"tcp://host:port\") adressen yn of \"dynamic\" om automatyske ûntdekking fan it adres út te fieren.",

gui/default/syncthing/settings/settingsModalView.html

@@ -56,24 +56,11 @@
               </div>
             </div>
 
-            <div class="row">
-              <div class="col-md-6">
-                <div class="form-group">
-                  <div class="checkbox">
-                    <label>
-                      <input id="GlobalAnnEnabled" type="checkbox" ng-model="tmpOptions.globalAnnounceEnabled"> <span translate>Global Discovery</span>
-                    </label>
-                  </div>
-                </div>
-              </div>
-              <div class="col-md-6">
-                <div class="form-group">
-                  <div class="checkbox">
-                    <label>
-                      <input id="RelaysEnabled" type="checkbox" ng-model="tmpOptions.relaysEnabled"> <span translate>Enable Relaying</span>
-                    </label>
-                  </div>
-                </div>
+            <div class="form-group">
+              <div class="checkbox">
+                <label>
+                  <input id="GlobalAnnEnabled" type="checkbox" ng-model="tmpOptions.globalAnnounceEnabled"> <span translate>Global Discovery</span>
+                </label>
               </div>
             </div>
 

lib/config/config.go

@@ -29,9 +29,9 @@ const (
 
 var (
 	// DefaultListenAddresses should be substituted when the configuration
-	// contains <listenAddress>default</listenAddress>. This is done by the
-	// "consumer" of the configuration as we don't want these saved to the
-	// config.
+	// contains <listenAddress>default</listenAddress>. This is
+	// done by the "consumer" of the configuration, as we don't want these
+	// saved to the config.
 	DefaultListenAddresses = []string{
 		"tcp://0.0.0.0:22000",
 		"dynamic+https://relays.syncthing.net/endpoint",
@@ -258,53 +258,27 @@ func convertV13V14(cfg *Configuration) {
 	// Not using the ignore cache is the new default. Disable it on existing
 	// configurations.
 	cfg.Options.CacheIgnoredFiles = false
-
-	// Migrate UPnP -> NAT options
 	cfg.Options.NATEnabled = cfg.Options.DeprecatedUPnPEnabled
-	cfg.Options.DeprecatedUPnPEnabled = false
 	cfg.Options.NATLeaseM = cfg.Options.DeprecatedUPnPLeaseM
-	cfg.Options.DeprecatedUPnPLeaseM = 0
 	cfg.Options.NATRenewalM = cfg.Options.DeprecatedUPnPRenewalM
-	cfg.Options.DeprecatedUPnPRenewalM = 0
 	cfg.Options.NATTimeoutS = cfg.Options.DeprecatedUPnPTimeoutS
-	cfg.Options.DeprecatedUPnPTimeoutS = 0
-
-	// Replace the default listen address "tcp://0.0.0.0:22000" with the
-	// string "default", but only if we also have the default relay pool
-	// among the relay servers as this is implied by the new "default"
-	// entry.
-	hasDefault := false
-	for _, raddr := range cfg.Options.DeprecatedRelayServers {
-		if raddr == "dynamic+https://relays.syncthing.net/endpoint" {
-			for i, addr := range cfg.Options.ListenAddresses {
-				if addr == "tcp://0.0.0.0:22000" {
-					cfg.Options.ListenAddresses[i] = "default"
-					hasDefault = true
-					break
-				}
+	if cfg.Options.DeprecatedRelaysEnabled {
+		cfg.Options.ListenAddresses = append(cfg.Options.ListenAddresses, cfg.Options.DeprecatedRelayServers...)
+		// Replace our two fairly long addresses with 'default' if both exist.
+		var newAddresses []string
+		for _, addr := range cfg.Options.ListenAddresses {
+			if addr != "tcp://0.0.0.0:22000" && addr != "dynamic+https://relays.syncthing.net/endpoint" {
+				newAddresses = append(newAddresses, addr)
 			}
-			break
+		}
+
+		if len(newAddresses)+2 == len(cfg.Options.ListenAddresses) {
+			cfg.Options.ListenAddresses = append([]string{"default"}, newAddresses...)
 		}
 	}
-
-	// Copy relay addresses into listen addresses.
-	for _, addr := range cfg.Options.DeprecatedRelayServers {
-		if hasDefault && addr == "dynamic+https://relays.syncthing.net/endpoint" {
-			// Skip the default relay address if we already have the
-			// "default" entry in the list.
-			continue
-		}
-		if addr == "" {
-			continue
-		}
-		cfg.Options.ListenAddresses = append(cfg.Options.ListenAddresses, addr)
-	}
-
+	cfg.Options.DeprecatedRelaysEnabled = false
 	cfg.Options.DeprecatedRelayServers = nil
 
-	// For consistency
-	sort.Strings(cfg.Options.ListenAddresses)
-
 	var newAddrs []string
 	for _, addr := range cfg.Options.GlobalAnnServers {
 		if addr != "default" {
@@ -328,10 +302,6 @@ func convertV13V14(cfg *Configuration) {
 		}
 		cfg.Folders[i].DeprecatedReadOnly = false
 	}
-	// v0.13-beta already had config version 13 but did not get the new URL
-	if cfg.Options.ReleasesURL == "https://api.github.com/repos/syncthing/syncthing/releases?per_page=30" {
-		cfg.Options.ReleasesURL = "https://upgrades.syncthing.net/meta.json"
-	}
 
 	cfg.Version = 14
 }

lib/config/config_test.go

@@ -12,9 +12,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
-	"reflect"
 	"runtime"
-	"sort"
 	"strings"
 	"testing"
 
@@ -42,7 +40,6 @@ func TestDefaultValues(t *testing.T) {
 		MaxSendKbps:             0,
 		MaxRecvKbps:             0,
 		ReconnectIntervalS:      60,
-		RelaysEnabled:           true,
 		RelayReconnectIntervalM: 10,
 		StartBrowser:            true,
 		NATEnabled:              true,
@@ -172,7 +169,6 @@ func TestOverriddenValues(t *testing.T) {
 		MaxSendKbps:             1234,
 		MaxRecvKbps:             2341,
 		ReconnectIntervalS:      6000,
-		RelaysEnabled:           false,
 		RelayReconnectIntervalM: 20,
 		StartBrowser:            false,
 		NATEnabled:              false,
@@ -620,61 +616,3 @@ func TestRemoveDuplicateDevicesFolders(t *testing.T) {
 		t.Errorf("Incorrect number of folder devices, %d != 2", l)
 	}
 }
-
-func TestV14ListenAddressesMigration(t *testing.T) {
-	tcs := [][3][]string{
-
-		// Default listen plus default relays is now "default"
-		{
-			{"tcp://0.0.0.0:22000"},
-			{"dynamic+https://relays.syncthing.net/endpoint"},
-			{"default"},
-		},
-		// Default listen address without any relay addresses gets converted
-		// to just the listen address. It's easier this way, and frankly the
-		// user has gone to some trouble to get the empty string in the
-		// config to start with...
-		{
-			{"tcp://0.0.0.0:22000"}, // old listen addrs
-			{""}, // old relay addrs
-			{"tcp://0.0.0.0:22000"}, // new listen addrs
-		},
-		// Default listen plus non-default relays gets copied verbatim
-		{
-			{"tcp://0.0.0.0:22000"},
-			{"dynamic+https://other.example.com"},
-			{"tcp://0.0.0.0:22000", "dynamic+https://other.example.com"},
-		},
-		// Non-default listen plus default relays gets copied verbatim
-		{
-			{"tcp://1.2.3.4:22000"},
-			{"dynamic+https://relays.syncthing.net/endpoint"},
-			{"tcp://1.2.3.4:22000", "dynamic+https://relays.syncthing.net/endpoint"},
-		},
-		// Default stuff gets sucked into "default", the rest gets copied
-		{
-			{"tcp://0.0.0.0:22000", "tcp://1.2.3.4:22000"},
-			{"dynamic+https://relays.syncthing.net/endpoint", "relay://other.example.com"},
-			{"default", "tcp://1.2.3.4:22000", "relay://other.example.com"},
-		},
-	}
-
-	for _, tc := range tcs {
-		cfg := Configuration{
-			Version: 13,
-			Options: OptionsConfiguration{
-				ListenAddresses:        tc[0],
-				DeprecatedRelayServers: tc[1],
-			},
-		}
-		convertV13V14(&cfg)
-		if cfg.Version != 14 {
-			t.Error("Configuration was not converted")
-		}
-
-		sort.Strings(tc[2])
-		if !reflect.DeepEqual(cfg.Options.ListenAddresses, tc[2]) {
-			t.Errorf("Migration error; actual %#v != expected %#v", cfg.Options.ListenAddresses, tc[2])
-		}
-	}
-}

lib/config/optionsconfiguration.go

@@ -16,7 +16,6 @@ type OptionsConfiguration struct {
 	MaxSendKbps             int      `xml:"maxSendKbps" json:"maxSendKbps"`
 	MaxRecvKbps             int      `xml:"maxRecvKbps" json:"maxRecvKbps"`
 	ReconnectIntervalS      int      `xml:"reconnectionIntervalS" json:"reconnectionIntervalS" default:"60"`
-	RelaysEnabled           bool     `xml:"relaysEnabled" json:"relaysEnabled" default:"true"`
 	RelayReconnectIntervalM int      `xml:"relayReconnectIntervalM" json:"relayReconnectIntervalM" default:"10"`
 	StartBrowser            bool     `xml:"startBrowser" json:"startBrowser" default:"true"`
 	NATEnabled              bool     `xml:"natEnabled" json:"natEnabled" default:"true"`
@@ -41,11 +40,12 @@ type OptionsConfiguration struct {
 	OverwriteRemoteDevNames bool     `xml:"overwriteRemoteDeviceNamesOnConnect" json:"overwriteRemoteDeviceNamesOnConnect" default:"false"`
 	TempIndexMinBlocks      int      `xml:"tempIndexMinBlocks" json:"tempIndexMinBlocks" default:"10"`
 
-	DeprecatedUPnPEnabled  bool     `xml:"upnpEnabled,omitempty" json:"-"`
-	DeprecatedUPnPLeaseM   int      `xml:"upnpLeaseMinutes,omitempty" json:"-"`
-	DeprecatedUPnPRenewalM int      `xml:"upnpRenewalMinutes,omitempty" json:"-"`
-	DeprecatedUPnPTimeoutS int      `xml:"upnpTimeoutSeconds,omitempty" json:"-"`
-	DeprecatedRelayServers []string `xml:"relayServer,omitempty" json:"-"`
+	DeprecatedUPnPEnabled   bool     `xml:"upnpEnabled" json:"-"`
+	DeprecatedUPnPLeaseM    int      `xml:"upnpLeaseMinutes" json:"-"`
+	DeprecatedUPnPRenewalM  int      `xml:"upnpRenewalMinutes" json:"-"`
+	DeprecatedUPnPTimeoutS  int      `xml:"upnpTimeoutSeconds" json:"-"`
+	DeprecatedRelaysEnabled bool     `xml:"relaysEnabled" json:"-"`
+	DeprecatedRelayServers  []string `xml:"relayServer" json:"-"`
 }
 
 func (orig OptionsConfiguration) Copy() OptionsConfiguration {

lib/connections/relay_dial.go

@@ -70,6 +70,10 @@ func (d *relayDialer) RedialFrequency() time.Duration {
 	return time.Duration(d.cfg.Options().RelayReconnectIntervalM) * time.Minute
 }
 
+func (d *relayDialer) String() string {
+	return "Relay Dialer"
+}
+
 type relayDialerFactory struct{}
 
 func (relayDialerFactory) New(cfg *config.Wrapper, tlsCfg *tls.Config) genericDialer {
@@ -82,11 +86,3 @@ func (relayDialerFactory) New(cfg *config.Wrapper, tlsCfg *tls.Config) genericDi
 func (relayDialerFactory) Priority() int {
 	return relayPriority
 }
-
-func (relayDialerFactory) Enabled(cfg config.Configuration) bool {
-	return cfg.Options.RelaysEnabled
-}
-
-func (relayDialerFactory) String() string {
-	return "Relay Dialer"
-}

lib/connections/relay_listen.go

@@ -13,26 +13,23 @@ import (
 	"sync"
 	"time"
 
-	"github.com/syncthing/syncthing/lib/config"
 	"github.com/syncthing/syncthing/lib/dialer"
 	"github.com/syncthing/syncthing/lib/nat"
 	"github.com/syncthing/syncthing/lib/relay/client"
 )
 
 func init() {
-	factory := &relayListenerFactory{}
-	listeners["relay"] = factory
-	listeners["dynamic+http"] = factory
-	listeners["dynamic+https"] = factory
+	listeners["relay"] = newRelayListener
+	listeners["dynamic+http"] = newRelayListener
+	listeners["dynamic+https"] = newRelayListener
 }
 
 type relayListener struct {
 	onAddressesChangedNotifier
 
-	uri     *url.URL
-	tlsCfg  *tls.Config
-	conns   chan IntermediateConnection
-	factory listenerFactory
+	uri    *url.URL
+	tlsCfg *tls.Config
+	conns  chan IntermediateConnection
 
 	err    error
 	client client.RelayClient
@@ -157,25 +154,14 @@ func (t *relayListener) Error() error {
 	return cerr
 }
 
-func (t *relayListener) Factory() listenerFactory {
-	return t.factory
-}
-
 func (t *relayListener) String() string {
 	return t.uri.String()
 }
 
-type relayListenerFactory struct{}
-
-func (f *relayListenerFactory) New(uri *url.URL, cfg *config.Wrapper, tlsCfg *tls.Config, conns chan IntermediateConnection, natService *nat.Service) genericListener {
+func newRelayListener(uri *url.URL, tlsCfg *tls.Config, conns chan IntermediateConnection, natService *nat.Service) genericListener {
 	return &relayListener{
-		uri:     uri,
-		tlsCfg:  tlsCfg,
-		conns:   conns,
-		factory: f,
+		uri:    uri,
+		tlsCfg: tlsCfg,
+		conns:  conns,
 	}
 }
-
-func (relayListenerFactory) Enabled(cfg config.Configuration) bool {
-	return cfg.Options.RelaysEnabled
-}

lib/connections/service.go

@@ -9,7 +9,6 @@ package connections
 import (
 	"crypto/tls"
 	"encoding/binary"
-	"errors"
 	"fmt"
 	"io"
 	"net"
@@ -113,10 +112,6 @@ func NewService(cfg *config.Wrapper, myID protocol.DeviceID, mdl Model, tlsCfg *
 	return service
 }
 
-var (
-	errDisabled = errors.New("disabled by configuration")
-)
-
 func (s *Service) handle() {
 next:
 	for c := range s.conns {
@@ -242,35 +237,24 @@ next:
 
 func (s *Service) connect() {
 	nextDial := make(map[string]time.Time)
+	delay := time.Second
+	sleep := time.Second
 
-	// Used as delay for the first few connection attempts, increases
-	// exponentially
-	initialRampup := time.Second
-
-	// Calculated from actual dialers reconnectInterval
-	var sleep time.Duration
+	bestDialerPrio := 1<<31 - 1 // worse prio won't build on 32 bit
+	for _, df := range dialers {
+		if prio := df.Priority(); prio < bestDialerPrio {
+			bestDialerPrio = prio
+		}
+	}
 
 	for {
-		cfg := s.cfg.Raw()
-
-		bestDialerPrio := 1<<31 - 1 // worse prio won't build on 32 bit
-		for _, df := range dialers {
-			if !df.Enabled(cfg) {
-				continue
-			}
-			if prio := df.Priority(); prio < bestDialerPrio {
-				bestDialerPrio = prio
-			}
-		}
-
 		l.Debugln("Reconnect loop")
 
 		now := time.Now()
 		var seen []string
 
 	nextDevice:
-		for _, deviceCfg := range cfg.Devices {
-			deviceID := deviceCfg.DeviceID
+		for deviceID, deviceCfg := range s.cfg.Devices() {
 			if deviceID == s.myID {
 				continue
 			}
@@ -308,40 +292,35 @@ func (s *Service) connect() {
 			seen = append(seen, addrs...)
 
 			for _, addr := range addrs {
-				nextDialAt, ok := nextDial[addr]
-				if ok && initialRampup >= sleep && nextDialAt.After(now) {
-					l.Debugf("Not dialing %v as sleep is %v, next dial is at %s and current time is %s", addr, sleep, nextDialAt, now)
-					continue
-				}
-				// If we fail at any step before actually getting the dialer
-				// retry in a minute
-				nextDial[addr] = now.Add(time.Minute)
-
 				uri, err := url.Parse(addr)
 				if err != nil {
-					l.Infof("Dialer for %s: %v", addr, err)
+					l.Infoln("Failed to parse connection url:", addr, err)
 					continue
 				}
 
-				dialerFactory, err := s.getDialerFactory(cfg, uri)
-				if err == errDisabled {
-					l.Debugln("Dialer for", uri, "is disabled")
-					continue
-				}
-				if err != nil {
-					l.Infof("Dialer for %v: %v", uri, err)
-					continue
-				}
-
-				if connected && dialerFactory.Priority() >= ct.Priority {
-					l.Debugf("Not dialing using %s as priorty is less than current connection (%d >= %d)", dialerFactory, dialerFactory.Priority(), ct.Priority)
+				dialerFactory, ok := dialers[uri.Scheme]
+				if !ok {
+					l.Debugln("Unknown address schema", uri)
 					continue
 				}
 
 				dialer := dialerFactory.New(s.cfg, s.tlsCfg)
-				l.Debugln("dial", deviceCfg.DeviceID, uri)
-				nextDial[addr] = now.Add(dialer.RedialFrequency())
 
+				nextDialAt, ok := nextDial[uri.String()]
+				// See below for comments on this delay >= sleep check
+				if delay >= sleep && ok && nextDialAt.After(now) {
+					l.Debugf("Not dialing as next dial is at %s and current time is %s", nextDialAt, now)
+					continue
+				}
+
+				nextDial[uri.String()] = now.Add(dialer.RedialFrequency())
+
+				if connected && dialer.Priority() >= ct.Priority {
+					l.Debugf("Not dialing using %s as priorty is less than current connection (%d >= %d)", dialer, dialer.Priority(), ct.Priority)
+					continue
+				}
+
+				l.Debugln("dial", deviceCfg.DeviceID, uri)
 				conn, err := dialer.Dial(deviceID, uri)
 				if err != nil {
 					l.Debugln("dial failed", deviceCfg.DeviceID, uri, err)
@@ -359,12 +338,12 @@ func (s *Service) connect() {
 
 		nextDial, sleep = filterAndFindSleepDuration(nextDial, seen, now)
 
-		if initialRampup < sleep {
-			l.Debugln("initial rampup; sleep", initialRampup, "and update to", initialRampup*2)
-			time.Sleep(initialRampup)
-			initialRampup *= 2
+		// delay variable is used to trigger much more frequent dialing after
+		// initial startup, essentially causing redials every 1, 2, 4, 8... seconds
+		if delay < sleep {
+			time.Sleep(delay)
+			delay *= 2
 		} else {
-			l.Debugln("sleep until next dial", sleep)
 			time.Sleep(sleep)
 		}
 	}
@@ -387,16 +366,24 @@ func (s *Service) shouldLimit(addr net.Addr) bool {
 	return !tcpaddr.IP.IsLoopback()
 }
 
-func (s *Service) createListener(factory listenerFactory, uri *url.URL) bool {
+func (s *Service) createListener(addr string) {
 	// must be called with listenerMut held
+	uri, err := url.Parse(addr)
+	if err != nil {
+		l.Infoln("Failed to parse listen address:", addr, err)
+		return
+	}
 
-	l.Debugln("Starting listener", uri)
+	listenerFactory, ok := listeners[uri.Scheme]
+	if !ok {
+		l.Infoln("Unknown listen address scheme:", uri.String())
+		return
+	}
 
-	listener := factory.New(uri, s.cfg, s.tlsCfg, s.conns, s.natService)
+	listener := listenerFactory(uri, s.tlsCfg, s.conns, s.natService)
 	listener.OnAddressesChanged(s.logListenAddressesChangedEvent)
-	s.listeners[uri.String()] = listener
-	s.listenerTokens[uri.String()] = s.Add(listener)
-	return true
+	s.listeners[addr] = listener
+	s.listenerTokens[addr] = s.Add(listener)
 }
 
 func (s *Service) logListenAddressesChangedEvent(l genericListener) {
@@ -430,33 +417,15 @@ func (s *Service) CommitConfiguration(from, to config.Configuration) bool {
 	s.listenersMut.Lock()
 	seen := make(map[string]struct{})
 	for _, addr := range config.Wrap("", to).ListenAddresses() {
-		if _, ok := s.listeners[addr]; ok {
-			seen[addr] = struct{}{}
-			continue
+		if _, ok := s.listeners[addr]; !ok {
+			l.Debugln("Staring listener", addr)
+			s.createListener(addr)
 		}
-
-		uri, err := url.Parse(addr)
-		if err != nil {
-			l.Infof("Listener for %s: %v", addr, err)
-			continue
-		}
-
-		factory, err := s.getListenerFactory(to, uri)
-		if err == errDisabled {
-			l.Debugln("Listener for", uri, "is disabled")
-			continue
-		}
-		if err != nil {
-			l.Infof("Listener for %v: %v", uri, err)
-			continue
-		}
-
-		s.createListener(factory, uri)
 		seen[addr] = struct{}{}
 	}
 
-	for addr, listener := range s.listeners {
-		if _, ok := seen[addr]; !ok || !listener.Factory().Enabled(to) {
+	for addr := range s.listeners {
+		if _, ok := seen[addr]; !ok {
 			l.Debugln("Stopping listener", addr)
 			s.Remove(s.listenerTokens[addr])
 			delete(s.listenerTokens, addr)
@@ -525,32 +494,6 @@ func (s *Service) Status() map[string]interface{} {
 	return result
 }
 
-func (s *Service) getDialerFactory(cfg config.Configuration, uri *url.URL) (dialerFactory, error) {
-	dialerFactory, ok := dialers[uri.Scheme]
-	if !ok {
-		return nil, fmt.Errorf("unknown address scheme %q", uri.Scheme)
-	}
-
-	if !dialerFactory.Enabled(cfg) {
-		return nil, errDisabled
-	}
-
-	return dialerFactory, nil
-}
-
-func (s *Service) getListenerFactory(cfg config.Configuration, uri *url.URL) (listenerFactory, error) {
-	listenerFactory, ok := listeners[uri.Scheme]
-	if !ok {
-		return nil, fmt.Errorf("unknown address scheme %q", uri.Scheme)
-	}
-
-	if !listenerFactory.Enabled(cfg) {
-		return nil, errDisabled
-	}
-
-	return listenerFactory, nil
-}
-
 func exchangeHello(c net.Conn, h protocol.HelloMessage) (protocol.HelloMessage, error) {
 	if err := c.SetDeadline(time.Now().Add(2 * time.Second)); err != nil {
 		return protocol.HelloMessage{}, err

lib/connections/structs.go

@@ -31,19 +31,16 @@ type Connection struct {
 type dialerFactory interface {
 	New(*config.Wrapper, *tls.Config) genericDialer
 	Priority() int
-	Enabled(config.Configuration) bool
-	String() string
 }
 
 type genericDialer interface {
 	Dial(protocol.DeviceID, *url.URL) (IntermediateConnection, error)
+	Priority() int
 	RedialFrequency() time.Duration
+	String() string
 }
 
-type listenerFactory interface {
-	New(*url.URL, *config.Wrapper, *tls.Config, chan IntermediateConnection, *nat.Service) genericListener
-	Enabled(config.Configuration) bool
-}
+type listenerFactory func(*url.URL, *tls.Config, chan IntermediateConnection, *nat.Service) genericListener
 
 type genericListener interface {
 	Serve()
@@ -61,7 +58,6 @@ type genericListener interface {
 	Error() error
 	OnAddressesChanged(func(genericListener))
 	String() string
-	Factory() listenerFactory
 }
 
 type Model interface {

lib/connections/tcp_dial.go

@@ -20,9 +20,8 @@ import (
 const tcpPriority = 10
 
 func init() {
-	factory := &tcpDialerFactory{}
 	for _, scheme := range []string{"tcp", "tcp4", "tcp6"} {
-		dialers[scheme] = factory
+		dialers[scheme] = tcpDialerFactory{}
 	}
 }
 
@@ -56,10 +55,18 @@ func (d *tcpDialer) Dial(id protocol.DeviceID, uri *url.URL) (IntermediateConnec
 	return IntermediateConnection{tc, "TCP (Client)", tcpPriority}, nil
 }
 
+func (tcpDialer) Priority() int {
+	return tcpPriority
+}
+
 func (d *tcpDialer) RedialFrequency() time.Duration {
 	return time.Duration(d.cfg.Options().ReconnectIntervalS) * time.Second
 }
 
+func (d *tcpDialer) String() string {
+	return "TCP Dialer"
+}
+
 type tcpDialerFactory struct{}
 
 func (tcpDialerFactory) New(cfg *config.Wrapper, tlsCfg *tls.Config) genericDialer {
@@ -72,11 +79,3 @@ func (tcpDialerFactory) New(cfg *config.Wrapper, tlsCfg *tls.Config) genericDial
 func (tcpDialerFactory) Priority() int {
 	return tcpPriority
 }
-
-func (tcpDialerFactory) Enabled(cfg config.Configuration) bool {
-	return true
-}
-
-func (tcpDialerFactory) String() string {
-	return "TCP Dialer"
-}

lib/connections/tcp_listen.go

@@ -14,26 +14,23 @@ import (
 	"sync"
 	"time"
 
-	"github.com/syncthing/syncthing/lib/config"
 	"github.com/syncthing/syncthing/lib/dialer"
 	"github.com/syncthing/syncthing/lib/nat"
 )
 
 func init() {
-	factory := &tcpListenerFactory{}
 	for _, scheme := range []string{"tcp", "tcp4", "tcp6"} {
-		listeners[scheme] = factory
+		listeners[scheme] = newTCPListener
 	}
 }
 
 type tcpListener struct {
 	onAddressesChangedNotifier
 
-	uri     *url.URL
-	tlsCfg  *tls.Config
-	stop    chan struct{}
-	conns   chan IntermediateConnection
-	factory listenerFactory
+	uri    *url.URL
+	tlsCfg *tls.Config
+	stop   chan struct{}
+	conns  chan IntermediateConnection
 
 	natService *nat.Service
 	mapping    *nat.Mapping
@@ -66,9 +63,6 @@ func (t *tcpListener) Serve() {
 	}
 	defer listener.Close()
 
-	l.Infof("TCP listener (%v) starting", listener.Addr())
-	defer l.Infof("TCP listener (%v) shutting down", listener.Addr())
-
 	mapping := t.natService.NewMapping(nat.TCP, tcaddr.IP, tcaddr.Port)
 	mapping.OnChanged(func(_ *nat.Mapping, _, _ []nat.Address) {
 		t.notifyAddressesChanged(t)
@@ -158,61 +152,16 @@ func (t *tcpListener) String() string {
 	return t.uri.String()
 }
 
-func (t *tcpListener) Factory() listenerFactory {
-	return t.factory
-}
-
-type tcpListenerFactory struct{}
-
-func (f *tcpListenerFactory) New(uri *url.URL, cfg *config.Wrapper, tlsCfg *tls.Config, conns chan IntermediateConnection, natService *nat.Service) genericListener {
+func newTCPListener(uri *url.URL, tlsCfg *tls.Config, conns chan IntermediateConnection, natService *nat.Service) genericListener {
 	return &tcpListener{
 		uri:        fixupPort(uri),
 		tlsCfg:     tlsCfg,
 		conns:      conns,
 		natService: natService,
 		stop:       make(chan struct{}),
-		factory:    f,
 	}
 }
 
-func (tcpListenerFactory) Enabled(cfg config.Configuration) bool {
-	return true
-}
-
-func isPublicIPv4(ip net.IP) bool {
-	ip = ip.To4()
-	if ip == nil {
-		// Not an IPv4 address (IPv6)
-		return false
-	}
-
-	// IsGlobalUnicast below only checks that it's not link local or
-	// multicast, and we want to exclude private (NAT:ed) addresses as well.
-	rfc1918 := []net.IPNet{
-		{IP: net.IP{10, 0, 0, 0}, Mask: net.IPMask{255, 0, 0, 0}},
-		{IP: net.IP{172, 16, 0, 0}, Mask: net.IPMask{255, 240, 0, 0}},
-		{IP: net.IP{192, 168, 0, 0}, Mask: net.IPMask{255, 255, 0, 0}},
-	}
-	for _, n := range rfc1918 {
-		if n.Contains(ip) {
-			return false
-		}
-	}
-
-	return ip.IsGlobalUnicast()
-}
-
-func isPublicIPv6(ip net.IP) bool {
-	if ip.To4() != nil {
-		// Not an IPv6 address (IPv4)
-		// (To16() returns a v6 mapped v4 address so can't be used to check
-		// that it's an actual v6 address)
-		return false
-	}
-
-	return ip.IsGlobalUnicast()
-}
-
 func fixupPort(uri *url.URL) *url.URL {
 	copyURI := *uri
 

lib/model/model.go

@@ -2018,7 +2018,6 @@ func (m *Model) CommitConfiguration(from, to config.Configuration) bool {
 	from.Options.URAccepted = to.Options.URAccepted
 	from.Options.URUniqueID = to.Options.URUniqueID
 	from.Options.ListenAddresses = to.Options.ListenAddresses
-	from.Options.RelaysEnabled = to.Options.RelaysEnabled
 	// All of the other generic options require restart. Or at least they may;
 	// removing this check requires going through those options carefully and
 	// making sure there are individual services that handle them correctly.

lib/relay/client/static.go

@@ -89,8 +89,7 @@ func (c *staticClient) Serve() {
 		return
 	}
 
-	l.Infof("Joined relay %s://%s", c.uri.Scheme, c.uri.Host)
-	defer l.Infof("Disconnected from relay %s://%s", c.uri.Scheme, c.uri.Host)
+	l.Infoln("Joined relay", c.uri)
 
 	c.mut.Lock()
 	c.connected = true

man/syncthing-bep.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-BEP" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-BEP" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-bep \- Block Exchange Protocol v1
 .
@@ -232,7 +232,7 @@ For C=1:
 The Length field contains the length, in bytes, of the compressed
 message data plus a four byte uncompressed length field.
 .IP \(bu 2
-The compressed message data is preceded by a 32 bit field denoting
+The compressed message data is preceeded by a 32 bit field denoting
 the length of the uncompressed message.
 .IP \(bu 2
 The message data is compressed using the LZ4 format and algorithm
@@ -1149,7 +1149,7 @@ is no longer available, therefore the list of block indexes should be truncated.
 Messages with \fBForget\fP bit set MUST NOT have any block indexes.
 .sp
 Any update message which is being sent for a different \fBVersion\fP of the same
-file name must be preceded with an update message for the old version of that
+file name must be preceeded with an update message for the old version of that
 file with the \fBForget\fP bit set.
 .sp
 As a safeguard on the receiving side, value of \fBVersion\fP changing between

man/syncthing-config.5

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-CONFIG" "5" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-CONFIG" "5" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-config \- Syncthing Configuration
 .
@@ -81,8 +81,8 @@ The following shows the default configuration file:
 .sp
 .nf
 .ft C
-<configuration version="14">
-    <folder id="zj2AA\-q55a7" label="Default Folder (zj2AA\-q55a7)" path="/Users/jb/Sync/" type="readwrite" rescanIntervalS="60" ignorePerms="false" autoNormalize="true">
+<configuration version="12">
+    <folder id="default" path="/Users/jb/Sync/" ro="false" rescanIntervalS="60" ignorePerms="false" autoNormalize="true">
         <device id="3LT2GA5\-CQI4XJM\-WTZ264P\-MLOGMHL\-MCRLDNT\-MZV4RD3\-KA745CL\-OGAERQZ"></device>
         <minDiskFreePct>1</minDiskFreePct>
         <versioning></versioning>
@@ -94,35 +94,34 @@ The following shows the default configuration file:
         <scanProgressIntervalS>0</scanProgressIntervalS>
         <pullerSleepS>0</pullerSleepS>
         <pullerPauseS>0</pullerPauseS>
-        <maxConflicts>\-1</maxConflicts>
-        <disableSparseFiles>false</disableSparseFiles>
-        <disableTempIndexes>false</disableTempIndexes>
+        <maxConflicts>0</maxConflicts>
     </folder>
     <device id="3LT2GA5\-CQI4XJM\-WTZ264P\-MLOGMHL\-MCRLDNT\-MZV4RD3\-KA745CL\-OGAERQZ" name="syno" compression="metadata" introducer="false">
         <address>dynamic</address>
     </device>
     <gui enabled="true" tls="false">
-        <address>127.0.0.1:8384</address>
+        <address>127.0.0.1:52620</address>
         <apikey>k1dnz1Dd0rzTBjjFFh7CXPnrF12C49B1</apikey>
-        <theme>default</theme>
     </gui>
     <options>
-        <listenAddress>default</listenAddress>
+        <listenAddress>tcp://0.0.0.0:22000</listenAddress>
         <globalAnnounceServer>default</globalAnnounceServer>
         <globalAnnounceEnabled>true</globalAnnounceEnabled>
         <localAnnounceEnabled>true</localAnnounceEnabled>
         <localAnnouncePort>21027</localAnnouncePort>
         <localAnnounceMCAddr>[ff12::8384]:21027</localAnnounceMCAddr>
+        <relayServer>dynamic+https://relays.syncthing.net/endpoint</relayServer>
         <maxSendKbps>0</maxSendKbps>
         <maxRecvKbps>0</maxRecvKbps>
         <reconnectionIntervalS>60</reconnectionIntervalS>
         <relaysEnabled>true</relaysEnabled>
         <relayReconnectIntervalM>10</relayReconnectIntervalM>
+        <relayWithoutGlobalAnn>false</relayWithoutGlobalAnn>
         <startBrowser>true</startBrowser>
-        <natEnabled>true</natEnabled>
-        <natLeaseMinutes>60</natLeaseMinutes>
-        <natRenewalMinutes>30</natRenewalMinutes>
-        <natTimeoutSeconds>10</natTimeoutSeconds>
+        <upnpEnabled>true</upnpEnabled>
+        <upnpLeaseMinutes>60</upnpLeaseMinutes>
+        <upnpRenewalMinutes>30</upnpRenewalMinutes>
+        <upnpTimeoutSeconds>10</upnpTimeoutSeconds>
         <urAccepted>0</urAccepted>
         <urUniqueID></urUniqueID>
         <urURL>https://data.syncthing.net/newdata</urURL>
@@ -131,14 +130,13 @@ The following shows the default configuration file:
         <restartOnWakeup>true</restartOnWakeup>
         <autoUpgradeIntervalH>12</autoUpgradeIntervalH>
         <keepTemporariesH>24</keepTemporariesH>
-        <cacheIgnoredFiles>false</cacheIgnoredFiles>
+        <cacheIgnoredFiles>true</cacheIgnoredFiles>
         <progressUpdateIntervalS>5</progressUpdateIntervalS>
         <symlinksEnabled>true</symlinksEnabled>
         <limitBandwidthInLan>false</limitBandwidthInLan>
+        <databaseBlockCacheMiB>0</databaseBlockCacheMiB>
         <minHomeDiskFreePct>1</minHomeDiskFreePct>
         <releasesURL>https://api.github.com/repos/syncthing/syncthing/releases?per_page=30</releasesURL>
-        <overwriteRemoteDeviceNamesOnConnect>false</overwriteRemoteDeviceNamesOnConnect>
-        <tempIndexMinBlocks>10</tempIndexMinBlocks>
     </options>
 </configuration>
 .ft P
@@ -160,7 +158,7 @@ migration from previous formats.
 .sp
 .nf
 .ft C
-<folder id="zj2AA\-q55a7" label="Default Folder (zj2AA\-q55a7)" path="/Users/jb/Sync/" type="readwrite" rescanIntervalS="60" ignorePerms="false" autoNormalize="true" ro="false">
+<folder id="default" path="/Users/jb/Sync/" ro="false" rescanIntervalS="60" ignorePerms="false" autoNormalize="true">
     <device id="3LT2GA5\-CQI4XJM\-WTZ264P\-MLOGMHL\-MCRLDNT\-MZV4RD3\-KA745CL\-OGAERQZ"></device>
     <minDiskFreePct>1</minDiskFreePct>
     <versioning></versioning>
@@ -172,9 +170,7 @@ migration from previous formats.
     <scanProgressIntervalS>0</scanProgressIntervalS>
     <pullerSleepS>0</pullerSleepS>
     <pullerPauseS>0</pullerPauseS>
-    <maxConflicts>\-1</maxConflicts>
-    <disableSparseFiles>false</disableSparseFiles>
-    <disableTempIndexes>false</disableTempIndexes>
+    <maxConflicts>0</maxConflicts>
 </folder>
 .ft P
 .fi
@@ -189,25 +185,13 @@ element:
 .B id
 The folder ID, must be unique. (mandatory)
 .TP
-.B label
-The label of a folder is a human readable and descriptive local name.
-Can be different on each device. (optional)
-.TP
 .B path
 The path to the directory where the folder is stored on this
 device; not sent to other devices. (mandatory)
 .TP
-.B type
-Controls how the folder is handled by Syncthing. Possible values are:
-.INDENT 7.0
-.TP
-.B readwrite
-The folder is in default mode. Sending local and accepting remote changes.
-.TP
-.B readonly
-The folder is in "master" mode \-\- it will not be modified by
-syncthing on this device.
-.UNINDENT
+.B ro
+True if the folder is read only (Master mode; will not be modified by
+Syncthing) on this device.
 .TP
 .B rescanIntervalS
 The rescan interval, in seconds. Can be set to zero to disable when external
@@ -290,16 +274,6 @@ what you\(aqre doing.
 The maximum number of conflict copies to keep around for any given file.
 The default, \-1, means an unlimited number. Setting this to zero disables
 conflict copies altogether.
-.TP
-.B disableSparseFiles
-By default, blocks containing all zeroes are not written, causing files
-to be sparse on filesystems that support the concept. When set to true,
-sparse files will not be created.
-.TP
-.B disableTempIndexes
-By default, devices exchange information about blocks available in
-transfers that are still in progress. When set to true, such information
-is not exchanged for this folder.
 .UNINDENT
 .SH DEVICE ELEMENT
 .INDENT 0.0
@@ -410,7 +384,6 @@ This optional element lists device IDs that have been specifically ignored. One
 <gui enabled="true" tls="false">
     <address>127.0.0.1:8384</address>
     <apikey>l7jSbCqPD95JYZ0g8vi4ZLAMg3ulnN1b</apikey>
-    <theme>default</theme>
 </gui>
 .ft P
 .fi
@@ -429,9 +402,6 @@ If not \fBtrue\fP, the GUI and API will not be started.
 If set to \fBtrue\fP, TLS (HTTPS) will be enforced. Non\-HTTPS requests will
 be redirected to HTTPS. When this is set to \fBfalse\fP, TLS connections are
 still possible but it is not mandatory.
-.TP
-.B theme
-The name of the theme to use.
 .UNINDENT
 .sp
 The following child elements may be present:
@@ -445,10 +415,16 @@ Allowed address formats are:
 .B IPv4 address and port (\fB127.0.0.1:8384\fP)
 The address and port is used as given.
 .TP
+.B IPv4 wildcard and port (\fBtcp4://0.0.0.0\fP, \fBtcp4://:8384\fP)
+These are equivalent and will result in Syncthing listening on all interfaces via IPv4 only.
+.TP
 .B IPv6 address and port (\fB[::1]:8384\fP)
 The address and port is used as given. The address must be enclosed in
 square brackets.
 .TP
+.B IPv6 wildcard and port (\fBtcp6://[::]:8384\fP, \fBtcp6://:8384\fP)
+These are equivalent and will result in Syncthing listening on all interfaces via IPv6 only.
+.TP
 .B Wildcard and port (\fB0.0.0.0:12345\fP, \fB[::]:12345\fP, \fB:12345\fP)
 These are equivalent and will result in Syncthing listening on all
 interfaces via both IPv4 and IPv6.
@@ -470,22 +446,24 @@ If set, this is the API key that enables usage of the REST interface.
 .nf
 .ft C
 <options>
-    <listenAddress>default</listenAddress>
+    <listenAddress>tcp://0.0.0.0:22000</listenAddress>
     <globalAnnounceServer>default</globalAnnounceServer>
     <globalAnnounceEnabled>true</globalAnnounceEnabled>
     <localAnnounceEnabled>true</localAnnounceEnabled>
     <localAnnouncePort>21027</localAnnouncePort>
     <localAnnounceMCAddr>[ff12::8384]:21027</localAnnounceMCAddr>
+    <relayServer>dynamic+https://relays.syncthing.net/endpoint</relayServer>
     <maxSendKbps>0</maxSendKbps>
     <maxRecvKbps>0</maxRecvKbps>
     <reconnectionIntervalS>60</reconnectionIntervalS>
     <relaysEnabled>true</relaysEnabled>
     <relayReconnectIntervalM>10</relayReconnectIntervalM>
+    <relayWithoutGlobalAnn>false</relayWithoutGlobalAnn>
     <startBrowser>true</startBrowser>
-    <natEnabled>true</natEnabled>
-    <natLeaseMinutes>60</natLeaseMinutes>
-    <natRenewalMinutes>30</natRenewalMinutes>
-    <natTimeoutSeconds>10</natTimeoutSeconds>
+    <upnpEnabled>true</upnpEnabled>
+    <upnpLeaseMinutes>60</upnpLeaseMinutes>
+    <upnpRenewalMinutes>30</upnpRenewalMinutes>
+    <upnpTimeoutSeconds>10</upnpTimeoutSeconds>
     <urAccepted>0</urAccepted>
     <urUniqueID></urUniqueID>
     <urURL>https://data.syncthing.net/newdata</urURL>
@@ -494,14 +472,13 @@ If set, this is the API key that enables usage of the REST interface.
     <restartOnWakeup>true</restartOnWakeup>
     <autoUpgradeIntervalH>12</autoUpgradeIntervalH>
     <keepTemporariesH>24</keepTemporariesH>
-    <cacheIgnoredFiles>false</cacheIgnoredFiles>
+    <cacheIgnoredFiles>true</cacheIgnoredFiles>
     <progressUpdateIntervalS>5</progressUpdateIntervalS>
     <symlinksEnabled>true</symlinksEnabled>
     <limitBandwidthInLan>false</limitBandwidthInLan>
+    <databaseBlockCacheMiB>0</databaseBlockCacheMiB>
     <minHomeDiskFreePct>1</minHomeDiskFreePct>
     <releasesURL>https://api.github.com/repos/syncthing/syncthing/releases?per_page=30</releasesURL>
-    <overwriteRemoteDeviceNamesOnConnect>false</overwriteRemoteDeviceNamesOnConnect>
-    <tempIndexMinBlocks>10</tempIndexMinBlocks>
 </options>
 .ft P
 .fi
@@ -512,8 +489,10 @@ The \fBoptions\fP element contains all other global configuration options.
 .INDENT 0.0
 .TP
 .B listenAddress
-The listen address for incoming sync connections. See
-\fI\%Listen Addresses\fP for allowed syntax.
+The listen address for incoming sync connections. See the \fBaddress\fP
+element under the \fI\%GUI Element\fP for allowed syntax, with the addition
+that the address must have a protocol scheme prefix. Currently \fBtcp://\fP
+is the only supported protocol scheme.
 .TP
 .B globalAnnounceServer
 A URI to a global announce (discovery) server, or the word \fBdefault\fP to
@@ -560,20 +539,25 @@ When true, relays will be connected to and potentially used for device to device
 .B relayReconnectIntervalM
 Sets the interval, in minutes, between relay reconnect attempts.
 .TP
+.B relayWithoutGlobalAnn
+When set to true, relay connections will be attempted even when global
+discovery is disabled. This is useful only in the case where devices are
+known to be connected to the same relays. The default is \fBfalse\fP\&.
+.TP
 .B startBrowser
 Whether to attempt to start a browser to show the GUI when Syncthing starts.
 .TP
-.B natEnabled
-Whether to attempt to perform an UPnP and NAT\-PMP port mapping for
-incoming sync connections.
+.B upnpEnabled
+Whether to attempt to perform an UPnP port mapping for incoming sync
+connections.
 .TP
-.B natLeaseMinutes
+.B upnpLeaseMinutes
 Request a lease for this many minutes; zero to request a permanent lease.
 .TP
-.B natRenewalMinutes
+.B upnpRenewalMinutes
 Attempt to renew the lease after this many minutes.
 .TP
-.B natTimeoutSeconds
+.B upnpTimeoutSeconds
 When scanning for UPnP devices, wait this long for responses.
 .TP
 .B urAccepted
@@ -610,9 +594,8 @@ Keep temporary failed transfers for this many hours. While the temporaries
 are kept, the data they contain need not be transferred again.
 .TP
 .B cacheIgnoredFiles
-Whether to cache the results of ignore pattern evaluation. Performance
-at the price of memory. Defaults to \fBfalse\fP as the cost for evaluating
-ignores is usually not significant.
+Whether to cache the results of ignore pattern evaluation. Performance at
+the price of memory.
 .TP
 .B progressUpdateIntervalS
 How often in seconds the progress of ongoing downloads is made available to
@@ -643,63 +626,6 @@ the configuration and index.
 .TP
 .B releasesURL
 The URL from which release information is loaded, for automatic upgrades.
-.TP
-.B overwriteRemoteDeviceNamesOnConnect
-If set, device names will always be overwritten with the name given by
-remote on each connection. By default, the name that the remote device
-announces will only be adopted when a name has not already been set.
-.TP
-.B tempIndexMinBlocks
-When exchanging index information for incomplete transfers, only take
-into account files that have at least this many blocks.
-.UNINDENT
-.SS Listen Addresses
-.sp
-The following address types are accepted in sync protocol listen addresses:
-.INDENT 0.0
-.TP
-.B TCP wildcard and port (\fBtcp://0.0.0.0:22000\fP, \fBtcp://:22000\fP)
-These are equivalent and will result in Syncthing listening on all
-interfaces, IPv4 and IPv6, on the specified port.
-.TP
-.B TCP IPv4 wildcard and port (\fBtcp4://0.0.0.0:22000\fP, \fBtcp4://:22000\fP)
-These are equivalent and will result in Syncthing listening on all
-interfaces via IPv4 only.
-.TP
-.B TCP IPv4 address and port (\fBtcp4://192.0.2.1:22000\fP)
-These are equivalent and will result in Syncthing listening on the
-specified address and port only.
-.TP
-.B TCP IPv6 wildcard and port (\fBtcp6://[::]:22000\fP, \fBtcp6://:22000\fP)
-These are equivalent and will result in Syncthing listening on all
-interfaces via IPv6 only.
-.TP
-.B TCP IPv6 address and port (\fBtcp6://[2001:db8::42]:22000\fP)
-These are equivalent and will result in Syncthing listening on the
-specified address and port only.
-.TP
-.B Static relay address (\fBrelay://192.0.2.42:22067?id=abcd123...\fP)
-Syncthing will connect to and listen for incoming connections via the
-specified relay address.
-.INDENT 7.0
-.INDENT 3.5
-.SS Todo
-.sp
-Document available URL parameters.
-.UNINDENT
-.UNINDENT
-.TP
-.B Dynamic relay pool (\fBdynamic+https://192.0.2.42/relays\fP)
-Syncthing will fetch the specified HTTPS URL, parse it for a JSON payload
-describing relays, select a relay from the available ones and listen via
-that as if specified as a static relay above.
-.INDENT 7.0
-.INDENT 3.5
-.SS Todo
-.sp
-Document available URL parameters.
-.UNINDENT
-.UNINDENT
 .UNINDENT
 .SH SYNCING CONFIGURATION FILES
 .sp

man/syncthing-device-ids.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-DEVICE-IDS" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-DEVICE-IDS" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-device-ids \- Understanding Device IDs
 .

man/syncthing-event-api.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-EVENT-API" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-EVENT-API" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-event-api \- Event API
 .

man/syncthing-faq.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-FAQ" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-FAQ" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-faq \- Frequently Asked Questions
 .
@@ -152,11 +152,6 @@ encrypted using AES\-128. When receiving data, it must be decrypted.
 .IP 3. 3
 There is a certain amount of housekeeping that must be done to track the
 current and available versions of each file in the index database.
-.IP 4. 3
-By default Syncthing uses periodic scanning every 60 seconds to detect
-file changes. This means checking every file\(aqs modification time and
-comparing it to the database. This can cause spikes of CPU usage for large
-folders.
 .UNINDENT
 .sp
 Hashing, compression and encryption cost CPU time. Also, using the GUI
@@ -169,10 +164,6 @@ environment variable \fBGOMAXPROCS\fP to the maximum number of CPU cores
 Syncthing should use at any given moment. For example, \fBGOMAXPROCS=2\fP on a
 machine with four cores will limit Syncthing to no more than half the
 system\(aqs CPU power.
-.sp
-To reduce CPU spikes from scanning activity, use a filesystem notifications
-plugin. This is delivered by default via Synctrayzor, Syncthing\-GTK and on
-Android. For other setups, consider using \fI\%syncthing\-inotify\fP <\fBhttps://github.com/syncthing/syncthing-inotify\fP>\&.
 .SS Should I keep my device IDs secret?
 .sp
 No. The IDs are not sensitive. Given a device ID it\(aqs possible to find the IP

man/syncthing-globaldisco.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-GLOBALDISCO" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-GLOBALDISCO" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-globaldisco \- Global Discovery Protocol v3
 .
@@ -67,7 +67,7 @@ certificate was presented, status \fB403\fP (Forbidden) is returned. If the
 posted data doesn\(aqt conform to the expected format, \fB400\fP (Bad Request) is
 returned.
 .sp
-In successful responses, the server may return a \fBReannounce\-After\fP header
+In successfull responses, the server may return a \fBReannounce\-After\fP header
 containing the number of seconds after which the client should perform a new
 announcement.
 .sp
@@ -84,7 +84,7 @@ Queries are performed as HTTPS GET requests to the announce server URL. The
 requested device ID is passed as the query parameter "device", in canonical
 string form, i.e. \fBhttps://announce.syncthing.net/?device=ABC12345\-....\fP
 .sp
-Successful responses will have status code \fB200\fP (OK) and carry a JSON payload
+Successfull responses will have status code \fB200\fP (OK) and carry a JSON payload
 of the same format as the announcement above. The response will not contain
 empty or unspecified addresses.
 .sp

man/syncthing-localdisco.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-LOCALDISCO" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-LOCALDISCO" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-localdisco \- Local Discovery Protocol v3
 .

man/syncthing-networking.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-NETWORKING" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-NETWORKING" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-networking \- Firewall Setup
 .

man/syncthing-relay.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-RELAY" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-RELAY" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-relay \- Relay Protocol v1
 .
@@ -337,7 +337,7 @@ _
 .TE
 .SH MESSAGES
 .sp
-All messages are preceded by a header message. Header message contains the
+All messages are preceeded by a header message. Header message contains the
 magic value 0x9E79BC40, message type integer, and message length.
 .sp
 \fBWARNING:\fP

man/syncthing-rest-api.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-REST-API" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-REST-API" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-rest-api \- REST API
 .

man/syncthing-security.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-SECURITY" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-SECURITY" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-security \- Security Principles
 .

man/syncthing-stignore.5

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING-STIGNORE" "5" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING-STIGNORE" "5" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing-stignore \- Prevent files from being synchronized to other nodes
 .

man/syncthing-versioning.7

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "TODO" "7" "May 17, 2016" "v0.12" "Syncthing"
+.TH "TODO" "7" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 Todo \- Keep automatic backups of deleted files by other nodes
 .

man/syncthing.1

@@ -1,6 +1,6 @@
 .\" Man page generated from reStructuredText.
 .
-.TH "SYNCTHING" "1" "May 17, 2016" "v0.12" "Syncthing"
+.TH "SYNCTHING" "1" "May 01, 2016" "v0.12" "Syncthing"
 .SH NAME
 syncthing \- Syncthing
 .

test/h1/config.xml

@@ -1,5 +1,5 @@
-<configuration version="14">
-    <folder id="default" label="" path="s1/" type="readwrite" rescanIntervalS="10" ignorePerms="false" autoNormalize="true">
+<configuration version="12">
+    <folder id="default" path="s1/" ro="false" rescanIntervalS="10" ignorePerms="false" autoNormalize="true">
         <device id="I6KAH76-66SLLLB-5PFXSOA-UFJCDZC-YAOMLEK-CP2GB32-BV5RQST-3PSROAU"></device>
         <device id="MRIW7OK-NETT3M4-N6SBWME-N25O76W-YJKVXPH-FUMQJ3S-P57B74J-GBITBAC"></device>
         <device id="373HSRP-QLPNLIE-JYKZVQF-P4PKZ63-R2ZE6K3-YD442U2-JHBGBQG-WWXAHAU"></device>
@@ -15,10 +15,8 @@
         <pullerSleepS>0</pullerSleepS>
         <pullerPauseS>0</pullerPauseS>
         <maxConflicts>-1</maxConflicts>
-        <disableSparseFiles>false</disableSparseFiles>
-        <disableTempIndexes>false</disableTempIndexes>
     </folder>
-    <folder id="¯\_(ツ)_/¯ Räksmörgås 动作 Адрес" label="" path="s12-1/" type="readwrite" rescanIntervalS="10" ignorePerms="false" autoNormalize="true">
+    <folder id="¯\_(ツ)_/¯ Räksmörgås 动作 Адрес" path="s12-1/" ro="false" rescanIntervalS="10" ignorePerms="false" autoNormalize="true">
         <device id="I6KAH76-66SLLLB-5PFXSOA-UFJCDZC-YAOMLEK-CP2GB32-BV5RQST-3PSROAU"></device>
         <device id="MRIW7OK-NETT3M4-N6SBWME-N25O76W-YJKVXPH-FUMQJ3S-P57B74J-GBITBAC"></device>
         <minDiskFreePct>1</minDiskFreePct>
@@ -32,8 +30,6 @@
         <pullerSleepS>0</pullerSleepS>
         <pullerPauseS>0</pullerPauseS>
         <maxConflicts>-1</maxConflicts>
-        <disableSparseFiles>false</disableSparseFiles>
-        <disableTempIndexes>false</disableTempIndexes>
     </folder>
     <device id="EJHMPAQ-OGCVORE-ISB4IS3-SYYVJXF-TKJGLTU-66DIQPF-GJ5D2GX-GQ3OWQK" name="s4" compression="metadata" introducer="false">
         <address>tcp://127.0.0.1:22004</address>
@@ -55,25 +51,26 @@
         <user>testuser</user>
         <password>$2a$10$7tKL5uvLDGn5s2VLPM2yWOK/II45az0mTel8hxAUJDRQN1Tk2QYwu</password>
         <apikey>abc123</apikey>
-        <theme>default</theme>
     </gui>
     <options>
         <listenAddress>tcp://127.0.0.1:22001</listenAddress>
-        <listenAddress>dynamic+https://relays.syncthing.net/endpoint</listenAddress>
         <globalAnnounceServer>default</globalAnnounceServer>
         <globalAnnounceEnabled>false</globalAnnounceEnabled>
         <localAnnounceEnabled>true</localAnnounceEnabled>
         <localAnnouncePort>21027</localAnnouncePort>
         <localAnnounceMCAddr>[ff12::8384]:21027</localAnnounceMCAddr>
+        <relayServer>dynamic+https://relays.syncthing.net/endpoint</relayServer>
         <maxSendKbps>0</maxSendKbps>
         <maxRecvKbps>0</maxRecvKbps>
         <reconnectionIntervalS>5</reconnectionIntervalS>
+        <relaysEnabled>true</relaysEnabled>
         <relayReconnectIntervalM>10</relayReconnectIntervalM>
+        <relayWithoutGlobalAnn>false</relayWithoutGlobalAnn>
         <startBrowser>false</startBrowser>
-        <natEnabled>true</natEnabled>
-        <natLeaseMinutes>0</natLeaseMinutes>
-        <natRenewalMinutes>30</natRenewalMinutes>
-        <natTimeoutSeconds>10</natTimeoutSeconds>
+        <upnpEnabled>true</upnpEnabled>
+        <upnpLeaseMinutes>0</upnpLeaseMinutes>
+        <upnpRenewalMinutes>30</upnpRenewalMinutes>
+        <upnpTimeoutSeconds>10</upnpTimeoutSeconds>
         <urAccepted>-1</urAccepted>
         <urUniqueID></urUniqueID>
         <urURL>https://data.syncthing.net/newdata</urURL>
@@ -82,18 +79,12 @@
         <restartOnWakeup>true</restartOnWakeup>
         <autoUpgradeIntervalH>12</autoUpgradeIntervalH>
         <keepTemporariesH>24</keepTemporariesH>
-        <cacheIgnoredFiles>false</cacheIgnoredFiles>
+        <cacheIgnoredFiles>true</cacheIgnoredFiles>
         <progressUpdateIntervalS>5</progressUpdateIntervalS>
         <symlinksEnabled>true</symlinksEnabled>
         <limitBandwidthInLan>false</limitBandwidthInLan>
+        <databaseBlockCacheMiB>0</databaseBlockCacheMiB>
         <minHomeDiskFreePct>1</minHomeDiskFreePct>
-        <releasesURL>https://upgrades.syncthing.net/meta.json</releasesURL>
-        <overwriteRemoteDeviceNamesOnConnect>false</overwriteRemoteDeviceNamesOnConnect>
-        <tempIndexMinBlocks>10</tempIndexMinBlocks>
-        <upnpEnabled>true</upnpEnabled>
-        <upnpLeaseMinutes>0</upnpLeaseMinutes>
-        <upnpRenewalMinutes>30</upnpRenewalMinutes>
-        <upnpTimeoutSeconds>10</upnpTimeoutSeconds>
-        <relaysEnabled>false</relaysEnabled>
+        <releasesURL>https://api.github.com/repos/syncthing/syncthing/releases?per_page=30</releasesURL>
     </options>
 </configuration>

vendor/github.com/AudriusButkevicius/go-nat-pmp/natpmp_test.go

@@ -1,9 +1,11 @@
 package natpmp
 
-import "testing"
+import (
+	"testing"
+)
 
 func TestNatPMP(t *testing.T) {
-	client, err := NewClientForDefaultGateway(0)
+	client, err := NewClientForDefaultGateway()
 	if err != nil {
 		t.Errorf("NewClientForDefaultGateway() = %v,%v", client, err)
 		return

vendor/manifest

@@ -4,7 +4,7 @@
 		{
 			"importpath": "github.com/AudriusButkevicius/go-nat-pmp",
 			"repository": "https://github.com/AudriusButkevicius/go-nat-pmp",
-			"revision": "e9d7ecafd6f4cd4f59fc45bb9a47466ce637d0fe",
+			"revision": "88a8019a0eff7e9db55f458230b867f0d7e5d48f",
 			"branch": "master"
 		},
 		{