tstest/natlab/{vnet,vmtest}: clean up natlab inconsitencies (#21483)

There were a handful of inconsitencies in natlab with the biggest being.
 - Pair and grid tests living under tstest/integration and using the old
   test style.
 - Inconsistent use of e vs env.
 - Methods for actions on node living on the vnet.Node rather than being
   a method on vmtest.Env

Clean up these inconsitencies.

Updates #cleanup

Signed-off-by: Claus Lensbøl <claus@tailscale.com>
This commit is contained in:
Claus Lensbøl authored and GitHub committed 2026-09-29 14:57:10 -04:00
1 parent eb79f3e33e
commit b31be2cd1e
8 files changed
+372 -861

No files matched your search

+3 -3
View File
@@ -131,7 +131,7 @@ jobs:
# compileBinariesForOS in vmtest.go.
- name: Warm Go build cache
run: |
./tool/go test -c -o /dev/null ./tstest/natlab/vmtest ./tstest/integration/nat
./tool/go test -c -o /dev/null ./tstest/natlab/vmtest
for pkg in tta tailscale tailscaled; do
GOOS=linux GOARCH=amd64 CGO_ENABLED=0 ./tool/go build -o /dev/null ./cmd/"$pkg"
done
@@ -148,9 +148,9 @@ jobs:
# single-test-per-matrix-job model. They stay runnable locally.
run: |
set -euo pipefail
exclude='^(TestGrid|TestVnetPerf.*)$'
exclude='^(TestGrid|TestPair|TestVnetPerf.*)$'
tmp=$(mktemp)
for pkg_dir in tstest/natlab/vmtest tstest/integration/nat; do
for pkg_dir in tstest/natlab/vmtest; do
pkg="./${pkg_dir}/"
for f in "${pkg_dir}"/*_test.go; do
[ -e "$f" ] || continue