mirror/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2026-04-03 06:02:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

tool/gocross: skip broken TestGocrossWrapper inside git worktree

Browse Source 
TestGocrossWrapper will fail when run inside a git linked worktree
because Go 1.26 and earlier cannot get the current revision hash.
Since this will be fixed in Go 1.27, see golang/go#58218, this patch
skips this test until that release.

Fixes #19217

Signed-off-by: Simon Law <sfllaw@tailscale.com>
This commit is contained in:
Simon Law
2026-04-01 21:12:24 -07:00
parent 211ef67222
commit df883e9cd8
2 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tool/gocross/gocross_wrapper_test.go
View File

@@ -6,13 +6,26 @@
package main
import (
"bytes"
"go/version"
"os"
"os/exec"
"runtime"
"strings"
"testing"
"tailscale.com/util/must"
)
func TestGocrossWrapper(t *testing.T) {
if version.Compare(runtime.Version(), "go1.27") < 0 {
gitDir := must.Get(exec.Command("git", "rev-parse", "--git-dir").Output())
gitCommonDir := must.Get(exec.Command("git", "rev-parse", "--git-common-dir").Output())
if !bytes.Equal(gitDir, gitCommonDir) {
t.Skip("skipping within git worktree, see https://go.dev/issue/58218")
}
}
for i := range 2 { // once to build gocross; second to test it's cached
cmd := exec.Command("./gocross-wrapper.sh", "version")
cmd.Env = append(os.Environ(), "CI=true", "NOBASHDEBUG=false", "TS_USE_GOCROSS=1") // for "set -x" verbosity

13
tool/gocross/gocross_wrapper_windows_test.go
View File

@@ -4,13 +4,26 @@
package main
import (
"bytes"
"go/version"
"os"
"os/exec"
"runtime"
"strings"
"testing"
"tailscale.com/util/must"
)
func TestGocrossWrapper(t *testing.T) {
if version.Compare(runtime.Version(), "go1.27") < 0 {
gitDir := must.Get(exec.Command("git", "rev-parse", "--git-dir").Output())
gitCommonDir := must.Get(exec.Command("git", "rev-parse", "--git-common-dir").Output())
if !bytes.Equal(gitDir, gitCommonDir) {
t.Skip("skipping within git worktree, see https://go.dev/issue/58218")
}
}
for i := range 2 { // once to build gocross; second to test it's cached
cmd := exec.Command("pwsh", "-NoProfile", "-ExecutionPolicy", "Bypass", ".\\gocross-wrapper.ps1", "version")
cmd.Env = append(os.Environ(), "CI=true", "NOPWSHDEBUG=false", "TS_USE_GOCROSS=1") // for Set-PSDebug verbosity