mirror of
https://github.com/tailscale/tailscale.git
synced 2026-09-12 22:08:26 -04:00
Brad Fitzpatrick
2bd3a04528
Nothing reads ipn.Notify.NetMap anymore. The previous commit removed its runtime (non-initial) emission, and every first-party client is also off the initial one: the Win32 and WinUI GUIs and the Apple bridge subscribe with InitialStatus or InitialState plus peer deltas, Android never used it, and the remaining in-tree subscribers that set NotifyInitialNetMap (sniproxy and the kube helpers) only did so to get the initial Notify.SelfChange and discarded the netmap that tailscaled built, encoded, and shipped for them. SelfChange is not gated by any subscription bit; runtime self changes already go to every watcher. Extend that to the start of the session: every watch session now begins with a Notify carrying the current self node (if any), regardless of mask, so no bit is needed to seed a watcher's view. Watchers that need more than self info fetch the netmap on demand via LocalClient.NetMap. With that, delete the Notify.NetMap field and the NotifyInitialNetMap bit. The bit value stays reserved under the name NotifyInitialNetMapRemoved and ValidateNotifyWatchOpt rejects subscriptions that set it, like the NotifyRateLimit bit removed in the previous commit. NotifyNoNetMap remains accepted as a no-op because shipping GUIs still set it. Updates #12542 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> Change-Id: I242992a744c0ffd0be6f27e8c735aa69d5b23b5e