mirror of
https://github.com/tailscale/tailscale.git
synced 2026-02-15 02:12:07 -05:00
This file was never truly necessary and has never actually been used in the history of Tailscale's open source releases. A Brief History of AUTHORS files --- The AUTHORS file was a pattern developed at Google, originally for Chromium, then adopted by Go and a bunch of other projects. The problem was that Chromium originally had a copyright line only recognizing Google as the copyright holder. Because Google (and most open source projects) do not require copyright assignemnt for contributions, each contributor maintains their copyright. Some large corporate contributors then tried to add their own name to the copyright line in the LICENSE file or in file headers. This quickly becomes unwieldy, and puts a tremendous burden on anyone building on top of Chromium, since the license requires that they keep all copyright lines intact. The compromise was to create an AUTHORS file that would list all of the copyright holders. The LICENSE file and source file headers would then include that list by reference, listing the copyright holder as "The Chromium Authors". This also become cumbersome to simply keep the file up to date with a high rate of new contributors. Plus it's not always obvious who the copyright holder is. Sometimes it is the individual making the contribution, but many times it may be their employer. There is no way for the proejct maintainer to know. Eventually, Google changed their policy to no longer recommend trying to keep the AUTHORS file up to date proactively, and instead to only add to it when requested: https://opensource.google/docs/releasing/authors. They are also clear that: > Adding contributors to the AUTHORS file is entirely within the > project's discretion and has no implications for copyright ownership. It was primarily added to appease a small number of large contributors that insisted that they be recognized as copyright holders (which was entirely their right to do). But it's not truly necessary, and not even the most accurate way of identifying contributors and/or copyright holders. In practice, we've never added anyone to our AUTHORS file. It only lists Tailscale, so it's not really serving any purpose. It also causes confusion because Tailscalars put the "Tailscale Inc & AUTHORS" header in other open source repos which don't actually have an AUTHORS file, so it's ambiguous what that means. Instead, we just acknowledge that the contributors to Tailscale (whoever they are) are copyright holders for their individual contributions. We also have the benefit of using the DCO (developercertificate.org) which provides some additional certification of their right to make the contribution. The source file changes were purely mechanical with: git ls-files | xargs sed -i -e 's/\(Tailscale Inc &\) AUTHORS/\1 contributors/g' Updates #cleanup Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <will@tailscale.com>
279 lines
8.3 KiB
Go
279 lines
8.3 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package tstest
|
|
|
|
import (
|
|
"bytes"
|
|
"runtime"
|
|
"runtime/pprof"
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// ResourceCheck takes a snapshot of the current goroutines and registers a
|
|
// cleanup on tb to verify that after the rest, all goroutines created by the
|
|
// test go away. (well, at least that the count matches. Maybe in the future it
|
|
// can look at specific routines).
|
|
//
|
|
// It panics if called from a parallel test.
|
|
func ResourceCheck(tb testing.TB) {
|
|
tb.Helper()
|
|
|
|
// Set an environment variable (anything at all) just for the
|
|
// side effect of tb.Setenv panicking if we're in a parallel test.
|
|
tb.Setenv("TS_CHECKING_RESOURCES", "1")
|
|
|
|
startN, startStacks := goroutines()
|
|
tb.Cleanup(func() {
|
|
if tb.Failed() {
|
|
// Test has failed - but this doesn't catch panics due to
|
|
// https://github.com/golang/go/issues/49929.
|
|
return
|
|
}
|
|
// Goroutines might be still exiting.
|
|
for range 300 {
|
|
if runtime.NumGoroutine() <= startN {
|
|
return
|
|
}
|
|
time.Sleep(10 * time.Millisecond)
|
|
}
|
|
endN, endStacks := goroutines()
|
|
if endN <= startN {
|
|
return
|
|
}
|
|
|
|
// Parse and print goroutines.
|
|
start := parseGoroutines(startStacks)
|
|
end := parseGoroutines(endStacks)
|
|
if testing.Verbose() {
|
|
tb.Logf("goroutines start:\n%s", printGoroutines(start))
|
|
tb.Logf("goroutines end:\n%s", printGoroutines(end))
|
|
}
|
|
|
|
// Print goroutine diff, omitting tstest.ResourceCheck goroutines.
|
|
self := func(g goroutine) bool { return bytes.Contains(g.stack, []byte("\ttailscale.com/tstest.goroutines+")) }
|
|
start.goroutines = slices.DeleteFunc(start.goroutines, self)
|
|
end.goroutines = slices.DeleteFunc(end.goroutines, self)
|
|
tb.Logf("goroutine diff (-start +end):\n%s", diffGoroutines(start, end))
|
|
|
|
// tb.Failed() above won't report on panics, so we shouldn't call Fatal
|
|
// here or we risk suppressing reporting of the panic.
|
|
tb.Errorf("goroutine count: expected %d, got %d\n", startN, endN)
|
|
})
|
|
}
|
|
|
|
func goroutines() (int, []byte) {
|
|
p := pprof.Lookup("goroutine")
|
|
b := new(bytes.Buffer)
|
|
p.WriteTo(b, 1)
|
|
return p.Count(), b.Bytes()
|
|
}
|
|
|
|
// parseGoroutines takes pprof/goroutines?debug=1 -formatted output sorted by
|
|
// count, and splits it into a separate list of goroutines with count and stack
|
|
// separated.
|
|
//
|
|
// Example input:
|
|
//
|
|
// goroutine profile: total 408
|
|
// 48 @ 0x47bc0e 0x136c6b9 0x136c69e 0x136c7ab 0x1379809 0x13797fa 0x483da1
|
|
// # 0x136c6b8 gvisor.dev/gvisor/pkg/sync.Gopark+0x78 gvisor.dev/gvisor@v0.0.0-20250205023644-9414b50a5633/pkg/sync/runtime_unsafe.go:33
|
|
// # 0x136c69d gvisor.dev/gvisor/pkg/sleep.(*Sleeper).nextWaker+0x5d gvisor.dev/gvisor@v0.0.0-20250205023644-9414b50a5633/pkg/sleep/sleep_unsafe.go:210
|
|
// # 0x136c7aa gvisor.dev/gvisor/pkg/sleep.(*Sleeper).fetch+0x2a gvisor.dev/gvisor@v0.0.0-20250205023644-9414b50a5633/pkg/sleep/sleep_unsafe.go:257
|
|
// # 0x1379808 gvisor.dev/gvisor/pkg/sleep.(*Sleeper).Fetch+0xa8 gvisor.dev/gvisor@v0.0.0-20250205023644-9414b50a5633/pkg/sleep/sleep_unsafe.go:280
|
|
// # 0x13797f9 gvisor.dev/gvisor/pkg/tcpip/transport/tcp.(*processor).start+0x99 gvisor.dev/gvisor@v0.0.0-20250205023644-9414b50a5633/pkg/tcpip/transport/tcp/dispatcher.go:291
|
|
//
|
|
// 48 @ 0x47bc0e 0x413705 0x4132b2 0x10fc905 0x483da1
|
|
// # 0x10fc904 github.com/tailscale/wireguard-go/device.(*Device).RoutineDecryption+0x184 github.com/tailscale/wireguard-go@v0.0.0-20250107165329-0b8b35511f19/device/receive.go:245
|
|
//
|
|
// 48 @ 0x47bc0e 0x413705 0x4132b2 0x10fcd2a 0x483da1
|
|
// # 0x10fcd29 github.com/tailscale/wireguard-go/device.(*Device).RoutineHandshake+0x169 github.com/tailscale/wireguard-go@v0.0.0-20250107165329-0b8b35511f19/device/receive.go:279
|
|
//
|
|
// 48 @ 0x47bc0e 0x413705 0x4132b2 0x1100ba7 0x483da1
|
|
// # 0x1100ba6 github.com/tailscale/wireguard-go/device.(*Device).RoutineEncryption+0x186 github.com/tailscale/wireguard-go@v0.0.0-20250107165329-0b8b35511f19/device/send.go:451
|
|
//
|
|
// 26 @ 0x47bc0e 0x458e57 0x847587 0x483da1
|
|
// # 0x847586 database/sql.(*DB).connectionOpener+0x86 database/sql/sql.go:1261
|
|
//
|
|
// 13 @ 0x47bc0e 0x458e57 0x754927 0x483da1
|
|
// # 0x754926 net/http.(*persistConn).writeLoop+0xe6 net/http/transport.go:2596
|
|
//
|
|
// 7 @ 0x47bc0e 0x413705 0x4132b2 0x10fda4d 0x483da1
|
|
// # 0x10fda4c github.com/tailscale/wireguard-go/device.(*Peer).RoutineSequentialReceiver+0x16c github.com/tailscale/wireguard-go@v0.0.0-20250107165329-0b8b35511f19/device/receive.go:443
|
|
func parseGoroutines(g []byte) goroutineDump {
|
|
head, tail, ok := bytes.Cut(g, []byte("\n"))
|
|
if !ok {
|
|
return goroutineDump{head: head}
|
|
}
|
|
|
|
raw := bytes.Split(tail, []byte("\n\n"))
|
|
parsed := make([]goroutine, 0, len(raw))
|
|
for _, s := range raw {
|
|
count, rem, ok := bytes.Cut(s, []byte(" @ "))
|
|
if !ok {
|
|
continue
|
|
}
|
|
header, stack, _ := bytes.Cut(rem, []byte("\n"))
|
|
sort := slices.Clone(header)
|
|
reverseWords(sort)
|
|
parsed = append(parsed, goroutine{count, header, stack, sort})
|
|
}
|
|
|
|
return goroutineDump{head, parsed}
|
|
}
|
|
|
|
type goroutineDump struct {
|
|
head []byte
|
|
goroutines []goroutine
|
|
}
|
|
|
|
// goroutine is a parsed stack trace in pprof goroutine output, e.g.
|
|
// "10 @ 0x100 0x001\n# 0x100 test() test.go\n# 0x001 main() test.go".
|
|
type goroutine struct {
|
|
count []byte // e.g. "10"
|
|
header []byte // e.g. "0x100 0x001"
|
|
stack []byte // e.g. "# 0x100 test() test.go\n# 0x001 main() test.go"
|
|
|
|
// sort is the same pointers as in header, but in reverse order so that we
|
|
// can place related goroutines near each other by sorting on this field.
|
|
// E.g. "0x001 0x100".
|
|
sort []byte
|
|
}
|
|
|
|
func (g goroutine) Compare(h goroutine) int {
|
|
return bytes.Compare(g.sort, h.sort)
|
|
}
|
|
|
|
// reverseWords repositions the words in b such that they are reversed.
|
|
// Words are separated by spaces. New lines are not considered.
|
|
// https://sketch.dev/sk/a4ef
|
|
func reverseWords(b []byte) {
|
|
if len(b) == 0 {
|
|
return
|
|
}
|
|
|
|
// First, reverse the entire slice.
|
|
reverse(b)
|
|
|
|
// Then reverse each word individually.
|
|
start := 0
|
|
for i := 0; i <= len(b); i++ {
|
|
if i == len(b) || b[i] == ' ' {
|
|
reverse(b[start:i])
|
|
start = i + 1
|
|
}
|
|
}
|
|
}
|
|
|
|
// reverse reverses bytes in place
|
|
func reverse(b []byte) {
|
|
for i, j := 0, len(b)-1; i < j; i, j = i+1, j-1 {
|
|
b[i], b[j] = b[j], b[i]
|
|
}
|
|
}
|
|
|
|
// printGoroutines returns a text representation of h, gs equivalent to the
|
|
// pprof ?debug=1 input parsed by parseGoroutines, except the goroutines are
|
|
// sorted in an order easier for diffing.
|
|
func printGoroutines(g goroutineDump) []byte {
|
|
var b bytes.Buffer
|
|
b.Write(g.head)
|
|
|
|
slices.SortFunc(g.goroutines, goroutine.Compare)
|
|
for _, g := range g.goroutines {
|
|
b.WriteString("\n\n")
|
|
b.Write(g.count)
|
|
b.WriteString(" @ ")
|
|
b.Write(g.header)
|
|
b.WriteString("\n")
|
|
if len(g.stack) > 0 {
|
|
b.Write(g.stack)
|
|
}
|
|
}
|
|
|
|
return b.Bytes()
|
|
}
|
|
|
|
// diffGoroutines returns a diff between goroutines of gx and gy.
|
|
// Goroutines present in gx and absent from gy are prefixed with "-".
|
|
// Goroutines absent from gx and present in gy are prefixed with "+".
|
|
// Goroutines present in both but with different counts only show a prefix on the count line.
|
|
func diffGoroutines(x, y goroutineDump) string {
|
|
hx, hy := x.head, y.head
|
|
gx, gy := x.goroutines, y.goroutines
|
|
var b strings.Builder
|
|
if !bytes.Equal(hx, hy) {
|
|
b.WriteString("- ")
|
|
b.Write(hx)
|
|
b.WriteString("\n+ ")
|
|
b.Write(hy)
|
|
b.WriteString("\n")
|
|
}
|
|
|
|
slices.SortFunc(gx, goroutine.Compare)
|
|
slices.SortFunc(gy, goroutine.Compare)
|
|
|
|
writeHeader := func(prefix string, g goroutine) {
|
|
b.WriteString(prefix)
|
|
b.Write(g.count)
|
|
b.WriteString(" @ ")
|
|
b.Write(g.header)
|
|
b.WriteString("\n")
|
|
}
|
|
writeStack := func(prefix string, g goroutine) {
|
|
s := g.stack
|
|
for {
|
|
var h []byte
|
|
h, s, _ = bytes.Cut(s, []byte("\n"))
|
|
if len(h) == 0 && len(s) == 0 {
|
|
break
|
|
}
|
|
b.WriteString(prefix)
|
|
b.Write(h)
|
|
b.WriteString("\n")
|
|
}
|
|
}
|
|
|
|
i, j := 0, 0
|
|
for {
|
|
var d int
|
|
switch {
|
|
case i < len(gx) && j < len(gy):
|
|
d = gx[i].Compare(gy[j])
|
|
case i < len(gx):
|
|
d = -1
|
|
case j < len(gy):
|
|
d = 1
|
|
default:
|
|
return b.String()
|
|
}
|
|
|
|
switch d {
|
|
case -1:
|
|
b.WriteString("\n")
|
|
writeHeader("- ", gx[i])
|
|
writeStack("- ", gx[i])
|
|
i++
|
|
|
|
case +1:
|
|
b.WriteString("\n")
|
|
writeHeader("+ ", gy[j])
|
|
writeStack("+ ", gy[j])
|
|
j++
|
|
|
|
case 0:
|
|
if !bytes.Equal(gx[i].count, gy[j].count) {
|
|
b.WriteString("\n")
|
|
writeHeader("- ", gx[i])
|
|
writeHeader("+ ", gy[j])
|
|
writeStack(" ", gy[j])
|
|
}
|
|
i++
|
|
j++
|
|
}
|
|
}
|
|
}
|