Brad Fitzpatrick daafc49acd tsnet: deflake TestUserMetricsByteCounters
TestUserMetricsByteCounters is currently our top flake at http://flakes/

The test waited for a direct path between its two localhost nodes by
polling s1's status until CurAddr was set, then asserted that the
transferred bytes appeared in the path="direct_ipv4" counters. Both
steps were flaky:

- CurAddr is only reported while magicsock has a confirmed, currently
  trusted UDP address for the peer, which depends on a heartbeat ping
  and CallMeMaybe cycle that can lag arbitrarily under CI load. In the
  CI failure logs the transfer itself went direct and the byte counter
  assertions passed; the only failure was the polling helper's
  t.Error.

- On a machine where localhost has both IPv4 and IPv6, magicsock can
  pick ::1 (it prefers IPv6 on latency ties), so the transfer lands in
  the direct_ipv6 counters instead.

- If no direct path is established yet, the transfer goes over DERP, whose
  wire-byte total (relay framing, plus TCP retransmissions inside the
  tunnel under load) can exceed any fixed tolerance; one flakestress
  run counted 33% more than the payload sent.

Drop the direct-path wait and the hardcoded path label, and assert the
one invariant the test actually cares about: at least the number of
bytes sent must be counted across all path counters combined. There is
deliberately no upper bound, since the counters legitimately include
overhead, retransmissions, and the duplicate copies magicsock sends on
several paths while a direct path is being confirmed.

Verified with flakestress: the old test failed within 7 runs, while the
fixed test passed 33,521 runs with no failures.

See
http://flakes/analyze-test?name=tailscale.com%2ftsnet.TestUserMetricsByteCounters

Updates #deflake

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Change-Id: I4d8a9bfb9549ea9d8d33d3a3b55b4d03f9b9be78
2026-09-14 08:56:14 -07:00

Tailscale

https://tailscale.com

Private WireGuard® networks made easy

Overview

This repository contains the majority of Tailscale's open source code. Notably, it includes the tailscaled daemon and the tailscale CLI tool. The tailscaled daemon runs on Linux, Windows, macOS, and to varying degrees on FreeBSD and OpenBSD. The Tailscale iOS and Android apps use this repo's code, but this repo doesn't contain the mobile GUI code.

Other Tailscale repos of note:

For background on which parts of Tailscale are open source and why, see https://tailscale.com/opensource/.

Using

We serve packages for a variety of distros and platforms at https://pkgs.tailscale.com.

Other clients

The macOS, iOS, and Windows clients use the code in this repository but additionally include small GUI wrappers. The GUI wrappers on non-open source platforms are themselves not open source.

Building

We always require the latest Go release, currently Go 1.27. (While we build releases with our Go fork, its use is not required.)

go install tailscale.com/cmd/tailscale{,d}

If you're packaging Tailscale for distribution, use build_dist.sh instead, to burn commit IDs and version info into the binaries:

./build_dist.sh tailscale.com/cmd/tailscale
./build_dist.sh tailscale.com/cmd/tailscaled

If your distro has conventions that preclude the use of build_dist.sh, please do the equivalent of what it does in your distro's way, so that bug reports contain useful version information.

Bugs

Please file any issues about this code or the hosted service on the issue tracker.

Contributing

PRs welcome! But please file bugs. Commit messages should reference bugs.

We require Developer Certificate of Origin Signed-off-by lines in commits.

See commit-messages.md (or skim git log) for our commit message style.

About Us

Tailscale is primarily developed by the people at https://github.com/orgs/tailscale/people. For other contributors, see:

WireGuard is a registered trademark of Jason A. Donenfeld.

S
Description
No description provided
Readme BSD-3-Clause
173 MiB
0 Stars 1 Watchers 0 Forks
Languages
Go 96%
C 1.4%
TypeScript 0.9%
Shell 0.6%
Swift 0.3%
Other 0.5%