mirror/xpipe
1
0
Fork 0
mirror of https://github.com/xpipe-io/xpipe.git synced 2026-04-22 15:40:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

Improve list box performance by synchronizing less

Browse Source
This commit is contained in:
crschnick
2025-03-21 16:53:10 +00:00
parent 474d201708
commit b39c74b4ff
1 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
app/src/main/java/io/xpipe/app/comp/base/ListBoxViewComp.java
View File

@@ -262,25 +262,27 @@ public class ListBoxViewComp<T> extends Comp<CompStructure<ScrollPane>> {
cache.keySet().removeIf(t -> !set.contains(t));
}
List<Region> newShown;
// Use copy to prevent concurrent modifications and to not synchronize to long
List<T> shownCopy;
synchronized (shown) {
newShown = shown.stream().map(v -> {
if (!cache.containsKey(v)) {
var comp = compFunction.apply(v);
if (comp != null) {
var r = comp.createRegion();
if (visibilityControl) {
r.setVisible(false);
}
cache.put(v, r);
} else {
cache.put(v, null);
}
}
return cache.get(v);
}).filter(region -> region != null).toList();
shownCopy = new ArrayList<>(shown);
}
List<Region> newShown = shownCopy.stream().map(v -> {
if (!cache.containsKey(v)) {
var comp = compFunction.apply(v);
if (comp != null) {
var r = comp.createRegion();
if (visibilityControl) {
r.setVisible(false);
}
cache.put(v, r);
} else {
cache.put(v, null);
}
}
return cache.get(v);
}).filter(region -> region != null).toList();
if (listView.getChildren().equals(newShown)) {
return;