mirror/zoneminder
1
0
Fork 0
mirror of https://github.com/ZoneMinder/zoneminder.git synced 2026-03-27 18:23:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: use errno instead of getsockopt return value for strerror

Browse Source 
getsockopt() returns -1 on error, not an errno value. The actual error
code is stored in errno. Using strerror(retval) with retval=-1 gives
incorrect error messages.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Isaac Connor
2026-02-02 20:56:04 -05:00
parent 2f14c6559a
commit 4e0476603a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/zm_remote_camera_http.cpp
View File

@@ -231,7 +231,7 @@ int RemoteCameraHttp::ReadData(Buffer &buffer, unsigned int bytes_expected) {
socklen_t len = sizeof(error);
int retval = getsockopt(sd, SOL_SOCKET, SO_ERROR, &error, &len);
if (retval != 0) {
Debug(1, "error getting socket error code %s", strerror(retval));
Debug(1, "error getting socket error code %s", strerror(errno));
}
if (error != 0) {
return -1;
@@ -263,7 +263,7 @@ int RemoteCameraHttp::ReadData(Buffer &buffer, unsigned int bytes_expected) {
socklen_t len = sizeof(error);
int retval = getsockopt(sd, SOL_SOCKET, SO_ERROR, &error, &len);
if (retval != 0) {
Debug(1, "error getting socket error code %s", strerror(retval));
Debug(1, "error getting socket error code %s", strerror(errno));
}
if (error != 0) {
return -1;