Commit Graph

26350 Commits

Author SHA1 Message Date
Isaac Connor
55e40edb8a Merge remote-tracking branch 'upstream/copilot/fix-onvif-event-subscription' into copilot_fix-onvif-event-subscription 2025-12-19 09:57:31 -05:00
Isaac Connor
46669166eb Merge branch 'master' of github.com:ZoneMinder/zoneminder 2025-12-19 09:55:54 -05:00
Isaac Connor
6d3b7ddebc Add ZM_WEB_ID_ON_FILTER to optionally remove the Id from the dropdown 2025-12-19 09:55:43 -05:00
copilot-swe-agent[bot]
b71bc6a36b Restore ONVIF implementation with Logger API and type fixes
This commit restores the complete ONVIF implementation that was accidentally
removed in commits 324e4c0 and b1fbc8c, and applies the necessary fixes from
those commits:

1. Replace config.log_level with Logger::fetch()->level() >= Logger::DEBUG3
   at three locations to use the proper ZoneMinder Logger API
2. Fix parse_event_message parameter type from struct _wsnt__NotificationMessage*
   to wsnt__NotificationMessageHolderType* to match the actual type passed

All 824 lines of the ONVIF implementation are now restored with the correct
Logger API usage and proper type signatures.

Co-authored-by: connortechnology <925519+connortechnology@users.noreply.github.com>
2025-12-19 14:47:35 +00:00
Isaac Connor
fbde89c33e Merge pull request #4492 from Simpler1/patch-3
Fix(Filter): Handle events with multiple tags
2025-12-19 09:46:09 -05:00
Simpler1
adf3eb2381 Fix(Filter): Handle events with multiple tags
Fixes an error that occurred when running a named filter that returned events that contained more than one tag.

Subquery returns more than 1 row
2025-12-19 09:32:19 -05:00
Isaac Connor
b1fbc8c097 Fix type mismatch in parse_event_message function signature
Change parameter type from struct _wsnt__NotificationMessage* to 
wsnt__NotificationMessageHolderType* to match the actual type being 
passed from the loop that iterates over 
tev__PullMessagesResponse.wsnt__NotificationMessage.
2025-12-18 14:09:55 -05:00
Isaac Connor
324e4c0e1f Fix ONVIF debug logging to use proper ZoneMinder Logger API
Replace config.log_level >= 3 with Logger::fetch()->level() >= Logger::DEBUG3 at three locations (lines 205, 236, 351) to use the proper ZoneMinder Logger API instead of the non-existent config.log_level variable.
2025-12-18 14:02:32 -05:00
copilot-swe-agent[bot]
0c120deeed Add named constants for magic numbers
Co-authored-by: connortechnology <925519+connortechnology@users.noreply.github.com>
2025-12-18 17:28:48 +00:00
copilot-swe-agent[bot]
b1b2932238 Remove unused log_soap_request_response placeholder function
Co-authored-by: connortechnology <925519+connortechnology@users.noreply.github.com>
2025-12-18 17:27:21 +00:00
copilot-swe-agent[bot]
539119e3f1 Fix code review issues: safe parsing, exact string matching
Co-authored-by: connortechnology <925519+connortechnology@users.noreply.github.com>
2025-12-18 17:25:40 +00:00
copilot-swe-agent[bot]
74414ddecc Add retry logic with exponential backoff
Co-authored-by: connortechnology <925519+connortechnology@users.noreply.github.com>
2025-12-18 17:23:39 +00:00
copilot-swe-agent[bot]
f79bc2b895 Add configurable timeout values via onvif_options
Co-authored-by: connortechnology <925519+connortechnology@users.noreply.github.com>
2025-12-18 17:21:15 +00:00
copilot-swe-agent[bot]
6ff51d88b2 Fix wildcard matching logic and add clarifying comment
Co-authored-by: connortechnology <925519+connortechnology@users.noreply.github.com>
2025-12-18 17:18:52 +00:00
copilot-swe-agent[bot]
3f64956449 Implement flexible message parsing, auth fallback, and improved WS-Addressing
Co-authored-by: connortechnology <925519+connortechnology@users.noreply.github.com>
2025-12-18 17:16:30 +00:00
copilot-swe-agent[bot]
8e097a7efe Initial plan 2025-12-18 17:07:03 +00:00
Isaac Connor
641e785f4c Add Path, with sanitization to telemetry 2025-12-17 18:52:26 -05:00
Isaac Connor
2d75e7cafd Only report non-deleted monitors 2025-12-17 17:00:45 -05:00
Isaac Connor
d997084131 Bump to 1.37.75 for creation of Index on Monitor_Status UpdatedOn 2025-12-17 14:22:30 -05:00
Isaac Connor
0d2e3a1f60 Merge branch 'master' of github.com:ZoneMinder/zoneminder 2025-12-16 12:23:46 -05:00
Isaac Connor
026db9e9ca Fix js error when custom layout. Fixes #4483 2025-12-16 12:23:41 -05:00
Isaac Connor
23bb062ba2 Add index on UpdatedOn column of Monitor_Status table 2025-12-16 11:15:40 -05:00
Isaac Connor
1c3f982c82 Merge pull request #4485 from ZoneMinder/dependabot/github_actions/actions/download-artifact-7
Bump actions/download-artifact from 6 to 7
2025-12-15 13:41:13 -05:00
Isaac Connor
47a4f09ed2 Merge pull request #4484 from ZoneMinder/dependabot/github_actions/actions/upload-artifact-6
Bump actions/upload-artifact from 5 to 6
2025-12-15 13:40:54 -05:00
dependabot[bot]
229ad47c7d Bump actions/download-artifact from 6 to 7
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 6 to 7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v6...v7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-12-15 17:02:36 +00:00
dependabot[bot]
e9dcea78e2 Bump actions/upload-artifact from 5 to 6
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v5...v6)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-12-15 17:02:30 +00:00
Isaac Connor
13999ab2a3 Unsupported control messages can be debug level. Remove some cruft. 2025-12-15 09:53:34 -05:00
Isaac Connor
ae3e8a86b9 Fix initial status update 2025-12-14 12:43:27 -05:00
Isaac Connor
9699334780 BUmp version to 1.37.74 for triggers update 2025-12-11 18:31:30 -05:00
Isaac Connor
a59f13b9ea Apply new triggers that only update summary tables if there is a DiskSpace change. 2025-12-11 18:31:30 -05:00
Isaac Connor
b0c46387b8 Merge pull request #4482 from Simpler1/patch-2
Update skin.css
2025-12-11 12:36:57 -05:00
Simpler1
f97a69cf43 Update skin.css
Better experience on mobile with a narrow display.  Keeps the tags field from jumping from a single line to two lines after entering a tag.
2025-12-11 11:58:47 -05:00
Isaac Connor
46e9991272 Merge pull request #4481 from IgorA100/patch-173721
Fix: Allow using any character from the "letter" category in the name of the downloaded event archive on Events page
2025-12-11 09:00:54 -05:00
Isaac Connor
8acb9be4b5 Merge pull request #4480 from IgorA100/patch-545508
Fix: With "bfcache," always refresh the page without analyzing the content height.
2025-12-11 09:00:02 -05:00
IgorA100
0020d29c89 Removed the ":" character from allowed characters (event.php) 2025-12-11 12:39:18 +03:00
IgorA100
b1f65aaabc Fix: Allow using any character from the "letter" category in the name of the downloaded event archive (event.php)
This change will allow the use of any national Unicode alphabet in the file name.
We also allow any numeric character and the characters "-", ".", "(", ")"
The ":" character is prohibited in file names in Windows, so we're excluding it from the list of allowed characters.
2025-12-11 12:15:11 +03:00
IgorA100
0e91388d16 Removed extra space (skin.js) 2025-12-11 10:35:53 +03:00
IgorA100
f2cf0dd962 Fix: With "bfcache," always refresh the page without analyzing the content height. (skin.js)
Because in addition to Firefox, the problem occurs on some Linux (Chromium) and Android (Chrome) devices.
2025-12-11 10:24:49 +03:00
Isaac Connor
f0daaaba5f Merge pull request #4477 from Simpler1/lint
chore(skin.css): lint
2025-12-10 08:40:00 -05:00
Isaac Connor
e1f0435c77 Merge pull request #4478 from IgorA100/patch-719705
Fix: The table row denoting "catalog" should occupy the entire width of the table on Files page
2025-12-10 08:38:57 -05:00
Isaac Connor
5661572d52 Merge pull request #4479 from IgorA100/patch-140429
Fix: "Toolbar" styling on the Files page
2025-12-10 08:38:05 -05:00
IgorA100
96c4ed3a25 Drag the "Delete" button to the right side (files.php) 2025-12-10 14:45:08 +03:00
IgorA100
30ad5d7294 Добавил стиль для ".path" (files.css) 2025-12-10 14:42:03 +03:00
IgorA100
5454bdfd53 Added a class that allows you to align an element inside a FLEX container to the right side. (skin.css) 2025-12-10 14:14:35 +03:00
IgorA100
0a62bac040 Fix: The table row denoting "catalog" should occupy the entire width of the table(files.php) 2025-12-10 13:28:56 +03:00
Isaac Connor
24cdd2dfaf Fix eslint 2025-12-09 08:59:11 -05:00
Isaac Connor
04998f8900 We actually want stop. Pause does buffering. 2025-12-09 08:58:50 -05:00
Simpler1
d25db1f448 chore(filter.js): Lint 2025-12-08 21:16:18 -05:00
Simpler1
285841404a chore(skin.css): lint 2025-12-08 21:09:04 -05:00
Isaac Connor
c325610aba Change structure of availableTags to be an array of objects so that we don't lose sorting. Sort alphabetically. Use json_decode instead of explode, but use isset instead of empty since empty('0') == true 2025-12-08 17:46:46 -05:00