Commit Graph

7190 Commits

Author SHA1 Message Date
polybjorn
bdf02e638a fix(theme): hide Swage logo in reader view to prevent overlap (#8842)
Reader view sets .aside.visible { padding-top: 0 } (swage.css:1236), so when
the sidebar is open the absolute-positioned logo lands on the Subscription
management button. Extending the existing hide rule from #8739 to also
cover body.reader is the smallest fix; the logo isn't load-bearing in
reader view. Closes #8802.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-15 14:29:29 +02:00
Christian Weiske
d017e22a46 i18n(de): Add missing translations (#8840)
Related: https://github.com/FreshRSS/FreshRSS/issues/8839
2026-05-15 13:31:45 +02:00
Alexandre Alapetite
146d5f0d60 Fix ensure maximum number of feeds also with Dynamic OPML (#8832)
Fix https://github.com/FreshRSS/FreshRSS/issues/8822
And also add a warning sign in case of error.
Fix related bug about showing errored categories.
2026-05-15 12:19:40 +02:00
Alexandre Alapetite
1ac1d8c2eb Fix LibOPML warnings (#8652)
* Fix LibOPML warnings
Fix https://github.com/FreshRSS/FreshRSS/issues/8651
Apply the same flags than in other similar calls of FreshRSS
Will need to send the patch upstream.

* No LIBXML_NOERROR due to unit tests expecting a catch

* LIBXML_NOERROR while waiting for better upstream fix

* lib_opml fix loadXML warnings
fix https://github.com/FreshRSS/FreshRSS/issues/8651
Upstream PR https://framagit.org/marienfressinaud/lib_opml/-/merge_requests/48

* Fix regression
https://framagit.org/marienfressinaud/lib_opml/-/merge_requests/51

* Temporarily use fork
2026-05-15 12:12:28 +02:00
Alexandre Alapetite
66568f0283 TXT import compatibility HTML comments (#8837)
Discard lines starting with `<` for e.g. HTML/XML comments, tags
Compatibility with TXT format of https://atlasflux.saynete.net
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/8818
2026-05-15 12:10:55 +02:00
Yixuan Xu
9a28f617ec Keep mobile article navigation at the bottom (#8833)
This keeps the mobile article navigation fixed to the bottom of the viewport by clearing any inherited top offset in the small-screen rule. It updates both LTR and RTL base theme CSS so the previous/next bar remains anchored while browsing on mobile Safari.

Verification: targeted CSS assertion for both base theme files; `git diff --check`.

Closes #8829

Co-authored-by: mzl2233 <mzl2233@users.noreply.github.com>
2026-05-15 12:09:30 +02:00
polybjorn
98eaed796b revert(themes): hide feed name at narrow viewports (#8838)
Reverts #8801 (keeping its incidental blank-line cleanups) and #8815, restoring icon-only feed column on mobile (#8814).

I filed the original PR thinking the icon-only behavior was an inconsistency bug versus the configurable `topline_website` setting, not realizing it was a deliberate mobile choice. The `clamp()` cap helped, but the column still takes space the title could use, and on phones icon-only is the better tradeoff.

A distinct narrow-viewport setting for `topline_website` was raised as a future improvement.

* Revert "fix(themes): cap website column at narrow when feed name is shown (#8815)"

This reverts commit af6a500638.

* Revert "fix(themes): show feed name at narrow widths when configured (#8801)"

This reverts commit 9ff4aec368.

---------

Co-authored-by: FreshRSS Pi <freshrss-pi@localhost>
2026-05-15 12:06:47 +02:00
polybjorn
6946b217b2 docs: sync French README content with English (#8831)
* docs: add missing app rows to French README

Sync mobile and desktop tables with English README:
add FeedFlow and FluentFlame Reader, previously missing from
the French translation.

* fix(docs): correct Fluent Reader API in French README

Align with English README: Fluent Reader supports the Google Reader
API (preferred), not Fever. The app upstream documents both, and the
English table has long listed GReader.

---------

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-14 16:02:40 +02:00
polybjorn
3feb7aeaed docs: normalize APIs & native apps table glyphs to monochrome (#8821)
* docs: normalize APIs & native apps table glyphs to monochrome

* docs: use en-dash instead of ✗ for "no" in APIs & native apps table

Per maintainer feedback on #8821: ✗ reads as an error/failure mark; an
en-dash is a neutral "not applicable / no" glyph more appropriate for
a feature-matrix table.

* docs: normalize APIs & native apps table glyphs in French README

Mirror the monochrome-glyph substitutions from README.md:
`✔️` -> `✓`, `` -> `–`, `` -> `?`, `💲` -> `$`.

---------

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-14 15:07:18 +02:00
Alexandre Alapetite
3a696929b7 Fix click mark as read (#8817)
Fix https://github.com/FreshRSS/FreshRSS/issues/8806
Regression from https://github.com/FreshRSS/FreshRSS/pull/8553
Apply same logic to onmouseup than onauxclick.
2026-05-14 13:00:45 +02:00
Frans de Jonge
fcc129fe54 Reduce sidebar animation duration from 200ms to 100ms (#8830)
#8747 (re?)introduced an animation I find unbearably slow. If it was always there I suppose I just got used to it.

How to test the feature manually:

1. Open and close the sidebar on a sufficiently small width.
2026-05-14 12:55:33 +02:00
polybjorn
8863cdcaf8 feat(import): accept .txt URL lists alongside OPML/JSON/ZIP (#8818)
* feat(import): accept .txt URL lists alongside OPML/JSON/ZIP

Detects .txt by extension and wraps the URL list into a minimal OPML
document so the existing import pipeline handles dedup, categories and
feed limits unchanged. Blank lines, `#` comments and a UTF-8 BOM are
skipped; lines that don't parse as URLs are logged and dropped without
aborting the batch.

Works through both `cli/import-for-user.php` and the web import form.

* utf8BOM

* ENT_COMPAT

---------

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2026-05-12 10:52:00 +02:00
polybjorn
d74337deb6 feat(cli): automatic periodic SQLite export with retention (#8819)
Add an opt-in CLI that exports each user's database to
`data/users/<user>/sqlite-backups/<YYYYMMDDTHHMMSSZ>.sqlite` (UTC) and
prunes older files to a configured count. Gated by two new settings,
`auto_sqlite_export.enabled` and `auto_sqlite_export.retention`.

Kept separate from `cli/db-backup.php` / `cli/db-restore.php`, which
stay the fixed-filename migration tool. First step of #8183.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-12 08:44:00 +02:00
polybjorn
557e190a40 docs: add FeedFlow and FluentFlame Reader to APIs & native apps (#8820)
Adds two requested clients to the APIs & native apps tables: FeedFlow (mobile, table 1) and FluentFlame Reader (desktop, table 2).

Both rows go at the bottom of their tables to avoid implying a recommendation order, since [an earlier comment](https://github.com/FreshRSS/FreshRSS/pull/8787#issuecomment-4373379000) noted the top reflects recommended apps.

Columns come from each project's README. Cells not documented upstream are left as ``, same as Vienna RSS, lire, and Fiery Feeds.

FluentFlame Reader is marked `Work in progress` because its [README](https://github.com/FluentFlame/fluentflame-reader#download) states "Currently we do not have any stable version!". Same handling as the Netnewswire row.

FeedFlow's sync-spam issue was fixed upstream in [feed-flow#425](https://github.com/prof18/feed-flow/issues/425), closed 2025-02-06 with commit [`a6b6e4c`](a6b6e4ce76). 15 months and 14 releases since, no re-report.

Potentially closes #7301, #8608

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-12 08:41:12 +02:00
polybjorn
bcf8045b2b fix(theme): inherit font-family on form controls (#8816)
Browsers don't inherit font-family on button, input, select, textarea by
default, so the rule on html, body in frss.css didn't reach the "Mark as
read" button or the search input. Add an inherit rule so all themes
extending base-theme pick up their configured font.

Reported and tested by @JerryCrazy.

Fixes FreshRSS/FreshRSS#8803

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-11 21:13:57 +02:00
polybjorn
769c87cef1 chore(themes): remove loader.gif and convert remaining consumers to the CSS spinner (#8812)
#button-update-loading and the generic .loading class (used by
#first_load) painted loader.gif as a background. Both now use the
#load_more.loading::after border-rotation spinner from #8804. The
unused #slider-content .loader rule is also removed. Drops the
--frss-loading-image variable, all twelve loader.gif files, and
references in the theme contribution docs.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-11 20:23:20 +02:00
polybjorn
43b10f1d70 fix(themes): use has-date class for date-aware list layout (#8811)
Replace four :has(~.date) selectors with a has-date modifier class
on .flux_header, mirroring the existing has-thumbnail and has-summary
classes. The condition (whether the date is rendered) is known
server-side and can be exposed on the parent <ul> directly. Same
elements matched in modern browsers. The rules now also apply in
browsers without :has() support, fixing the date column overlapping
the title in SeaMonkey (#6776).

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-11 20:20:46 +02:00
polybjorn
1020652787 refactor(themes): drop redundant :has() in dropdown label selector (#8813)
The :has(input[type="checkbox"]) check is redundant. Every <label>
inside .dropdown-menu .item already has a checkbox child (constructed
in main.js), so the selector matches the same set as :not(.noHover)
alone. Removing it makes the rule work in browsers without :has()
support (#6776).

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-11 20:19:49 +02:00
polybjorn
af6a500638 fix(themes): cap website column at narrow when feed name is shown (#8815)
#8801 dropped the unconditional 40px cap on .item.website at narrow widths so users with topline_website set to name/full would actually see the feed name on mobile. With the default 'full' mode, the column then inherited the 200px wide-width default, squashing the article title (#8814).

Re-introduce a cap for the name-bearing modes: max-width 30vw with width auto, so the favicon and name shrink to fit the viewport without overrunning the title cell.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-11 20:14:42 +02:00
polybjorn
1ff27fea21 fix(themes): replace #load_more loading-state GIF with a CSS spinner (#8804)
* fix(themes): replace #load_more loading-state GIF with a CSS spinner

In its `.loading` state, the "Load more" button kept its `.btn` frame and the spinner inside was hard to see or invisible across themes. Replaces the GIF with a base-theme CSS spinner inheriting `currentColor`, drops the button frame, respects `prefers-reduced-motion`, and renders crisply at any DPI. Per-theme `#load_more.loading` overrides in Nord, Flat, Mapco, Ansum and Swage become redundant and are removed; a now-redundant `font-size: 0` rule in `base.css` is also dropped.

* fix(themes): use border-rotation spinner for older-browser compat

Replaces conic-gradient + mask + aspect-ratio (Firefox 83+, Safari 15.4+) with border + rotate, supported in Gecko since Firefox 16 (2012) and Blink/WebKit since 2015. Visual difference: a ring with a rotating gap instead of a tapered arc. currentColor inheritance and prefers-reduced-motion handling are preserved.

* fix(themes): regenerate RTL spinner stylesheet

rtlcss flips border-right-color to border-left-color for RTL; the manual port of the spinner block missed it. Regenerated via npm run rtlcss.

Reworked the spinner with border + rotate instead of conic-gradient + mask + aspect-ratio. 

<img width="35" height="36" alt="Screenshot 2026-05-11 at 11 05 43" src="https://github.com/user-attachments/assets/e065efc9-9d6c-4369-8390-f0e89db81952" />

Oldest browser versions still supported: Firefox 16 (2012), SeaMonkey 2.13 (2012), Chrome 43 (2015), Safari 9 (2015), Edge 12 (2015). Below those, `@keyframes` and `animation` would need `-webkit-` fallbacks.

Verified now working in SeaMonkey 2.53.23. Couldn't test feed clicks or page reload there because login itself hits a separate cookie issue.
---------

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-11 16:30:08 +02:00
polybjorn
408419f433 refactor(themes): drop redundant multiline class on title (#8810)
The multiline class on the title <a> existed only so the parent <li>
could detect it via :has(.multiline). The condition (thumbnail or
summary enabled) is already exposed on the parent <ul> by the
has-thumbnail and has-summary classes, so keying the rule on those
directly removes the indirection. Same elements matched in modern
browsers. The rule now also applies where :has() isn't supported,
relevant to #6776.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-11 16:12:20 +02:00
polybjorn
1936306277 chore(themes): rename "Nord theme" to "Nord" (#8805)
Rename the Nord theme display name from "Nord theme" to "Nord". The upstream Nord palette project at https://www.nordtheme.com refers to itself consistently as "Nord" throughout its branding; the "theme" suffix is redundant. The rename also matches the other entries in the theme picker (Ansum, Dark, Mapco, Pafat, Swage), which all use a single short name.

The theme directory, file paths, and CSS class names are unchanged. Only the user-facing display name in the theme picker (and the corresponding rows in the user docs) is affected.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-11 00:16:28 +02:00
polybjorn
9ff4aec368 fix(themes): show feed name at narrow widths when configured (#8801)
Two narrow @media rules in base-theme/frss.css predate the configurable topline_website modes from #4969 and force icon-only behavior regardless of the user's Website setting; #8631 partially papered over this for grid-layout entries. Drop the unconditional span-hide and its grid-layout exception, and scope the 40px width cap to .websiteicon (with a comment explaining why it stays at narrow).

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-10 16:48:42 +02:00
polybjorn
b83c8b445e fix(themes): drop topline_website value from <li> class to avoid filter collision (#8800)
When topline_website is "icon", the <li> renders class="item website
icon". Bare .icon rules in Nord and Dark apply a filter that cascades
onto the favicon <img> inside, so article-list favicons render tinted
in icon-only mode. No theme CSS targets the unprefixed value; layout
modes are driven from the parent <ul> (.websiteicon, .websitename).

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-10 16:47:46 +02:00
Alexandre Alapetite
cb04c6cfaa More feed info: last received date, publication date (#8799)
* More feed info: last received date, publication date
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/8670

* Fix <br />

* Change i18n English
2026-05-10 16:47:24 +02:00
Alexandre Alapetite
cedf339330 Start 1.29.1 2026-05-10 16:46:40 +02:00
Alexandre Alapetite
9a50be1a6d Credits 1.29.0 2026-05-10 16:28:43 +02:00
Alexandre Alapetite
376ce66da8 Release 1.29.0 2026-05-10 16:04:07 +02:00
dependabot[bot]
f7d39cd6cb chore(deps): bump fast-uri from 3.1.0 to 3.1.2 (#8798)
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.0 to 3.1.2.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](https://github.com/fastify/fast-uri/compare/v3.1.0...v3.1.2)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-09 08:45:33 +02:00
Alexandre Alapetite
68506204c4 Changelog 2026-05-08 10:07:39 +02:00
Alexandre Alapetite
c2619d9a26 Fix search in shared user queries (#8789)
The internal search was shown in the UI as the user search.
This was due to the lazy nature of the Generator. Improve the try/catch behaviour at the same time.

How to test:
* Make a user query with a search parameter
* Share the user query as HTML
* Observe the search field (should be empty with this PR,  while it contained the internal search before)
2026-05-08 09:05:55 +02:00
Alexandre Alapetite
bbb28b5eda Fix reauth with legacy cookie (#8778)
Fix https://github.com/FreshRSS/FreshRSS/issues/8486
Fix https://github.com/FreshRSS/FreshRSS/issues/8532
Restore some legacy code from https://github.com/FreshRSS/FreshRSS/pull/8447

How to test:
* Start with FreshRSS 1.28.1
* Update to edge
* Access user management

Co-authored-by: Copilot <copilot@github.com>
2026-05-08 09:05:32 +02:00
Alexandre Alapetite
a1c637e7ac Preventive measure against search ingestion (#8777)
We were not vulnerable to it, but here is an additional layer of security against search ingestions, in particular in public user queries, where someone could try to ingest a search like `) OR (interesting`
2026-05-08 09:04:57 +02:00
Alexandre Alapetite
d03efaed6b Changelog 2026-05-08 09:01:46 +02:00
polybjorn
0c93b26cb5 feat(import): support category field in JSON feed import (#8786)
* Extension to JSON imports: interpret
      "origin": {
        "category": "..."
      },
as category for FreshRSS. When importing a new feed configure the feed
into this category. Creates missiong categories on the fly.

* Fix syntax

* fix(import): tighten JSON category import follow-ups

- Use strict comparison `!== false` after `addCategory()` so a (theoretical)
  zero return from auto-increment is not silently treated as failure
  (matches review feedback on #5638).
- Modernise property declaration to typed property syntax, matching the
  surrounding `$entryDAO`/`$feedDAO` style.
- Pass `$username` to `createCategoryDao()` in `importFile()` so CLI
  imports for a non-current user create categories on the right account,
  matching the adjacent entry/feed DAO instantiations.
- Trim the requested category name and skip if it is empty after trim,
  so a whitespace-only `"category"` value falls back to the default
  category instead of creating a junk row with an empty name. Also
  normalises trailing/leading whitespace so `"  Tech News  "` reuses an
  existing `"Tech News"` category.

* Update app/Controllers/importExportController.php

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

---------

Co-authored-by: Robert Dahlem <robert.dahlem@gmx.net>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-04 15:02:03 +02:00
Michael
92e34aec6d i18n(de): Improve German translations (#8704)
* i18n(de): improve German translations

- Fix orthography and grammar (e.g. Authentifizierung→Authentifizierung, Kategory→Kategorie)
- Replace anglicisms with German terms (Hashtags→Tags, Icon→Symbol, Layout→Theme where appropriate)
- Improve clarity and naturalness (e.g. Archivierungsausnahmen→Bereinigungsausnahme, Trägheit→Lazy Load)
- Complete TODO translations (send_referrer_allowlist, when_same_guid_in_category, keep_adding_feed)
- Fix typos (Artikle→Artikel, EAls→Als, Aals→Als)
- Use consistent terminology (Account→Konto, Nutzername→Benutzername, Webseite→Website)

* i18n(de): revert Account→Konto, Nutzername→Benutzername, Icon→Symbol

Keep 'Account' (Konto too bank-like), 'Nutzername' (Nutzer preferred
over Benutzer), and 'Icon' (Symbol sounds dated).

---------

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2026-05-04 12:45:59 +02:00
polybjorn
4d2b5fb883 fix(themes): swap header item border to inset box-shadow (#8784)
Alt-Dark, Dark, Origine, and Pafat use `border-bottom: 1px solid` on
`.header > .item`, making their wide-view header 57px tall (56px
content + 1px border). Other shipped themes have no such border and
render at 56px.

Replace `border-bottom` with `box-shadow: inset 0 -1px 0`. Visually
identical (same colour, same position at the bottom of each header
cell), but the shadow doesn't add to the box height. Wide-view
header outerHeight becomes 56px across themes, which lets the
shared `--height-header: 56px` token introduced in #8783 produce
pixel-perfect alignment between the wide header and the narrow
drawer X button. Without this PR, those four themes carry a 1px
residual offset under #8783's alignment fix.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-04 12:45:14 +02:00
polybjorn
3f134bce88 fix(themes): scope Mapco and Ansum aside transition to width (#8785)
Mapco and Ansum apply `transition: all 0.2s ease-in-out` to `.aside`
in their narrow `@media`. When the viewport crosses 840px with the
sidebar open, the resulting `.aside` position change (`static` to
`fixed`) gets animated alongside width, producing a visible artefact
where the X button slides down then scrolls back up before settling.

Limit the transition to the property that should actually animate
(`width`), matching base-theme's existing
`transition: width 200ms linear`.

The artefact only manifests when the drawer stays open across the
840px boundary, which is the behaviour introduced by #8775. On current
edge, `init_nav_menu`'s `media.onchange` toggles the aside off when
crossing the breakpoint, hiding the bug.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-04 12:43:17 +02:00
polybjorn
944f9c886c fix(themes): remove dropdown-close backdrop in Nord wide view (#8781)
Nord was the only shipped theme applying a backdrop-filter to
.dropdown-close outside the narrow-viewport @media block, dimming the
page behind any open dropdown (Settings, mark-read menu, etc.) in wide
view.

Other themes leave the click-catcher transparent in wide view and only
apply a scrim in narrow view, where it doubles as the visual backdrop
for the slide-out aside. The wide-view darken in Nord read as
inconsistent against its own narrow-view treatment (grayscale + blur)
and against every other theme.

Click-outside-to-close still works; only the visual backdrop is removed.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-04 10:07:32 +02:00
Alexandre Alapetite
1d7f52e556 Changelog 2026-05-03 19:19:40 +02:00
polybjorn
2787014bde fix(layout): reserve logo image box via intrinsic dimensions (#8774)
* fix(layout): reserve logo image box via intrinsic dimensions

Add the SVG's intrinsic 1280x256 dimensions to the default
<img class="logo"> in header.phtml and simple.phtml. The
browser uses these to allocate a correctly-proportioned box
from HTML parse time, before CSS is applied; without them, a
cached image can render at native size for a frame on fast
back-to-back navigation. CSS still controls the rendered
height (2rem wide, 24px narrow); width auto-derives from the
intrinsic ratio.

* fix(layout): use rendered logo size for img dimensions

1280 × 256 (the SVG's intrinsic size) replicates the unstyled-frame
flash this PR aims to prevent. 160 × 32 has the same 5:1 ratio and
matches the CSS-rendered size, so the reserved box is correct both
before and after CSS applies.

---------

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-03 14:23:02 +02:00
Umaid Shahid
52be56ada7 feat(admin): visually dim disabled users in user management table (#8768)
Closes #8765 

Changes proposed in this pull request:

- Add disabled-user CSS class to user rows in the management table when the account is disabled
- Add .disabled-user { opacity: 0.5; } style to base theme to visually dim disabled accounts
- Add entry to CREDITS.md

How to test the feature manually:

1. Go to Administration → User Management
2. Have at least one disabled user account in the list
3. Verify that disabled user rows appear dimmed (50% opacity) compared to active users, without any change in functionality
2026-05-03 14:18:26 +02:00
polybjorn
4b96b01460 chore(docs): upgrade Jekyll 3 to 4 and Ruby to 3.4.9 (#8772)
Jekyll 3 is unmaintained and its safe_yaml dependency breaks on
Ruby 3.4+ where base64 left the default stdlib. The docs workflow
already runs `bundle exec jekyll build` directly, so GitHub Pages'
Jekyll 3 lock does not apply here.

Changes:

* Pin `jekyll ~> 4.3`. Replace `jekyll-commonmark-ghpages` (pinned
  to Jekyll 3) with upstream `jekyll-commonmark`. Drop unused
  `jekyll-paginate`. Add `gem 'base64'` so the lockfile stays valid
  on Ruby 3.4+ where it became a bundled gem.
* Move CommonMark options into `_config.yml` to match what the
  `-ghpages` variant enabled by default: SMART, FOOTNOTES, UNSAFE
  (so inline HTML like `<br>` in tables still renders), plus the
  strikethrough, autolink, table, and tagfilter extensions. Set
  Rouge as the highlighter.
* Strip the leading slash from `defaults.scope.path` (`/en/*` to
  `en`). Jekyll 4 requires no leading slash, otherwise `page.lang`
  silently fails to propagate and `jekyll-i18n_tags` crashes the
  build.
* Pass `generateId=true` to the existing `anchor_headings.html`
  include so headings get slugified IDs. The `-ghpages` variant
  produced these by default.
* Bump CI Ruby to 3.4.9 and `cache-version` to invalidate the old
  Jekyll 3 gem cache on the first run.

Build is about 9x faster (1.0s vs 9.2s). Compared the rendered
output page by page against the Jekyll 3 baseline; remaining
differences are whitespace, footnote class names (no CSS depends
on either set), and one HTML entity (`&#8617;`) becoming the
literal `↩`. Visually and functionally the same.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-03 14:17:55 +02:00
polybjorn
c43930cfd1 fix(js): stop sidebar auto-reopening on page navigation (#8773)
After #8747 the sidebar would re-open on its own when navigating
(e.g. clicking the logo) on sessions where sessionStorage said
the sidebar should be closed.

init_nav_menu() ran toggle_aside_click() to honour the stored
state, then gated a follow-up `.visible` re-add on
`getComputedStyle(aside).display !== 'none'`. Before #8747 that
gate worked because the close path set `aside.style.display =
'none'` inline; #8747 replaced that with an `is-hidden` class
applied only at wide viewports, so at narrow viewports the
computed display stays `table-cell` after closing and the gate
wrongly re-adds `.visible`, sliding the drawer open.

Gate on the toggle button's `.active` state instead. It's the
real source of truth for "should the sidebar be open" and is
already used elsewhere in the same function.

Fixes #8771

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-03 14:16:33 +02:00
polybjorn
3a7431ce04 fix(i18n): validate language directory names against gen.lang.* keys (#8767)
Detect when an `app/i18n/<lang>/` directory has no matching `gen.lang.<lang>`
key in the reference language (or vice versa), and refuse to regenerate the
README from that invalid state.

This catches a class of silent corruption where the README translation
table renders literal i18n keys instead of localised language names. The
trigger is most often a case-folded directory on macOS APFS - git tracks
`zh-TW`, the local FS reads back `zh-tw`, the script's `_t('gen.lang.zh-tw')`
lookup misses, and the README ends up with `gen.lang.zh-tw (zh-tw)` instead
of `正體中文 (zh-TW)`. The same check also flags orphan directories (no
display-name key) and orphan keys (no directory).

The new validateLanguageNames() method on I18nData performs a bidirectional
set comparison and returns human-readable issues. cli/check.translation.php
prints them to STDERR and gates --generate-readme on the result, leaving
routine completeness validation behaviour unchanged. Adds four PHPUnit
tests covering: clean state, case mismatch, orphan directory, orphan key.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-02 23:43:19 +02:00
polybjorn
b08c4ef243 docs: standardise English heading style and surface hidden pages (#8766)
Apply sentence case to all H1s in docs/en/ and remove redundant "FreshRSS"
from titles where the docs site context already implies it. Align the three
section index titles to "Administrator/Developer/User manual", matching
the existing root H1 "FreshRSS manual (English)".

Add missing H1s to two pages that were silently dropped from the sidebar:
the user FAQ and the Caddy reverse proxy page. The sidebar template uses
page.title (derived from H1 by jekyll-titles-from-headings), so pages
without an H1 had title=nil and were skipped.

Update sidebar parent labels in docs_nav.html and the chapter list in
en/index.md to use the new "* manual" naming. Update link text in section
indexes that referenced the old H1s. Bundle two grammar fixes encountered
along the way: "an User Interface" -> "a user interface", and drop the
awkward "the" in "Configuring the email address validation".

EN only. No filenames, URLs, or anchor targets changed (anchors come from
H2 and below, which are untouched). FR is generated from EN via po4a and
will be regenerated separately.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-02 22:23:35 +02:00
Alexandre Alapetite
8f317a0c3c Fix headers given to SimplePie, e.g. for HTTP/2 (#8742)
Fix https://github.com/FreshRSS/FreshRSS/issues/8729
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/7983
Related https://github.com/simplepie/simplepie/issues/942
2026-05-02 22:09:04 +02:00
polybjorn
161e4e0f0e docs: mention db-backup.php and simplify git update steps (#8763)
* docs: mention db-backup.php and simplify git update steps

Two follow-ups from Alkarex's review of #8741.

Backup: add ./cli/db-backup.php to the "What to back up" list as a
database-agnostic alternative to mysqldump/pg_dump. It was already
documented further down the page; the top bullet just didn't point
to it.

Updating: replace the 6-step prose list in "Using git" with a command
block matching the sequence in 07_LinuxUpdate.md. Drop the top-level
"move your backup outside the directory" warning; git reset --hard
doesn't need it, the real hazard is git clean -f -d removing
untracked files, so the warning sits inline on that line. Link to
the Linux page for the sudo and permissions-helper variant.

* docs: restore backup warning, clarify git clean note

Per @Alkarex review on #8763. Reword the inline `git clean` note to
cover untracked files generally (themes, extensions, local edits) since
backups are now called out separately above.

---------

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-02 21:52:42 +02:00
polybjorn
80a93a994f refactor(themes): centralize sidebar width via --width-aside token (#8761)
## Summary

`--width-aside` already existed in `base-theme/frss.css` but only as a fallback inside the narrow-viewport rule from #8749. Desktop `.aside`, `#nav_entries`, `.reader .aside.visible`, and `.header > .item.title` hardcoded `300px` independently. This PR makes `--width-aside` the canonical token for the navigation drawer / left column width, so theme overrides apply everywhere consistently.

## Changes

`p/themes/base-theme/frss.css`:
- Define `--width-aside: 300px` in `:root`.
- `.aside`, `#nav_entries`, `.reader .aside.visible`, `.header > .item.title`: replace hardcoded `300px` with `var(--width-aside)`.
- Narrow-viewport `.aside.visible`: drop the now-redundant `320px` fallback in `min(...)`.

`p/themes/Swage/swage.css`:
- Remove the now-redundant `width: var(--width-aside)` overrides on `.aside`, `#nav_entries`, and `.header > .item.title` (inherited from base now). Swage's `--width-aside: 231px` declaration stays in place, so `#nav_entries`, the header `.title` block, and the reader-view sidebar now resolve to 231 via the token (previously stuck at 300 from base hardcodes), aligning them with Swage's other column elements.

RTL mirrors regenerated via `npm run rtlcss`.

## Why 300px

300px is the existing FreshRSS desktop sidebar value, so default themes see no visible change. The narrow-viewport cap previously used 320 as a fallback, but on actual phones the `calc(100vw - 56px)` cap dominates, so the change has near-zero practical effect on phone UX. Tablet and narrow-desktop sidebars become slightly narrower, more in line with typical desktop conventions.

## Tested

- Origine, Flat, Swage at desktop widths
- Origine and Swage at narrow viewports: sidebar slide, open, close
- Reader view in Origine and Swage
- Header title block: Swage 231, default themes 300

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-02 21:25:30 +02:00
polybjorn
3c61c84abf fix(themes): restore sidebar slide animation at narrow viewports (#8747)
The `transition: width 200ms linear` rule on `.aside` in the narrow
`@media` block stopped firing after #8201 added inline `display: none`
toggling. Browsers don't interpolate width when an element flips to or
from `display: none`, so width snaps on open and the close transition
gets cut off before any frame renders.

Replace the inline `display` toggle with an `is-hidden` class, applied
only at wide viewports. At narrow viewports the existing `width: 0;
position: fixed; overflow: hidden` already hides the element, so
`display: none` is redundant there and was the only thing blocking the
transition.

Co-authored-by: Bjørn A. Andersen <polybjorn@users.noreply.github.com>
2026-05-02 21:21:49 +02:00