docs: update ProGuard docs, build-logic guide, and agent skills

- desktop/README.md: document animation anti-merge rule, Room KMP
  package path, and cross-target rule alignment
- BUILD_LOGIC_CONVENTIONS_GUIDE.md: add PUBLISHED_MODULES and
  SHARED_COMPILER_ARGS as consolidation examples, update test config
  snippet to reflect centralized configureKotlinAndroid()
- code-review SKILL: add ProGuard/R8 checklist section
- implement-feature SKILL: add release build verification step for
  new reflection-heavy dependencies
This commit is contained in:
James Rich
2026-04-13 11:53:03 -05:00
parent 92166f0fa2
commit d89b20f684

View File

@@ -55,3 +55,9 @@ When reviewing code, meticulously verify the following categories. Flag any devi
### 8. ProGuard / R8 Rules
- [ ] **New Dependencies:** If a new reflection-heavy dependency is added (DI, serialization, JNI, ServiceLoader), verify keep rules exist in **both** `app/proguard-rules.pro` (R8) and `desktop/proguard-rules.pro` (ProGuard). The two files must stay aligned.
- [ ] **Release Smoke-Test:** For dependency or ProGuard rule changes, verify `assembleRelease` and `./gradlew :desktop:runRelease` succeed.
## Review Output Guidelines
1. **Be Specific & Constructive:** Provide exact file references and code snippets illustrating the required project pattern.
2. **Reference the Docs:** Cite `AGENTS.md` and project architecture playbooks to justify change requests (e.g., "Per AGENTS.md, `java.io.*` cannot be used in `commonMain`; please migrate to Okio").
3. **Enforce Build Health:** Remind authors to run `./gradlew test allTests` locally to verify changes, especially since KMP `test` tasks are ambiguous.
4. **Praise Good Patterns:** Acknowledge correct usage of complex architecture requirements, like proper Navigation 3 scene transitions or elegant `commonMain` helper extractions.