Remove addon sync error toast

Fix an issue with incorrectly detecting classic error when manually selecting it.

wowup-electron/package.json

@@ -1,7 +1,7 @@
 {
   "name": "wowup",
   "productName": "WowUp",
-  "version": "2.3.0-beta.5",
+  "version": "2.3.0-beta.6",
   "description": "World of Warcraft addon updater",
   "homepage": "https://wowup.io",
   "author": {

wowup-electron/src/app/addon-providers/addon-provider.ts

@@ -63,15 +63,6 @@ export abstract class AddonProvider {
     return Promise.resolve([]);
   }
 
-  public searchByName(
-    addonName: string,
-    folderName: string,
-    installation: WowInstallation,
-    nameOverride?: string
-  ): Promise<AddonSearchResult[]> {
-    return Promise.resolve([]);
-  }
-
   public getById(addonId: string, installation: WowInstallation): Observable<AddonSearchResult> {
     return of(undefined);
   }

wowup-electron/src/app/app.component.ts

@@ -355,12 +355,14 @@ export class AppComponent implements OnInit, OnDestroy, AfterViewInit {
         reset,
       });
     } else if (
-      error.innerError instanceof GitHubFetchRepositoryError ||
-      error.innerError instanceof GitHubFetchReleasesError
+      error.innerError instanceof GitHubFetchReleasesError ||
+      error.innerError instanceof GitHubFetchRepositoryError
     ) {
       errorMessage = this.translate.instant("COMMON.ERRORS.GITHUB_REPOSITORY_FETCH_ERROR", {
         addonName: error.addonName,
       });
+    } else if (error instanceof AddonSyncError) {
+      return;
     }
 
     this._snackbarService.showErrorSnackbar(errorMessage);

wowup-electron/src/app/services/warcraft/warcraft-installation.service.ts

@@ -167,8 +167,7 @@ export class WarcraftInstallationService {
   }
 
   public async createWowInstallationForPath(applicationPath: string): Promise<WowInstallation> {
-    const binaryName = path.basename(applicationPath);
-    const clientType = this._warcraftService.getClientTypeForBinary(binaryName);
+    const clientType = this._warcraftService.getClientTypeForBinary(applicationPath);
     const typeName = getEnumName(WowClientType, clientType);
     const currentInstallations = this.getWowInstallationsByClientType(clientType);