mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-07-30 09:16:07 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3065 from lightpanda-io/remove-sendMessageToTarget-assertion

Browse Source 
crash: remove Target.sendMessageToTarget session_id assertion
This commit is contained in:
Karl Seguin
2026-07-28 09:23:51 +08:00
committed by GitHub
parent f02d73e978 708835b08b
commit 5fe387a46a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/cdp/domains/target.zig
View File

@@ -366,8 +366,8 @@ fn sendMessageToTarget(cmd: *CDP.Command) !void {
return error.TargetNotLoaded;
}
lp.assert(bc.session_id != null, "CDP.target.sendMessageToTarget null session_id", .{});
if (std.mem.eql(u8, bc.session_id.?, params.sessionId) == false) {
const session_id = bc.session_id orelse return error.UnknownSessionId;
if (std.mem.eql(u8, session_id, params.sessionId) == false) {
// Is this right? Is the params.sessionId meant to be the active
// sessionId? What else could it be? We have no other session_id.
return error.UnknownSessionId;