remove blocking from RequestParams

This commit is contained in:
Muki Kiboigo
2026-04-26 22:10:33 -07:00
parent 3db3281e8e
commit ca08f0c56d
3 changed files with 0 additions and 10 deletions

View File

@@ -871,13 +871,6 @@ pub const RequestParams = struct {
notification: *Notification,
timeout_ms: u32 = 0,
// This is only relevant for intercepted requests. If a request is flagged
// as blocking AND is intercepted, then it'll be up to us to wait until
// we receive a response to the interception. This probably isn't ideal,
// but it's harder for our caller (ScriptManager) to deal with this. One
// reason for that is the Http Client is already a bit CDP-aware.
blocking: bool = false,
const ResourceType = enum {
document,
xhr,

View File

@@ -292,7 +292,6 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
.frame_id = frame._frame_id,
.loader_id = frame._loader_id,
.headers = headers,
.blocking = true,
.cookie_jar = &frame._session.cookie_jar,
.cookie_origin = frame.url,
.resource_type = .script,
@@ -316,7 +315,6 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
.frame_id = frame._frame_id,
.loader_id = frame._loader_id,
.headers = headers,
.blocking = false,
.cookie_jar = &frame._session.cookie_jar,
.cookie_origin = frame.url,
.resource_type = .script,

View File

@@ -114,7 +114,6 @@ fn fetchRobotsThenRequest(
.url = robots_url,
.method = .GET,
.headers = headers,
.blocking = false,
.frame_id = req.params.frame_id,
.loader_id = req.params.loader_id,
.cookie_jar = req.params.cookie_jar,