mirror of
https://github.com/lightpanda-io/browser.git
synced 2026-09-16 16:01:30 -04:00
goto: warn against 'done' in the waitUntil description
Review feedback: 'done' sounds like what people want and is the slowest option. Same treatment as waitForState's description.
This commit is contained in:
1 parent
4a49030af6
commit
ffd293a18e
1 file changed
+1
-1
@@ -342,7 +342,7 @@ pub const Tool = enum {
|
||||
\\ "timeout": { "type": "integer", "description": "Optional timeout in milliseconds. Defaults to 10000." },
|
||||
\\ "waitUntil": { "type": "string", "enum":
|
||||
++ lp.Config.tagJsonArray(lp.Config.WaitUntil) ++
|
||||
\\, "description": "Event that completes the navigation. Defaults to 'load'. Prefer 'domcontentloaded' followed by waitForSelector on pages whose late scripts (ads) hold 'load' back." }
|
||||
\\, "description": "Event that completes the navigation. Defaults to 'load'. Prefer 'domcontentloaded' followed by waitForSelector on pages whose late scripts (ads) hold 'load' back. Avoid 'done' (full quiescence): on pages with constant background activity it is the slowest choice and can run to the timeout." }
|
||||
\\ },
|
||||
\\ "required": ["url"]
|
||||
\\}
|
||||
|
||||
Reference in new issue
Block a user