Remove OSThread inheritance from AtakPluginModule - pure passthrough needs no periodic scheduling

Agent-Logs-Url: https://github.com/meshtastic/firmware/sessions/bdc82eb6-77c4-4711-839c-04bcbb1aa9cd

Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-04-08 20:15:25 +00:00
committed by GitHub
parent a5afef12b4
commit b2e862006d
2 changed files with 2 additions and 14 deletions

View File

@@ -1,21 +1,12 @@
#include "AtakPluginModule.h"
#include "Default.h"
#include "MeshService.h"
#include "configuration.h"
#include "main.h"
AtakPluginModule *atakPluginModule;
AtakPluginModule::AtakPluginModule()
: SinglePortModule("atak", meshtastic_PortNum_ATAK_PLUGIN_V2), concurrency::OSThread("AtakPlugin")
: SinglePortModule("atak", meshtastic_PortNum_ATAK_PLUGIN_V2)
{
}
int32_t AtakPluginModule::runOnce()
{
return default_broadcast_interval_secs * 1000;
}
ProcessMessage AtakPluginModule::handleReceived(const meshtastic_MeshPacket &mp)
{
(void)mp; // Passthrough — no processing needed, apps handle compression/decompression

View File

@@ -1,6 +1,5 @@
#pragma once
#include "SinglePortModule.h"
#include "concurrency/OSThread.h"
/**
* ATAK Plugin V2 module - passthrough for ATAK_PLUGIN_V2 payloads.
@@ -10,7 +9,7 @@
* (Android, iOS, ATAK plugin); firmware forwards the bytes unchanged on the
* ATAK_PLUGIN_V2 port.
*/
class AtakPluginModule : public SinglePortModule, private concurrency::OSThread
class AtakPluginModule : public SinglePortModule
{
public:
/** Constructor
@@ -20,8 +19,6 @@ class AtakPluginModule : public SinglePortModule, private concurrency::OSThread
protected:
virtual ProcessMessage handleReceived(const meshtastic_MeshPacket &mp) override;
/* Does our periodic broadcast */
int32_t runOnce() override;
};
extern AtakPluginModule *atakPluginModule;