mirror/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-05-25 01:12:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

parental-controls: fix read of uninitialized variable

Browse Source 
If content_rating == NULL, then no value will be assigned to
appdata_value, but its value will be used anyway – if it happens to be
non-NULL, it will be dereferenced.

    common/flatpak-parental-controls.c: In function ‘flatpak_oars_check_rating’:
    common/flatpak-parental-controls.c:121:10: warning: ‘appdata_value’ may be used uninitialized in this function [-Wmaybe-uninitialized]
           if (appdata_value != NULL)
              ^
This commit is contained in:
Will Thompson
2019-11-06 20:27:35 +00:00
committed by Alexander Larsson
parent f21d03fae1
commit 1f35dda1b5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/flatpak-parental-controls.c
View File

@@ -113,7 +113,7 @@ flatpak_oars_check_rating (GHashTable *content_rating,
MctAppFilterOarsValue rating_value;
MctAppFilterOarsValue filter_value = mct_app_filter_get_oars_value (filter,
oars_sections[i]);
const gchar *appdata_value;
const gchar *appdata_value = NULL;
if (content_rating != NULL)
appdata_value = g_hash_table_lookup (content_rating, oars_sections[i]);