After ellipsizing nicely, we try to spread the extra
shortfall around, but we need to stop when we've
exhausted the available shrinkage and give up.
Some tables are just too wide.
This was showing up as an infinite loop with
flatpak remote-ls --columns=app,opt flathub
Closes: #2496
Approved by: matthiasclasen
We were printing the full program name as prefix for warnings,
which does not really help with readability. Lets just use
the single-char 'F:' prefix for all messages, regardless of
log level.
Closes: #2472
Approved by: matthiasclasen
Some code paths deep inside flatpak-dir.c use
g_warning to report non-fatal errors. This disrupts
our table formatting without showing up visibly
in the output (since it gets wiped out by the next
redraw). Improve things by installing our own
message handler and showing these messages properly
inside our table, like other errors.
Closes: #2472
Approved by: matthiasclasen
Similar to the --gl-drivers option, print the installation
paths for all system installations, including custom
installations defined in ${sysconfdir}/flatpak/installations.d/
Closes: #2122
Approved by: matthiasclasen
When the -s option is used, it is likely that
the result is getting screenscraped and reparsed.
Make that easier by producing a plain number in
this case.
Closes: #2536
Approved by: mwleeds
Error out for all combinations of options that specify
more than one installations.
This was showing up e.g. with
flatpak config --installation=extra --system --get languages
Closes: #2511
Approved by: mwleeds
Move the -s short option from --src-repo to --subject,
as the docs say. This makes more sense, to go with -b
for --body.
Closes: #2527
Approved by: mwleeds
This is purely cosmetic, but it just does not make
sense to have the --oci option show up in the middle
of gpg-related options.
Closes: #2528
Approved by: mwleeds
Line up the command descriptions with the option descriptions
that GOptionContext produces, for more visually pleasing output.
Closes: #2519
Approved by: mwleeds
There was a copy-paste error causing us to show
system bus ownership wrongly in the permission
table, and causing the footnote numbering to be
out of sync.
Closes: #2535
Approved by: mwleeds
It turns out that --columns=installation,bla was looping
forever, trying to get over the 'all' inside 'installation'.
Don't get stuck there.
It would be good to have unit tests for such internal functions.
Closes: #2463
Approved by: matthiasclasen
Now that we're moving away from a pure ASCII esthetic,
it looks odd to me to have a mixture of 3 dots and
proper ellipsis, so switch everything over to use
U+2026 instead of 3 dots.
Some minor other formatting and string changes
are included here as well.
Closes: #2454
Approved by: alexlarsson
I think this makes a lot more sense than ellipsizing in the middle.
Most app ids start with a common prefix after all.
Closes: #2448
Approved by: alexlarsson
Bubblewrap has a --chdir option to control the directory
that the command is run in. Add an argument for this to
the flatpak_run_app function, update all callers, and add
a --cwd option to flatpak run that uses this new argument.
Closes: #2443
Approved by: alexlarsson
We need to take the "< " part into consideration when even when counting
the size of string without it, because they align the same. Otherwise
we cause the column to resize and wrap.
Closes: #2449
Approved by: alexlarsson
This limits the witdh of the progress bar, because it looked really
weird on a wide terminal and kept changing width as the text at the
end (speed, time left, etc) changed.
It is now never more than 20 chars wide, which is fine with the
new increase in fidelity using unicode blocks.
Closes: #2449
Approved by: alexlarsson
There are unicode full blocks and 1/8ths horizontal parts of a block, so
we can use this for the progress bar to get a lot more fidelity.
Closes: #2449
Approved by: alexlarsson
We use unicode chars like ✓, ⍻ and ✗ for the checkmark area in the table.
Also use an em-dash instead of minus in the spinner.
Closes: #2449
Approved by: alexlarsson
