Rubocop: RSpec/EmptyExampleGroup (#4554)

* Rubocop: RSpec/EmptyExampleGroup

* Undo renaming

* Apply suggestion from @CloCkWeRX

* Apply suggestion from @CloCkWeRX

.rubocop_todo.yml

@@ -242,18 +242,6 @@ RSpec/DescribedClass:
     - 'spec/models/member_spec.rb'
     - 'spec/services/timeline_service_spec.rb'
 
-# Offense count: 7
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/EmptyExampleGroup:
-  Exclude:
-    - 'spec/controllers/authentications_controller_spec.rb'
-    - 'spec/controllers/forums_controller_spec.rb'
-    - 'spec/controllers/seeds_controller_spec.rb'
-    - 'spec/features/plantings/planting_a_crop_spec.rb'
-    - 'spec/views/home/index_spec.rb'
-    - 'spec/views/photos/edit.html.haml_spec.rb'
-    - 'spec/views/posts/_single.html.haml_spec.rb'
-
 # Offense count: 146
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
@@ -318,7 +306,6 @@ RSpec/IndexedLet:
     - 'spec/features/percy/percy_spec.rb'
     - 'spec/features/planting_reminder_spec.rb'
     - 'spec/features/timeline/index_spec.rb'
-    - 'spec/models/crop_spec.rb'
     - 'spec/models/member_spec.rb'
     - 'spec/views/forums/index.html.haml_spec.rb'
 

spec/controllers/authentications_controller_spec.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-describe AuthenticationsController do
-  before do
-    @member = create(:member)
-    sign_in @member
-    controller.stub(:current_member) { @member }
-    @auth = create(:authentication, member: @member)
-    request.env['omniauth.auth'] = {
-      'provider'    => 'foo',
-      'uid'         => 'bar',
-      'info'        => { 'nickname' => 'blah' },
-      'credentials' => { 'token' => 'blah', 'secret' => 'blah' }
-    }
-  end
-end

spec/controllers/forums_controller_spec.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-describe ForumsController do
-  login_member(:admin_member)
-
-  def valid_attributes
-    {
-      "name"        => "MyString",
-      "description" => "Something",
-      "owner_id"    => 1
-    }
-  end
-
-  def valid_session
-    {}
-  end
-end

spec/controllers/seeds_controller_spec.rb

@@ -21,10 +21,6 @@ describe SeedsController, :search do
 
     it { expect(response).to be_successful }
 
-    context 'no parent planting' do
-      before { get :new }
-    end
-
     context 'with parent planting' do
       let!(:planting) { create(:planting, owner:) }
 

spec/features/plantings/planting_a_crop_spec.rb

@@ -286,9 +286,9 @@ describe "Planting a crop", :js, :search do
           check "Mark as finished"
           click_button "Save"
         end
-
-        it { expect(page).to have_css("img[alt='sun']") }
       end
+
+      xit { expect(page).to have_css("img[alt='sun']") }
     end
 
     describe "Marking a planting as finished from the show page" do

spec/views/home/index_spec.rb

@@ -33,12 +33,4 @@ describe 'home/index.html.haml', type: "view" do
       rendered.should have_content @member.location
     end
   end
-
-  context 'signed in' do
-    before do
-      sign_in @member
-      controller.stub(:current_user) { @member }
-      render
-    end
-  end
 end

spec/views/photos/edit.html.haml_spec.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-describe "photos/edit" do
-  before do
-    @photo = assign(:photo, stub_model(Photo,
-                                       owner_id:        1,
-                                       flickr_photo_id: 1,
-                                       thumbnail_url:   "MyString",
-                                       fullsize_url:    "MyString"))
-  end
-end

spec/views/posts/_single.html.haml_spec.rb

@@ -43,16 +43,6 @@ describe "posts/_single" do
     end
   end
 
-  context "when logged in as post author" do
-    before do
-      @member = create(:member)
-      sign_in @member
-      controller.stub(:current_user) { @member }
-      @post = create(:post, author: @member)
-      render_post
-    end
-  end
-
   context "when post has been edited" do
     before do
       @member = create(:member)