mirror/insomnia
1
0
Fork 0
mirror of https://github.com/Kong/insomnia.git synced 2026-04-20 22:27:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

hardcode templating to renderInProcess (#8472)

Browse Source
This commit is contained in:
Jack Kavanagh
2025-03-17 17:36:34 +01:00
committed by Jay Wu
parent 8322886516
commit 1212e45fae
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/insomnia/src/common/render.ts
View File

@@ -71,10 +71,10 @@ export async function buildRenderContext(
ancestors?: RenderContextAncestor[];
rootEnvironment?: Environment;
subEnvironment?: Environment;
rootGlobalEnvironment?: Environment | null;
subGlobalEnvironment?: Environment | null;
userUploadEnvironment?: UserUploadEnvironment;
transientVariables?: Environment;
rootGlobalEnvironment?: Environment | null;
subGlobalEnvironment?: Environment | null;
userUploadEnvironment?: UserUploadEnvironment;
transientVariables?: Environment;
baseContext?: Record<string, any>;
},
) {
@@ -332,12 +332,16 @@ export async function render<T>(
// plugins will not function correctly when rendering in a separate process or thread. The user can
// explicitly configure rendering to happen on the same thread/process as the rest of the app, in
// which case it's okay to render locally.
const settings = await models.settings.get();
const pluginsAllowElevatedAccess = settings?.pluginsAllowElevatedAccess;
const shouldUseWorker = process.type === 'renderer' && pluginsAllowElevatedAccess === false;
const renderFork = shouldUseWorker
? (await import('../ui/worker/templating-handler')).renderInWorker
: renderInThisProcess;
// TODO: remove this when we're ready to enable this feature
const renderFork = renderInThisProcess;
// const settings = await models.settings.get();
// const pluginsAreRestrictedToRunInWorker = settings?.pluginsAllowElevatedAccess === false;
// const currentProcessIsRendererAndPluginsAreRestricted = process.type === 'renderer' && pluginsAreRestrictedToRunInWorker;
// const renderFork = currentProcessIsRendererAndPluginsAreRestricted
// ? (await import('../ui/worker/templating-handler')).renderInWorker
// : renderInThisProcess;
// @ts-expect-error -- TSCONVERSION
input = await renderFork({ input, context, path, ignoreUndefinedEnvVariable });