mirror/insomnia
1
0
Fork 0
mirror of https://github.com/Kong/insomnia.git synced 2026-08-04 11:52:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent stale features from race condition in AISettings useEffect

Browse Source 
Reset to fallbackFeatures when fetch condition is not met, and use a
cancelled flag to ignore responses from outdated requests after unmount
or dependency change.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
jackkav
2026-05-26 11:01:25 +02:00
committed by Jack Kavanagh
parent 977677cd2d
commit cd9ddb07ed
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/insomnia/src/ui/components/settings/ai-settings.tsx
View File

@@ -20,11 +20,15 @@ export const AISettings = () => {
const [features, setFeatures] = useState<FeatureList>(fallbackFeatures);
useEffect(() => {
if (organizationId && userSession.id && !models.organization.isScratchpadOrganizationId(organizationId)) {
getOrganizationFeatures({ organizationId, sessionId: userSession.id })
.then(res => setFeatures(res?.features || fallbackFeatures))
.catch(() => setFeatures(fallbackFeatures));
if (!organizationId || !userSession.id || models.organization.isScratchpadOrganizationId(organizationId)) {
setFeatures(fallbackFeatures);
return;
}
let cancelled = false;
getOrganizationFeatures({ organizationId, sessionId: userSession.id })
.then(res => { if (!cancelled) { setFeatures(res?.features || fallbackFeatures); } })
.catch(() => { if (!cancelled) { setFeatures(fallbackFeatures); } });
return () => { cancelled = true; };
}, [organizationId, userSession.id]);
const [currentLLM, setCurrentLLM] = useState<LLMConfig | null>(null);
const [selectedBackend, setSelectedBackend] = useState<LLMBackend>('gguf');