mirror of
https://github.com/Kong/insomnia.git
synced 2026-10-27 17:19:42 -04:00
fix: url bar auto-focus (#5199)
* connect unique key hack up to focus useEffect * fix lint Co-authored-by: Filipe Freire <livrofubia@gmail.com>
This commit is contained in:
1 parent
8c7d74a0c9
commit
e83badf767
1 file changed
+9
-12
@@ -3,7 +3,6 @@ import { deconstructQueryStringToParams, extractQueryStringFromUrl } from 'insom
|
||||
import React, { FC, useCallback, useEffect, useRef } from 'react';
|
||||
import { useSelector } from 'react-redux';
|
||||
import { Tab, TabList, TabPanel, Tabs } from 'react-tabs';
|
||||
import { useMount } from 'react-use';
|
||||
|
||||
import { getContentTypeFromHeaders } from '../../../common/constants';
|
||||
import * as models from '../../../models';
|
||||
@@ -99,17 +98,6 @@ export const RequestPane: FC<Props> = ({
|
||||
});
|
||||
}
|
||||
}, [request]);
|
||||
|
||||
const requestUrlBarRef = useRef<RequestUrlBarHandle>(null);
|
||||
useMount(() => {
|
||||
requestUrlBarRef.current?.focusInput();
|
||||
});
|
||||
useEffect(() => {
|
||||
requestUrlBarRef.current?.focusInput();
|
||||
}, [
|
||||
request?._id, // happens when the user switches requests
|
||||
settings.hasPromptedAnalytics, // happens when the user dismisses the analytics modal
|
||||
]);
|
||||
const gitVersion = useGitVCSVersion();
|
||||
const activeRequestSyncVersion = useActiveRequestSyncVCSVersion();
|
||||
const activeEnvironment = useSelector(selectActiveEnvironment);
|
||||
@@ -117,6 +105,15 @@ export const RequestPane: FC<Props> = ({
|
||||
// Force re-render when we switch requests, the environment gets modified, or the (Git|Sync)VCS version changes
|
||||
const uniqueKey = `${activeEnvironment?.modified}::${request?._id}::${gitVersion}::${activeRequestSyncVersion}::${activeRequestMeta?.activeResponseId}`;
|
||||
|
||||
const requestUrlBarRef = useRef<RequestUrlBarHandle>(null);
|
||||
useEffect(() => {
|
||||
requestUrlBarRef.current?.focusInput();
|
||||
}, [
|
||||
request?._id, // happens when the user switches requests
|
||||
settings.hasPromptedAnalytics, // happens when the user dismisses the analytics modal
|
||||
uniqueKey,
|
||||
]);
|
||||
|
||||
if (!request) {
|
||||
return (
|
||||
<PlaceholderRequestPane />
|
||||
|
||||
Reference in new issue
Block a user