mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-07 22:26:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add comment about redundant condition

Browse Source 
This has been there since KDE 4.0 - need to check if there is missing
logic or just a mistake.
via cppcheck
This commit is contained in:
Kurt Hindenburg
2013-01-31 10:50:59 -05:00
parent bd7e231403
commit a6793123dc
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Vt102Emulation.cpp
View File

@@ -1224,6 +1224,8 @@ void Vt102Emulation::setMode(int m)
setScreen(1);
break;
}
// FIXME: Currently this has a redundant condition as MODES_SCREEN is 6
// and MODE_NewLine is 5
if (m < MODES_SCREEN || m == MODE_NewLine) {
_screen[0]->setMode(m);
_screen[1]->setMode(m);
@@ -1250,6 +1252,8 @@ void Vt102Emulation::resetMode(int m)
setScreen(0);
break;
}
// FIXME: Currently this has a redundant condition as MODES_SCREEN is 6
// and MODE_NewLine is 5
if (m < MODES_SCREEN || m == MODE_NewLine) {
_screen[0]->resetMode(m);
_screen[1]->resetMode(m);