mirror of
https://github.com/pnpm/pnpm.git
synced 2026-07-19 12:12:34 -04:00
ci(pacquet): scope the e2e run to the pnpm package only
Now that --no-runtime fixed the VM-modules loader, tests actually run. The next failure mode was real: other workspace packages (e.g. @pnpm/building.commands) shell out to pnpm in their tests, and PNPM_E2E_BIN routes those calls through pacquet, which doesn't implement every command they exercise. Add a dedicated test-pkgs-pnpm script so the e2e job runs jest only in the pnpm package and PNPM_E2E_BIN affects nothing else. Written by an agent (Claude Code, claude-opus-4-7).
This commit is contained in:
12
.github/workflows/pacquet-ci.yml
vendored
12
.github/workflows/pacquet-ci.yml
vendored
@@ -176,11 +176,13 @@ jobs:
|
||||
# auto-reinstalls before every script and seems to break jest's
|
||||
# VM-modules loader. test.yml disables it for the same reason.
|
||||
pnpm_config_verify_deps_before_run: false
|
||||
# `pn run test-pkgs-all` matches the call shape test.yml uses (via
|
||||
# `ci:test-all`): the hidden `.test` invocation lives inside a
|
||||
# script-to-script chain, which is the only way pnpm allows it.
|
||||
# Calling `pn -r .test` directly trips ERR_PNPM_HIDDEN_SCRIPT.
|
||||
run: pnpm run test-pkgs-all
|
||||
# Use the dedicated `test-pkgs-pnpm` script so PNPM_E2E_BIN only
|
||||
# affects the pnpm package's e2e suite — running every package's
|
||||
# `.test` would route their pnpm-driven assertions through pacquet
|
||||
# too, which fails for commands pacquet doesn't implement.
|
||||
# Going through a package.json script also keeps the hidden `.test`
|
||||
# invocation inside a script chain (required by pnpm).
|
||||
run: pnpm run test-pkgs-pnpm
|
||||
|
||||
doc:
|
||||
name: Doc
|
||||
|
||||
@@ -14,6 +14,7 @@
|
||||
"ci:test-all": "pn prepare-fixtures && pn test-pkgs-all",
|
||||
"remove-temp-dir": "shx rm -rf ../pnpm_tmp",
|
||||
"test-pkgs-all": "pn remove-temp-dir && pn --no-sort --workspace-concurrency=1 -r .test",
|
||||
"test-pkgs-pnpm": "pn remove-temp-dir && pn --filter=pnpm --workspace-concurrency=1 -r .test",
|
||||
"test-branch": "pn pretest && pn lint && git remote set-branches --add origin main && git fetch origin main && pn test-pkgs-branch",
|
||||
"ci:test-branch": "pn prepare-fixtures && pn test-pkgs-branch",
|
||||
"test-pkgs-branch": "pn remove-temp-dir && pn --workspace-concurrency=1 --filter=...[origin/main] --no-sort --if-present .test",
|
||||
|
||||
Reference in New Issue
Block a user