mirror/sdkman-cli
1
0
Fork 0
mirror of https://github.com/sdkman/sdkman-cli.git synced 2026-04-20 23:17:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove withOfflineMode() calls from Groovy Specs

Browse Source 
Missed EnvCommandSpec, CurrentCommandSpec, and ConfigCommandSpec which
still called withOfflineMode() on SdkmanBashEnvBuilder after the method
was removed.
This commit is contained in:
Chloé
2026-03-23 09:22:11 +00:00
committed by Marco Vermeulen
parent a1cc356057
commit 1e879a8628
3 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/test/groovy/sdkman/specs/ConfigCommandSpec.groovy
View File

@@ -6,7 +6,6 @@ class ConfigCommandSpec extends SdkmanEnvSpecification {
def "it should open the config in the system's default editor"() {
given:
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.build()
bash.start()

1
src/test/groovy/sdkman/specs/CurrentCommandSpec.groovy
View File

@@ -40,7 +40,6 @@ class CurrentCommandSpec extends SdkmanEnvSpecification {
]
bash = sdkmanBashEnvBuilder
.withOfflineMode(false)
.withCandidates(installedCandidates.keySet().toList())
.build()

12
src/test/groovy/sdkman/specs/EnvCommandSpec.groovy
View File

@@ -18,7 +18,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
setupCandidates(candidatesDirectory)
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.build()
bash.start()
@@ -60,7 +59,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
}
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.build()
new File(bash.workDir, '.sdkmanrc').text = sdkmanrc
@@ -96,7 +94,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
}
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.withConfiguration("sdkman_auto_env", sdkmanAutoEnv)
.build()
@@ -130,7 +127,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
}
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.withConfiguration("sdkman_auto_env", "true")
.build()
@@ -160,7 +156,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
}
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.withConfiguration("sdkman_auto_env", "true")
.build()
@@ -186,7 +181,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
}
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.withConfiguration("sdkman_auto_env", "true")
.build()
@@ -219,7 +213,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
createSymbolicLink(Paths.get("$candidatesDirectory/groovy/current"), Paths.get("$candidatesDirectory/groovy/2.4.6"))
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.withConfiguration("sdkman_auto_env", "true")
.build()
@@ -257,7 +250,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
createSymbolicLink(Paths.get("$candidatesDirectory/ant/current"), Paths.get("$candidatesDirectory/ant/1.10.8"))
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.withConfiguration("sdkman_auto_env", "true")
.build()
@@ -304,7 +296,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
}
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.withConfiguration("sdkman_auto_env", "true")
.build()
@@ -329,7 +320,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
def "should issue an error if .sdkmanrc contains a malformed candidate version"() {
given:
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.build()
new File(bash.workDir, ".sdkmanrc").text = "groovy 2.4.1"
@@ -350,7 +340,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
def "should issue an error when .sdkmanrc contains a candidate version which is not installed"() {
given:
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.build()
new File(bash.workDir, ".sdkmanrc").text = "groovy=2.4.1"
@@ -378,7 +367,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification {
}
bash = sdkmanBashEnvBuilder
.withOfflineMode(true)
.build()
new File(bash.workDir, ".sdkmanrc").text = sdkmanrc