mirror/web
1
0
Fork 0
mirror of https://github.com/meshtastic/web.git synced 2025-12-23 15:51:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: use correct deprecated GPS coordinate format enum (#917)

Browse Source 
The Config_DisplayConfig_GpsCoordinateFormat export doesn't exist in the protobufs package. The correct export is Config_DisplayConfig_DeprecatedGpsCoordinateFormat, which matches what's used in the validation schema.

Added TODO comment explaining that this field is deprecated since protobufs 2.7.4 and should be migrated to DeviceUIConfig.gps_format when DeviceUI settings are implemented.
This commit is contained in:
Kamil Dzieniszewski
2025-10-29 15:12:04 +01:00
committed by GitHub
parent f375911c4a
commit 679f7986cc
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/web/src/components/PageComponents/Settings/Display.tsx
View File

@@ -50,6 +50,10 @@ export const Display = ({ onFormInit }: DisplayConfigProps) => {
suffix: t("unit.second.plural"),
},
},
// TODO: This field is deprecated since protobufs 2.7.4 and only has UNUSED=0 value.
// GPS format has been moved to DeviceUIConfig.gps_format with proper enum values (DEC, DMS, UTM, MGRS, OLC, OSGR, MLS).
// This should be removed once DeviceUI settings are implemented.
// See: packages/protobufs/meshtastic/device_ui.proto
{
type: "select",
name: "gpsFormat",
@@ -57,7 +61,7 @@ export const Display = ({ onFormInit }: DisplayConfigProps) => {
description: t("display.gpsDisplayUnits.description"),
properties: {
enumValue:
Protobuf.Config.Config_DisplayConfig_GpsCoordinateFormat,
Protobuf.Config.Config_DisplayConfig_DeprecatedGpsCoordinateFormat,
},
},
{