Commit Graph

7054 Commits

Author SHA1 Message Date
Phaedrus Leeds
bf99c266a8 app: Tweak messages about dependent apps
Use a "Info: " prefix which matches the message printed in
print_eol_info_message(). Also make the message accurately use either
the word "runtime" or "extension" as appropriate.
2022-07-21 14:32:45 -05:00
Phaedrus Leeds
65a4bb0a3d uninstall: Ask for confirmation for used runtime extensions
Based on discussions on the issue tracker, it seems that users sometimes
remove runtime extensions without really understanding whether they're
in use. Add a confirmation prompt to address this.

Helps: #4549
2022-07-21 14:32:45 -05:00
Phaedrus Leeds
ae0de69b17 app: Improve checking for dependent apps in EOL messages
flatpak_dir_list_app_refs_with_runtime_extension() only works when the
runtime extension it is passed and the apps it returns are both
installed. Sometimes a end-of-life message is printed for a runtime that
is not installed but is being installed by the current transaction, or a
runtime that is installed but one of the apps that needs it is being
installed by the current transaction. To cover these cases, check the
operations in the current transaction when building informational
messages about EOL runtimes.
2022-07-21 14:32:45 -05:00
Phaedrus Leeds
e739773056 app: List apps that use a runtime extension when it's EOL
Currently if a runtime extension, e.g.
org.freedesktop.Platform.html5-codecs//18.08 is used by a runtime
org.kde.Platform//5.12 which itself is used by one or more apps, when we
print a message to the user about html5-codecs being EOL, we don't find
any apps using it and don't print any. Fix this by including apps that
indirectly use a runtime extension in the "Applications using this
runtime:" list.

In a later commit we can re-use the helper function added here to add a
confirmation dialog if the user tries to remove a runtime extension
that's being used; currently we just let them remove it.

This is limited to only looking in the current flatpak installation, so
a per-user app using a system-wide runtime extension would not be found.

This is implemented using in-memory caches because otherwise it is
horribly slow; see
https://github.com/flatpak/flatpak/pull/4835#discussion_r876425289

Helps: #3531
2022-07-21 14:32:45 -05:00
Phaedrus Leeds
07ef6a41fa transaction: Fix typos and wrap lines 2022-07-20 21:37:03 -05:00
Phaedrus Leeds
dffa10dd61 transaction: Tweak docs on get_related_to_ops() API 2022-07-20 21:37:03 -05:00
Alexmelman88
aee4596ffb Update ru.po (#4975) 2022-07-20 21:33:52 -05:00
dundunplus
5c5a30ed9c Updated Chinese translation (#4993) 2022-07-20 21:01:12 -05:00
Debarshi Ray
0329f657ee selinux: Permit read access to symbolic links in /var/lib/flatpak
Commit 8617ab0ad0 granted read and lock access to
/var/lib/flatpak but didn't cover symbolic links.  This explicitly
permits that to avoid running into SELinux denials.

https://bugzilla.redhat.com/show_bug.cgi?id=2071215
2022-07-20 20:43:54 -05:00
Phaedrus Leeds
f0c1097690 doc/flatpak-override: Tweak manpage 2022-07-18 19:23:57 -05:00
Phaedrus Leeds
43768b2510 common: Remove erroneous Since: annotations
I think these were accidentally copied from GLib.
2022-07-18 18:51:07 -05:00
Phaedrus Leeds
320889c1a2 app/flatpak-complete.c: Fix typo 2022-07-18 18:51:07 -05:00
Phaedrus Leeds
bf93e004e9 app: Fix inefficiency in pin and mask commands
There's no point reading data from disk on a code path that doesn't do
anything with it.
2022-07-18 18:51:07 -05:00
Fina Wilke
f4b038c8b1 Increase verbosity of extension missing error messages
Adds arch and branch to the error message to help with locating the required
extension arch and branch.
2022-07-17 15:36:21 -05:00
Debarshi Ray
120322cb8f CI: Use CodeQL Action v2, not the deprecated v1
See:
https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/
2022-06-28 18:26:45 -07:00
Phaedrus Leeds
26a8124478 Revert "CI: Temporarily build without libsystemd"
This reverts commit ea879dc38c.

Folks say the issue is fixed on launchpad:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1979579
2022-06-28 18:23:40 -07:00
Phaedrus Leeds
b93d928679 .gitignore: Add tests/runtime-repo.stamp 2022-06-27 20:15:41 +01:00
Simon McVittie
0c5e4abbea try-syscall: Cope with old glibc without PR_SET_CHILD_SUBREAPER defined
Originally part of containers/bubblewrap#496 in bubblewrap.

Signed-off-by: Simon McVittie <smcv@collabora.com>
2022-06-27 10:02:25 -07:00
Simon McVittie
836b0fb604 try-syscall: Use compiler-predefined macros to detect mips ABI
_MIPS_SIM_ABI32 etc. are defined by Linux <asm/sgidefs.h>, which is
included by glibc <sys/syscall.h> (which defers to Linux headers to
get syscall numbers), but not by musl <sys/syscall.h>.

_ABIO32 etc. are predefined by the compiler, so they are always
available, regardless of libc. References:

https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=27d54b2a6c18ef1ae50f1a5b432d590438445b90
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=0ea339ea4d9c3e04ae17da6bf389617eb0251e57

Originally containers/bubblewrap#492 in bubblewrap.

Signed-off-by: Simon McVittie <smcv@collabora.com>
2022-06-27 10:02:25 -07:00
Phaedrus Leeds
ea879dc38c CI: Temporarily build without libsystemd
To fix the CI until this is resolved:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1979579
2022-06-24 15:11:41 -07:00
Phaedrus Leeds
6e5fb9dbc7 tests: Skip test-history.sh without libsystemd 2022-06-24 15:11:41 -07:00
Yuri Chornoivan
1b1fead748 Update Ukrainian translation 2022-06-24 10:15:50 -07:00
yakusha
02008eb1cb Update Turkish translation 2022-06-24 09:47:05 -07:00
Anders Jonsson
b243a290ff Update Swedish translation 2022-06-20 13:19:35 +02:00
Yuri Chornoivan
a91cd23f06 Update Ukrainian translation 2022-06-20 13:19:10 +02:00
Philip Withnall
ab028e0d71 flatpak-remote: Fix some minor leaks of some property values
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
2022-06-20 13:17:45 +02:00
Piotr Drąg
6e157b95f3 Update POTFILES.in 2022-06-17 16:11:45 +02:00
Phaedrus Leeds
36b4d325fd Update pofiles for release 1.13.3 2022-06-16 15:57:42 -07:00
Phaedrus Leeds
1638be784d build: Bump version to 1.13.3 2022-06-16 15:57:42 -07:00
Phaedrus Leeds
22d52c6bc1 Update NEWS for 1.13.3 2022-06-16 15:57:42 -07:00
Debarshi Ray
c3e0b76ebe NEWS: Update for 1.13.3 so far 2022-06-16 09:52:23 -07:00
Alexander Larsson
4247e61fbe CI: Build appstream dependency
We need appstream >= 0.15.3 to get this fix:
  https://github.com/ximion/appstream/issues/384

Without it the test-suite fails.
2022-06-16 13:49:45 +02:00
Alexander Larsson
300c00c910 Extend the CI build support, including testing the soup backend
This adds a separate, more modern CI build running on ubuntu 22.04
using curl, and leaves the old one around building against soup.

In addition, the modern one uses the system bwrap and dbus-proxy so
that we test these configurations too (and because the modern system
has good versions of these).

I also enabled running parallel make check again, hoping that
whatever made this hang is now fixed. We'll see.
2022-06-16 13:49:45 +02:00
Alexander Larsson
9695923f14 CI: Add libcurl-dev to CI install 2022-06-16 13:49:45 +02:00
Alexander Larsson
aea92f3909 http: Support curl
If build with curl (--with-curl, which is default) then we use libcurl
instead of libsoup as the http backend.
2022-06-16 13:49:45 +02:00
Alexander Larsson
0c6bb85cb6 flatpak-http: Restructure the soup http implementation
This miniminzes the soup implementation by moving it out of the
highlevel multiple-retry entry points and simplifying the
lower level part to use only one shared helper.

This will also make it easier to replace the soup specific
parts.
2022-06-16 13:49:45 +02:00
Alexander Larsson
0de4800c3b tests: Don't fail if OSTREE_DEBUG_HTTP is set in the test env 2022-06-16 13:49:45 +02:00
Alexander Larsson
69f4543bc0 uri utils: Add some helpers for HTTP timestamps 2022-06-16 13:49:45 +02:00
Alexander Larsson
1c9e65d5e4 Move all use of soup APIs into flatpak-utils-http
This will allow us to make the soup dependency optional.
2022-06-16 13:49:45 +02:00
Alexander Larsson
676c018113 oci-registry: Use the new http methods to replace last soup use 2022-06-16 13:49:45 +02:00
Alexander Larsson
6f15c147c5 flatpak-uri: Add some uri query and http header utils
This copies and simplifies some helpers from soup:
 * Encoding url queries
 * Parsing simple http header parameter lists

The goal is to use mostly GUri and a few extra helpers for the flatpak
internals, and then pass raw string uris to the http functions which
could then be backed by any kind of http implementation.
2022-06-16 13:49:45 +02:00
Alexander Larsson
98651d33b6 oci-registry: Use the new utils to encode url queries 2022-06-16 13:49:45 +02:00
Alexander Larsson
62f33a4d6d oci-registry: Use the new http header parser 2022-06-16 13:49:45 +02:00
Alexander Larsson
618d0c8fae http: Add flatpak_load_uri_full with some more complete features
This allows:
 * getting http status
 * getting www-authenticate header
 * Doing HEAD instead of get

This is needed by the OCI registry code for authentication
2022-06-16 13:49:45 +02:00
Alexander Larsson
b1083a4c41 http utils: Make a generic FlatpakHttpSession instead of SoupSession
Its still just a SoupSession, but now the implementation is more
centralized and can be something else down the line.
2022-06-16 13:49:45 +02:00
Alexander Larsson
d4508905a5 Use GUri (possibly with backport) instead of SoupURI
As discussed in https://github.com/flatpak/flatpak/pull/4582 we
want ot use GUri for soup3, and if we want to use libcurl we might
as well also use it to avoid complex ifdefs, as we're linking to it
already via glib.

This imports a subset of GUri for older versions of glib.
2022-06-16 13:49:45 +02:00
Alexander Larsson
f800c79e6f oci-registry: Be better at finding error message in registry reponses
This now finds the correct error message in the redhat oci repo for rhel.
2022-06-16 13:49:45 +02:00
Phaedrus Leeds
e9030fe2f6 update: Add newline before nothing to do message
This looks better in case there are warnings or info messages printed
during the update operation, since those are separated from each other
by newlines (at least the EOL ones).
2022-06-15 16:44:17 -07:00
Phaedrus Leeds
f8d24a9b1e app: Use bold app ID for permissions heading 2022-06-15 16:44:17 -07:00
Phaedrus Leeds
d764202ce7 transaction: Add new API for getting an op by ref
This will be useful in gnome-software's flatpak plugin, which currently
iterates over the operations a few times, and it will be useful
internally as well.
2022-06-15 16:44:17 -07:00