The "adoptees" section seems to break the pipeline if empty or contains a blank. Removing it altogether until we start the "adopt and app section" of the fundraiser.
Issue:
When saving output as HTML, for multiple lines with the same style, only the first line had a `<span>`, while subsequent lines lack styling.
Change:
For the first character, if there is no style change, apply the stored `_style`.
BUG: 509784
default is off
I think the defaults should be safe, for people that need
it for scripting, which is for sure a minimal fraction
of the users, one click will turn it on.
(or one patched config file)
This commit tried to improves the look of curly underline implemented
in 5ab23a96 by replacing arcs with quadratic Bezier curves. The
performance of the render is mostly unaltered.
Enabling antialiasing provides an even better result, but the
performance impact is too relevant.
"Auto save output as" still became "Stop Autosave" when cancelling in file dialog.
Make SessionTask::execute return value that indicates the task has been spawned
successfully or not. So SessionController::autoSaveHistory could decide whether
to change the visibility of _startAutoSaveAction and _stopAutoSaveAction.
BUG: 507069
Rather than just waiting 5ms and assuming things failed if nothing
happened after that, query the job we get from systemd to see if cgroup
creation is still running. This handles things a lot more gracefully
when systemd or DBus is slow(er) to respond.
When creating a cgroup for a tab, we would use a hardcoded string as
cgroup name that included `org.kde.konsole` as app ID. This leads to
tabs incorrectly being attributed to Konsole in System Monitor's
application page, even if the tab is actually embedded in a different
application such as Kate.
Instead of hardcoding the app ID, use the application's desktop file
name, so that if we lookup the app ID from a cgroup name, we get back to
the original application instead of Konsole.
BUG: 508716
Curly underlines are implemented by drawing two parallel, complementary-dashed
lines with a distance of 2 pixels.
This means they dont' scale with font size. They only look good with a small
font size. At a first glance, they are also not so easy to tell apart from
regular underlines.
Fix this by
1. drawing a cosine wave instead of of parallel dashed lines
2. always drawing a full wave period per glph, indendent of the font size
3. using the text line width, instead of always using 1px
A similar (but much less prominent) issue exists for double underlines.
Change them too, keeping the implementation consistent.
Tested with
printf '\033[31m\033[4:3mcurly\033[4m\033[31m\033[4:2mdouble\033[4m'
Note that the curly underline overlaps with the "y". Perhaps we should
fix this.
Probably there are more improvements to be made, and it's possible there is
a more elegant solution than repeated drawArc() calls.
Publishing this early nevertheless because it's hopefully close to an overall
improvement; But I did not have a chance to look into the bugs mentioned in
76f879cd7 (Draw characters in exact positions, 2022-08-06)
